Message ID | 20230114225647.227972-1-aford173@gmail.com (mailing list archive) |
---|---|
State | Mainlined |
Commit | acdc7b111b73bd900ce4a10aaa829d16cf21baaa |
Delegated to: | Geert Uytterhoeven |
Headers | show |
Series | [1/3] arm64: dts: beacon-renesom: Fix gpio expander reference | expand |
On Sat, Jan 14, 2023 at 11:56 PM Adam Ford <aford173@gmail.com> wrote: > The board used to originally introduce the Beacon Embedded > RZ/G2[M/N/H] boards had a GPIO expander with address 20, but > this was change when the final board went to production. > > The production boards changed both the part itself and > the address. With the incorrect address, the LCD cannot > come up. If the LCD fails, the rcar-du driver fails to come up, > and that also breaks HDMI. > > Pre-release board were not shipped to the general public, so it > should be safe to push this as a fix. Anyone with a production > board would have video fail due to this GPIO expander change. > > Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > V2: Update compatible to reflect the part change. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi index d3ec8c45d5af..518885cb1e7e 100644 --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi @@ -437,20 +437,6 @@ wm8962_endpoint: endpoint { }; }; - /* 0 - lcd_reset */ - /* 1 - lcd_pwr */ - /* 2 - lcd_select */ - /* 3 - backlight-enable */ - /* 4 - Touch_shdwn */ - /* 5 - LCD_H_pol */ - /* 6 - lcd_V_pol */ - gpio_exp1: gpio@20 { - compatible = "onnn,pca9654"; - reg = <0x20>; - gpio-controller; - #gpio-cells = <2>; - }; - touchscreen@26 { compatible = "ilitek,ili2117"; reg = <0x26>; @@ -482,6 +468,21 @@ hd3ss3220_out_ep: endpoint { }; }; }; + + gpio_exp1: gpio@70 { + compatible = "nxp,pca9538"; + reg = <0x70>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = + "lcd_reset", + "lcd_pwr", + "lcd_select", + "backlight-enable", + "Touch_shdwn", + "LCD_H_pol", + "lcd_V_pol"; + }; }; &lvds0 {
The board used to originally introduce the Beacon Embedded RZ/G2[M/N/H] boards had a GPIO expander with address 20, but this was change when the final board went to production. The production boards changed both the part itself and the address. With the incorrect address, the LCD cannot come up. If the LCD fails, the rcar-du driver fails to come up, and that also breaks HDMI. Pre-release board were not shipped to the general public, so it should be safe to push this as a fix. Anyone with a production board would have video fail due to this GPIO expander change. Fixes: a1d8a344f1ca ("arm64: dts: renesas: Introduce r8a774a1-beacon-rzg2m-kit") Signed-off-by: Adam Ford <aford173@gmail.com> --- V2: Update compatible to reflect the part change.