| Message ID | 20230116202126.50400-2-doug@schmorgal.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: libertas: IE handling fixes | expand |
> -----Original Message----- > From: Doug Brown <doug@schmorgal.com> > Sent: Tuesday, January 17, 2023 4:21 AM > To: Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com> > Cc: Dan Williams <dcbw@redhat.com>; Simon Horman <simon.horman@corigine.com>; > libertas-dev@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Doug Brown > <doug@schmorgal.com> > Subject: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct > > This struct is currently unused, but it will be used in future patches. > Fix the code style to not use camel case. > > Signed-off-by: Doug Brown <doug@schmorgal.com> > --- > drivers/net/wireless/marvell/libertas/types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/libertas/types.h > b/drivers/net/wireless/marvell/libertas/types.h > index cd4ceb6f885d..398e3272e85f 100644 > --- a/drivers/net/wireless/marvell/libertas/types.h > +++ b/drivers/net/wireless/marvell/libertas/types.h > @@ -105,7 +105,7 @@ struct mrvl_ie_header { > > struct mrvl_ie_data { > struct mrvl_ie_header header; > - u8 Data[1]; > + u8 data[1]; data[]. see [1] [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays > } __packed; > > struct mrvl_ie_rates_param_set { > -- > 2.34.1
On 1/16/2023 7:39 PM, Ping-Ke Shih wrote: > > >> -----Original Message----- >> From: Doug Brown <doug@schmorgal.com> >> Sent: Tuesday, January 17, 2023 4:21 AM >> To: Kalle Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet >> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com> >> Cc: Dan Williams <dcbw@redhat.com>; Simon Horman <simon.horman@corigine.com>; >> libertas-dev@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Doug Brown >> <doug@schmorgal.com> >> Subject: [PATCH v3 1/4] wifi: libertas: fix capitalization in mrvl_ie_data struct >> >> This struct is currently unused, but it will be used in future patches. >> Fix the code style to not use camel case. >> >> Signed-off-by: Doug Brown <doug@schmorgal.com> >> --- >> drivers/net/wireless/marvell/libertas/types.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/marvell/libertas/types.h >> b/drivers/net/wireless/marvell/libertas/types.h >> index cd4ceb6f885d..398e3272e85f 100644 >> --- a/drivers/net/wireless/marvell/libertas/types.h >> +++ b/drivers/net/wireless/marvell/libertas/types.h >> @@ -105,7 +105,7 @@ struct mrvl_ie_header { >> >> struct mrvl_ie_data { >> struct mrvl_ie_header header; >> - u8 Data[1]; >> + u8 data[1]; > > data[]. see [1] > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays Hi Ping-Ke, Thanks for the link. There are several other cases of this same syntax for flexible trailing arrays in this file, so I will update this patch in the next version of the series to fix them all. > >> } __packed; >> >> struct mrvl_ie_rates_param_set { >> -- >> 2.34.1 >
diff --git a/drivers/net/wireless/marvell/libertas/types.h b/drivers/net/wireless/marvell/libertas/types.h index cd4ceb6f885d..398e3272e85f 100644 --- a/drivers/net/wireless/marvell/libertas/types.h +++ b/drivers/net/wireless/marvell/libertas/types.h @@ -105,7 +105,7 @@ struct mrvl_ie_header { struct mrvl_ie_data { struct mrvl_ie_header header; - u8 Data[1]; + u8 data[1]; } __packed; struct mrvl_ie_rates_param_set {
This struct is currently unused, but it will be used in future patches. Fix the code style to not use camel case. Signed-off-by: Doug Brown <doug@schmorgal.com> --- drivers/net/wireless/marvell/libertas/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)