| Message ID | 20230113083115.2590-2-nylon.chen@sifive.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Change PWM-controlled LED pin active mode and algorithm | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/patch_count | success | Link |
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 13 and now 13 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | fail | Errors and warnings before: 0 this patch: 2054 |
| conchuod/alphanumeric_selects | success | Out of order selects before the patch: 57 and now 57 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 4 this patch: 4 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
Hey Nylon, On Fri, Jan 13, 2023 at 04:31:14PM +0800, Nylon Chen wrote: > This removes the active-low properties of the PWM-controlled LEDs in > the HiFive Unmatched device tree. Does unleashed also have the same issue? It has the same compatible at the very least. Thanks, Conor. > > Signed-off-by: Nylon Chen <nylon.chen@sifive.com> > Reviewed-by: Vincent Chen <vincent.chen@sifive.com> > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 07387f9c135c..11f08a545ee6 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -52,7 +52,6 @@ led-controller-1 { > > led-d12 { > pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > - active-low; > color = <LED_COLOR_ID_GREEN>; > max-brightness = <255>; > label = "d12"; > @@ -69,19 +68,16 @@ multi-led { > > led-red { > pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > - active-low; > color = <LED_COLOR_ID_RED>; > }; > > led-green { > pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > - active-low; > color = <LED_COLOR_ID_GREEN>; > }; > > led-blue { > pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > - active-low; > color = <LED_COLOR_ID_BLUE>; > }; > }; > -- > 2.36.1 >
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..11f08a545ee6 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -52,7 +52,6 @@ led-controller-1 { led-d12 { pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d12"; @@ -69,19 +68,16 @@ multi-led { led-red { pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_RED>; }; led-green { pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; }; led-blue { pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_BLUE>; }; };