| Message ID | 20230119173559.2517103-1-dmatlack@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: Add a common API for range-based TLB invalidation | expand |
On Thu, Jan 19, 2023, David Matlack wrote: > This series introduces a common API for performing range-based TLB > invalidation. This is then used to supplant > kvm_arch_flush_remote_tlbs_memslot() and pave the way for two other > patch series: > > 1. https://lore.kernel.org/kvm/20230109215347.3119271-1-rananta@google.com/ > > Adds ARM support for range-based TLB invalidation and needs a > mechanism to invoke it from common code. This series provides such a > mechanism via kvm_arch_flush_remote_tlbs_range(). > > 2. https://lore.kernel.org/kvm/20221208193857.4090582-1-dmatlack@google.com/ > > Refactors the TDP MMU into common code, which requires an API for > range-based TLB invaliation. > > This series is based on patches 29-33 from (2.), but I made some further > cleanups after looking at it a second time. > > Tested on x86_64 and ARM64 using KVM selftests. Did a quick read through, didn't see anything I disagree with. Is there any urgency to getting this merged? If not, due to the dependencies with x86 stuff queued for 6.3, and because of the cross-architecture changes, it might be easiest to plan on landing this in 6.4. That would allow Paolo to create an immutable topic branch fairly early on.
On Wed, Jan 25, 2023 at 12:46:59AM +0000, Sean Christopherson wrote: > On Thu, Jan 19, 2023, David Matlack wrote: > > This series introduces a common API for performing range-based TLB > > invalidation. This is then used to supplant > > kvm_arch_flush_remote_tlbs_memslot() and pave the way for two other > > patch series: > > > > 1. https://lore.kernel.org/kvm/20230109215347.3119271-1-rananta@google.com/ > > > > Adds ARM support for range-based TLB invalidation and needs a > > mechanism to invoke it from common code. This series provides such a > > mechanism via kvm_arch_flush_remote_tlbs_range(). > > > > 2. https://lore.kernel.org/kvm/20221208193857.4090582-1-dmatlack@google.com/ > > > > Refactors the TDP MMU into common code, which requires an API for > > range-based TLB invaliation. > > > > This series is based on patches 29-33 from (2.), but I made some further > > cleanups after looking at it a second time. > > > > Tested on x86_64 and ARM64 using KVM selftests. > > Did a quick read through, didn't see anything I disagree with. LGTM for the tiny amount of arm64 changes, though I imagine David will do a v2 to completely get rid of the affected Kconfig. > Is there any urgency to getting this merged? If not, due to the dependencies > with x86 stuff queued for 6.3, and because of the cross-architecture changes, it > might be easiest to plan on landing this in 6.4. That would allow Paolo to create > an immutable topic branch fairly early on. +1, that buys us some time to go through the rounds on the arm64 side such that we could possibly stack the TLBIRANGE work on top. -- Thanks, Oliver
On Tue, Jan 24, 2023 at 4:51 PM Oliver Upton <oliver.upton@linux.dev> wrote: > On Wed, Jan 25, 2023 at 12:46:59AM +0000, Sean Christopherson wrote: > > On Thu, Jan 19, 2023, David Matlack wrote: > > > > Did a quick read through, didn't see anything I disagree with. > > LGTM for the tiny amount of arm64 changes, though I imagine David will > do a v2 to completely get rid of the affected Kconfig. Thanks both for taking a look. > > Is there any urgency to getting this merged? If not, due to the dependencies > > with x86 stuff queued for 6.3, and because of the cross-architecture changes, it > > might be easiest to plan on landing this in 6.4. That would allow Paolo to create > > an immutable topic branch fairly early on. > > +1, that buys us some time to go through the rounds on the arm64 side > such that we could possibly stack the TLBIRANGE work on top. The main benefit of merging in 6.3 would be to make Raghavendra's life simpler/easier so he can build the next version of his arm64 TLBI series on top. But I guess he can still do that with a topic branch. I'll go ahead and send a v2 on top of the changes from Hou you queued for 6.3, Sean, and we can plan on landing that in 6.4 (barring any further feedback or conflicts).
This series introduces a common API for performing range-based TLB invalidation. This is then used to supplant kvm_arch_flush_remote_tlbs_memslot() and pave the way for two other patch series: 1. https://lore.kernel.org/kvm/20230109215347.3119271-1-rananta@google.com/ Adds ARM support for range-based TLB invalidation and needs a mechanism to invoke it from common code. This series provides such a mechanism via kvm_arch_flush_remote_tlbs_range(). 2. https://lore.kernel.org/kvm/20221208193857.4090582-1-dmatlack@google.com/ Refactors the TDP MMU into common code, which requires an API for range-based TLB invaliation. This series is based on patches 29-33 from (2.), but I made some further cleanups after looking at it a second time. Tested on x86_64 and ARM64 using KVM selftests. Cc: Raghavendra Rao Ananta <rananta@google.com> David Matlack (7): KVM: Rename kvm_arch_flush_remote_tlb() to kvm_arch_flush_remote_tlbs() KVM: arm64: Use kvm_arch_flush_remote_tlbs() KVM: x86/mmu: Collapse kvm_flush_remote_tlbs_with_{range,address}() together KVM: x86/mmu: Rename kvm_flush_remote_tlbs_with_address() KVM: x86/MMU: Use gfn_t in kvm_flush_remote_tlbs_range() KVM: Allow range-based TLB invalidation from common code KVM: Move kvm_arch_flush_remote_tlbs_memslot() to common code arch/arm64/include/asm/kvm_host.h | 3 ++ arch/arm64/kvm/Kconfig | 1 - arch/arm64/kvm/arm.c | 6 --- arch/arm64/kvm/mmu.c | 6 +-- arch/mips/include/asm/kvm_host.h | 4 +- arch/mips/kvm/mips.c | 12 ++---- arch/riscv/kvm/mmu.c | 6 --- arch/x86/include/asm/kvm_host.h | 7 +++- arch/x86/kvm/mmu/mmu.c | 68 ++++++++++--------------------- arch/x86/kvm/mmu/mmu_internal.h | 2 - arch/x86/kvm/mmu/paging_tmpl.h | 4 +- arch/x86/kvm/mmu/tdp_mmu.c | 7 ++-- arch/x86/kvm/x86.c | 2 +- include/linux/kvm_host.h | 20 ++++++--- virt/kvm/kvm_main.c | 35 +++++++++++++--- 15 files changed, 87 insertions(+), 96 deletions(-) base-commit: de60733246ff4545a0483140c1f21426b8d7cb7f prerequisite-patch-id: 42a76ce7cec240776c21f674e99e893a3a6bee58 prerequisite-patch-id: c5ef6bbef252706b7e65b76dc9bd92cf320828f5 prerequisite-patch-id: c6e662cb6c369a47a027c25d3ccc7138a19b17f5 prerequisite-patch-id: 15a58bec64bf1537e6c9e2f52179fac652d441f7 prerequisite-patch-id: d5b6fea4724f4f2c3408b95d7ce5acdd4b528b10