| Message ID | 20230116193502.66540-1-yanjun.zhu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/irdma: Refactor irdma_reg_user_mr function | expand |
在 2023/1/17 3:34, Zhu Yanjun 写道: > V2->V3: 1) Use netdev reverse Christmas tree rule; > 2) Return 0 instead of err; > 3) Remove unnecessary brackets; > 4) Add an error label in error handler; > 5) Initialize the structured variables; Hi, Leon Follow your advice, I made this patches. Please check it. Zhu Yanjun > > V1->V2: Thanks Saleem, Shiraz. > 1) Remove the unnecessary variable initializations; > 2) Get iwdev by to_iwdev; > 3) Use the label free_pble to handle errors; > 4) Validate the page size before rdma_umem_for_each_dma_block > > Split the shared source codes into several new functions for future use. > No bug fix and new feature in this commit series. > > The new functions are as below: > > irdma_reg_user_mr_type_mem > irdma_alloc_iwmr > irdma_free_iwmr > irdma_reg_user_mr_type_qp > irdma_reg_user_mr_type_cq > > These functions will be used in the dmabuf feature. > > Zhu Yanjun (4): > RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem > RDMA/irdma: Split mr alloc and free into new functions > RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp > RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq > > drivers/infiniband/hw/irdma/verbs.c | 270 +++++++++++++++++----------- > 1 file changed, 168 insertions(+), 102 deletions(-) >
On Thu, Jan 26, 2023 at 09:16:05AM +0800, Zhu Yanjun wrote: > 在 2023/1/17 3:34, Zhu Yanjun 写道: > > V2->V3: 1) Use netdev reverse Christmas tree rule; > > 2) Return 0 instead of err; > > 3) Remove unnecessary brackets; > > 4) Add an error label in error handler; > > 5) Initialize the structured variables; > > Hi, Leon > > Follow your advice, I made this patches. > Please check it. Everything is applied, sorry for the delay. Thanks
On Mon, 16 Jan 2023 14:34:58 -0500, Zhu Yanjun wrote: > V2->V3: 1) Use netdev reverse Christmas tree rule; > 2) Return 0 instead of err; > 3) Remove unnecessary brackets; > 4) Add an error label in error handler; > 5) Initialize the structured variables; > > V1->V2: Thanks Saleem, Shiraz. > 1) Remove the unnecessary variable initializations; > 2) Get iwdev by to_iwdev; > 3) Use the label free_pble to handle errors; > 4) Validate the page size before rdma_umem_for_each_dma_block > > [...] Applied, thanks! [1/4] RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem https://git.kernel.org/rdma/rdma/c/01798df19878e8 [2/4] RDMA/irdma: Split mr alloc and free into new functions https://git.kernel.org/rdma/rdma/c/693a5386eff0ba [3/4] RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp https://git.kernel.org/rdma/rdma/c/e965ef0e7b2ce2 [4/4] RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq https://git.kernel.org/rdma/rdma/c/2f25e3bab00e97 Best regards,
在 2023/1/26 18:59, Leon Romanovsky 写道: > On Thu, Jan 26, 2023 at 09:16:05AM +0800, Zhu Yanjun wrote: >> 在 2023/1/17 3:34, Zhu Yanjun 写道: >>> V2->V3: 1) Use netdev reverse Christmas tree rule; >>> 2) Return 0 instead of err; >>> 3) Remove unnecessary brackets; >>> 4) Add an error label in error handler; >>> 5) Initialize the structured variables; >> Hi, Leon >> >> Follow your advice, I made this patches. >> Please check it. > Everything is applied, sorry for the delay. Thanks a lot. Zhu Yanjun > > Thanks
V2->V3: 1) Use netdev reverse Christmas tree rule; 2) Return 0 instead of err; 3) Remove unnecessary brackets; 4) Add an error label in error handler; 5) Initialize the structured variables; V1->V2: Thanks Saleem, Shiraz. 1) Remove the unnecessary variable initializations; 2) Get iwdev by to_iwdev; 3) Use the label free_pble to handle errors; 4) Validate the page size before rdma_umem_for_each_dma_block Split the shared source codes into several new functions for future use. No bug fix and new feature in this commit series. The new functions are as below: irdma_reg_user_mr_type_mem irdma_alloc_iwmr irdma_free_iwmr irdma_reg_user_mr_type_qp irdma_reg_user_mr_type_cq These functions will be used in the dmabuf feature. Zhu Yanjun (4): RDMA/irdma: Split MEM handler into irdma_reg_user_mr_type_mem RDMA/irdma: Split mr alloc and free into new functions RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp RDMA/irdma: Split CQ handler into irdma_reg_user_mr_type_cq drivers/infiniband/hw/irdma/verbs.c | 270 +++++++++++++++++----------- 1 file changed, 168 insertions(+), 102 deletions(-)