[v3,0/6] Puncturing support in AP mode

Message

Aloka Dixit Jan. 30, 2023, 7:22 a.m. UTC

Add preamble puncturing support in AP mode.
This series is based on top of following:
https://patchwork.kernel.org/project/linux-wireless/patch/20230127123930.4fbc74582331.I3547481d49f958389f59dfeba3fcc75e72b0aa6e@changeid/

And it is next version for:
https://patchwork.kernel.org/project/linux-wireless/list/?series=625836&state=%2A&archive=both

Aloka Dixit (6):
  wifi: nl80211: configure puncturing bitmap in NL80211_CMD_START_AP
  wifi: mac80211: validate and configure puncturing bitmap in start_ap()
  wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH
  wifi: mac80211: configure puncturing bitmap in channel_switch()
  wifi: cfg80211: add puncturing bitmap in channel switch notifications
  wifi: nl80211: add puncturing bitmap in channel switch events

 drivers/net/wireless/ath/ath6kl/cfg80211.c |  2 +-
 drivers/net/wireless/marvell/mwifiex/11h.c |  2 +-
 include/net/cfg80211.h                     | 16 +++++++-
 include/net/mac80211.h                     |  5 ++-
 include/uapi/linux/nl80211.h               | 13 ++++++
 net/mac80211/cfg.c                         | 28 +++++++++++--
 net/mac80211/ieee80211_i.h                 |  2 +
 net/mac80211/mlme.c                        | 14 +++----
 net/wireless/nl80211.c                     | 48 ++++++++++++++++++----
 net/wireless/trace.h                       | 24 +++++++----
 10 files changed, 124 insertions(+), 30 deletions(-)


base-commit: 4ca69027691a0039279b64cfa0aa511d9c9fde59
prerequisite-patch-id: f3e39c8c03c23c977baa8946066285e597b93c7e

Comments

Johannes Berg Jan. 30, 2023, 8:48 a.m. UTC | #1

Thanks!

> Aloka Dixit (6):
>   wifi: nl80211: configure puncturing bitmap in NL80211_CMD_START_AP
>   wifi: mac80211: validate and configure puncturing bitmap in start_ap()
>   wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH
>   wifi: mac80211: configure puncturing bitmap in channel_switch()
>   wifi: cfg80211: add puncturing bitmap in channel switch notifications
>   wifi: nl80211: add puncturing bitmap in channel switch events
> 

I feel like maybe you can/should squash 1 and 3, 2 and 4, and 5 and 6?

1/3 are cfg80211 for config, 2/4 are mac80211 for config, and 5/6 are
basically both cfg80211 anyway? Of course 5 updates the users.

And maybe I'd then reorder and put them in this order:

 - new: validation move
 - 1/3
 - 5/6
 - 2/4

so 5/6 just pass 0 from mac80211 to cfg80211_ch_switch_started_notify()
and cfg80211_ch_switch_notify(), and the mac80211 patch (2/4) fills in
the actual values. That way the cfg80211 patch is 'pure' API, no
functionality changes.

What do you think?

johannes

Aloka Dixit Jan. 30, 2023, 7:44 p.m. UTC | #2

On 1/30/2023 12:48 AM, Johannes Berg wrote:
> Thanks!
> 
>> Aloka Dixit (6):
>>    wifi: nl80211: configure puncturing bitmap in NL80211_CMD_START_AP
>>    wifi: mac80211: validate and configure puncturing bitmap in start_ap()
>>    wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH
>>    wifi: mac80211: configure puncturing bitmap in channel_switch()
>>    wifi: cfg80211: add puncturing bitmap in channel switch notifications
>>    wifi: nl80211: add puncturing bitmap in channel switch events
>>
> 
> I feel like maybe you can/should squash 1 and 3, 2 and 4, and 5 and 6?
> 
> 1/3 are cfg80211 for config, 2/4 are mac80211 for config, and 5/6 are
> basically both cfg80211 anyway? Of course 5 updates the users.
> 
> And maybe I'd then reorder and put them in this order:
> 
>   - new: validation move
>   - 1/3
>   - 5/6
>   - 2/4
> 
> so 5/6 just pass 0 from mac80211 to cfg80211_ch_switch_started_notify()
> and cfg80211_ch_switch_notify(), and the mac80211 patch (2/4) fills in
> the actual values. That way the cfg80211 patch is 'pure' API, no
> functionality changes.
> 
> What do you think?
> 
> johannes

I added separate patches for channel switch because it kept the patches 
small. No worries, will combine those.

Thanks.