| Message ID | 20230127194057.186458-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: phy/samsung: move MIPI and DP phys under PMU | expand |
On Fri, 27 Jan 2023 20:40:51 +0100, Krzysztof Kozlowski wrote: > The DisplayPort phy is actually part of the Power Management Unit system > controller, thus it should be its child, instead of sibling node with > syscon phandle. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/phy/samsung,dp-video-phy.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 27/01/2023 20:40, Krzysztof Kozlowski wrote: > The DisplayPort phy is actually part of the Power Management Unit system > controller, thus it should be its child, instead of sibling node with > syscon phandle. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/phy/samsung,dp-video-phy.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Hi Vinod, It turns out, my previous patch (1/8, which I took via Samsung SoC) actually depends on these here. Without these here it causes warning. That 1/8 patch is already in soc tree and will be for v6.3. Will you be taking these for v6.3? If not, could you Ack and I will take them. Best regards, Krzysztof
On 27-01-23, 20:40, Krzysztof Kozlowski wrote: > The DisplayPort phy is actually part of the Power Management Unit system > controller, thus it should be its child, instead of sibling node with > syscon phandle. Acked-By: Vinod Koul <vkoul@kernel.org>
On Fri, 27 Jan 2023 20:40:51 +0100, Krzysztof Kozlowski wrote: > The DisplayPort phy is actually part of the Power Management Unit system > controller, thus it should be its child, instead of sibling node with > syscon phandle. > > Applied, thanks! [2/8] dt-bindings: phy: samsung,dp-video-phy: deprecate syscon phandle https://git.kernel.org/krzk/linux/c/0092b7ab96e77e6e315d0f5d3965608da32b3843 Best regards,
diff --git a/Documentation/devicetree/bindings/phy/samsung,dp-video-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,dp-video-phy.yaml index b03b2f00cc5b..3bee3f8733f7 100644 --- a/Documentation/devicetree/bindings/phy/samsung,dp-video-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,dp-video-phy.yaml @@ -22,13 +22,13 @@ properties: samsung,pmu-syscon: $ref: /schemas/types.yaml#/definitions/phandle + deprecated: true description: - Phandle to PMU system controller interface. + Phandle to PMU system controller interface (if not a child of PMU). required: - compatible - "#phy-cells" - - samsung,pmu-syscon additionalProperties: false @@ -36,6 +36,5 @@ examples: - | phy { compatible = "samsung,exynos5420-dp-video-phy"; - samsung,pmu-syscon = <&pmu_system_controller>; #phy-cells = <0>; };
The DisplayPort phy is actually part of the Power Management Unit system controller, thus it should be its child, instead of sibling node with syscon phandle. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/phy/samsung,dp-video-phy.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)