| Message ID | 20230206184744.6.Ic234b931025d1f920ce9e06fff294643943a65ad@changeid (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm: qcom: Fix touchscreen voltage for sc7280-herobrine boards | expand |
On Mon, Feb 06, 2023 at 06:48:15PM -0800, Douglas Anderson wrote: > As talked about in the patch ("dt-bindings: HID: i2c-hid: goodix: Add > mainboard-vddio-supply") we may need to power up a 1.8V rail on the > host associated with touchscreen IO. Let's add support in the driver > for it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > Unfortunately, I haven't been able to actually test this on real > hardware yet. However, the change is very simple, I believe it is > correct, and it doesn't break other boards I've tested it on. > > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c > index 584d833dc0aa..0060e3dcd775 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c > +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c > @@ -26,6 +26,7 @@ struct i2c_hid_of_goodix { > struct i2chid_ops ops; > > struct regulator *vdd; > + struct regulator *vddio; > struct gpio_desc *reset_gpio; > const struct goodix_i2c_hid_timing_data *timings; > }; > @@ -40,6 +41,10 @@ static int goodix_i2c_hid_power_up(struct i2chid_ops *ops) > if (ret) > return ret; > > + ret = regulator_enable(ihid_goodix->vddio); > + if (ret) > + return ret; > + > if (ihid_goodix->timings->post_power_delay_ms) > msleep(ihid_goodix->timings->post_power_delay_ms); > > @@ -56,6 +61,7 @@ static void goodix_i2c_hid_power_down(struct i2chid_ops *ops) > container_of(ops, struct i2c_hid_of_goodix, ops); > > gpiod_set_value_cansleep(ihid_goodix->reset_gpio, 1); > + regulator_disable(ihid_goodix->vddio); > regulator_disable(ihid_goodix->vdd); > } > > @@ -81,6 +87,10 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client) > if (IS_ERR(ihid_goodix->vdd)) > return PTR_ERR(ihid_goodix->vdd); > > + ihid_goodix->vddio = devm_regulator_get(&client->dev, "mainboard-vddio"); > + if (IS_ERR(ihid_goodix->vddio)) > + return PTR_ERR(ihid_goodix->vddio); > + > ihid_goodix->timings = device_get_match_data(&client->dev); > > return i2c_hid_core_probe(client, &ihid_goodix->ops, 0x0001, 0); > -- > 2.39.1.519.gcb327c4b5f-goog >
On Mon, Feb 06, 2023 at 06:48:15PM -0800, Douglas Anderson wrote: > As talked about in the patch ("dt-bindings: HID: i2c-hid: goodix: Add > mainboard-vddio-supply") we may need to power up a 1.8V rail on the > host associated with touchscreen IO. Let's add support in the driver > for it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c index 584d833dc0aa..0060e3dcd775 100644 --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c @@ -26,6 +26,7 @@ struct i2c_hid_of_goodix { struct i2chid_ops ops; struct regulator *vdd; + struct regulator *vddio; struct gpio_desc *reset_gpio; const struct goodix_i2c_hid_timing_data *timings; }; @@ -40,6 +41,10 @@ static int goodix_i2c_hid_power_up(struct i2chid_ops *ops) if (ret) return ret; + ret = regulator_enable(ihid_goodix->vddio); + if (ret) + return ret; + if (ihid_goodix->timings->post_power_delay_ms) msleep(ihid_goodix->timings->post_power_delay_ms); @@ -56,6 +61,7 @@ static void goodix_i2c_hid_power_down(struct i2chid_ops *ops) container_of(ops, struct i2c_hid_of_goodix, ops); gpiod_set_value_cansleep(ihid_goodix->reset_gpio, 1); + regulator_disable(ihid_goodix->vddio); regulator_disable(ihid_goodix->vdd); } @@ -81,6 +87,10 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client) if (IS_ERR(ihid_goodix->vdd)) return PTR_ERR(ihid_goodix->vdd); + ihid_goodix->vddio = devm_regulator_get(&client->dev, "mainboard-vddio"); + if (IS_ERR(ihid_goodix->vddio)) + return PTR_ERR(ihid_goodix->vddio); + ihid_goodix->timings = device_get_match_data(&client->dev); return i2c_hid_core_probe(client, &ihid_goodix->ops, 0x0001, 0);
As talked about in the patch ("dt-bindings: HID: i2c-hid: goodix: Add mainboard-vddio-supply") we may need to power up a 1.8V rail on the host associated with touchscreen IO. Let's add support in the driver for it. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Unfortunately, I haven't been able to actually test this on real hardware yet. However, the change is very simple, I believe it is correct, and it doesn't break other boards I've tested it on. drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 10 ++++++++++ 1 file changed, 10 insertions(+)