Message ID | 20230209151050.233973-1-Frank.Li@nxp.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Krzysztof WilczyĆski |
Headers | show |
Series | [v3,1/1] PCI: layerscape: Add EP mode support for ls1028a | expand |
LGTM, Thanks, Alok On 2/9/2023 8:40 PM, Frank Li wrote: > From: Xiaowei Bao <xiaowei.bao@nxp.com> > > Add PCIe EP mode support for ls1028a. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Signed-off-by: Frank Li <Frank.Li@nxp> > Acked-by: Roy Zang <Roy.Zang@nxp.com> > --- > > Change from v2 to v3 > order by .compatible > > Change from v2 to v2 > Added > Signed-off-by: Frank Li <Frank.Li@nxp> > Acked-by: Roy Zang <Roy.Zang@nxp.com> > > > All other patches were already accepte by maintainer in > https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/__;!!ACWV5N9M2RV99hQ!NR9EU4fPDwxdyrb9tdBm9VNIMHSlw6dLgXCAPDSrm7ftWVNrh6JldLGzzrKyiE0xRlP5OdiGBN7PCf9gRaA$ > > But missed this one. > > Re-post > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index ad99707b3b99..c640db60edc6 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = { > }; > > static const struct of_device_id ls_pcie_ep_of_match[] = { > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata }, > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata }, > { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
On Fri, Feb 10, 2023 at 11:51:46PM +0530, ALOK TIWARI wrote: > LGTM, Thanks a lot for looking at this! In the Linux world, "LGTM" is not something a maintainer can really act on. If you respond with a "Reviewed-by" tag as described here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.1#n495 maintainers (or tooling like b4) can add it to the patch when merging it. Here are some examples of how it can be used: https://lore.kernel.org/linux-pci/BN9PR11MB527699243353309A1DDFEFBE8CDE9@BN9PR11MB5276.namprd11.prod.outlook.com/ https://lore.kernel.org/linux-pci/Y9AEzVrTB4Sobufr@memverge.com/ https://lore.kernel.org/linux-pci/a20028e6-3318-26ca-117a-26c87c292139@linaro.org/ Bjorn > On 2/9/2023 8:40 PM, Frank Li wrote: > > From: Xiaowei Bao <xiaowei.bao@nxp.com> > > > > Add PCIe EP mode support for ls1028a. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > Signed-off-by: Frank Li <Frank.Li@nxp> > > Acked-by: Roy Zang <Roy.Zang@nxp.com>
Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com> On 2/9/2023 8:40 PM, Frank Li wrote: > From: Xiaowei Bao <xiaowei.bao@nxp.com> > > Add PCIe EP mode support for ls1028a. > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Signed-off-by: Frank Li <Frank.Li@nxp> > Acked-by: Roy Zang <Roy.Zang@nxp.com> > --- > > Change from v2 to v3 > order by .compatible > > Change from v2 to v2 > Added > Signed-off-by: Frank Li <Frank.Li@nxp> > Acked-by: Roy Zang <Roy.Zang@nxp.com> > > > All other patches were already accepte by maintainer in > https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/__;!!ACWV5N9M2RV99hQ!NR9EU4fPDwxdyrb9tdBm9VNIMHSlw6dLgXCAPDSrm7ftWVNrh6JldLGzzrKyiE0xRlP5OdiGBN7PCf9gRaA$ > > But missed this one. > > Re-post > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index ad99707b3b99..c640db60edc6 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = { > }; > > static const struct of_device_id ls_pcie_ep_of_match[] = { > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata }, > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata }, > { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
> > Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com> > > On 2/9/2023 8:40 PM, Frank Li wrote: > > From: Xiaowei Bao <xiaowei.bao@nxp.com> > > > > Add PCIe EP mode support for ls1028a. > > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com> > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > > Signed-off-by: Frank Li <Frank.Li@nxp> > > Acked-by: Roy Zang <Roy.Zang@nxp.com> > > --- Ping! there are no feedback for over 1 month. Just 1 line change. > > > > Change from v2 to v3 > > order by .compatible > > > > Change from v2 to v2 > > Added > > Signed-off-by: Frank Li <Frank.Li@nxp> > > Acked-by: Roy Zang <Roy.Zang@nxp.com> > > > > > > All other patches were already accepte by maintainer in > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furlde > fense.com%2Fv3%2F__https%3A%2F%2Flore.kernel.org%2Flkml%2F2021111 > 2223457.10599-1- > leoyang.li%40nxp.com%2F__%3B!!ACWV5N9M2RV99hQ!NR9EU4fPDwxdyrb > 9tdBm9VNIMHSlw6dLgXCAPDSrm7ftWVNrh6JldLGzzrKyiE0xRlP5OdiGBN7PCf > 9gRaA%24&data=05%7C01%7CFrank.Li%40nxp.com%7C1d32974e205b4a8591 > 9f08db0ba30b9b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6381 > 16567129733840%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL > CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd > ata=hGKffPqpE%2Ft66x71Y47ocGbIuFH7vpjLadlAXbnyBOw%3D&reserved=0 > > > > But missed this one. > > > > Re-post > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c > b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index ad99707b3b99..c640db60edc6 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata > lx2_ep_drvdata = { > > }; > > > > static const struct of_device_id ls_pcie_ep_of_match[] = { > > + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, > > { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata }, > > { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata }, > > { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },
On Thu, 09 Feb 2023 10:10:50 -0500, Frank Li wrote: > Add PCIe EP mode support for ls1028a. > > Applied to controller/layerscape, thanks! [1/1] PCI: layerscape: Add EP mode support for ls1028a https://git.kernel.org/pci/pci/c/be567c6cbc08 Thanks, Lorenzo
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index ad99707b3b99..c640db60edc6 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = { }; static const struct of_device_id ls_pcie_ep_of_match[] = { + { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata }, { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata }, { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata }, { .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },