[v4,02/10] target/riscv: remove RISCV_FEATURE_MISA

Commit Message

Daniel Henrique Barboza Feb. 16, 2023, 1:04 p.m. UTC

It's unused after write_misa() became a regular no-op.

Signed-off-by: Daniel Henrique Barboza <[e-mail]>
---
 target/riscv/cpu.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Bin Meng Feb. 16, 2023, 1:31 p.m. UTC | #1

On Thu, Feb 16, 2023 at 9:07 PM Daniel Henrique Barboza
<[e-mail]> wrote:
>
> It's unused after write_misa() became a regular no-op.
>
> Signed-off-by: Daniel Henrique Barboza <[e-mail]>
> ---
>  target/riscv/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <[e-mail]>

Andrew Jones Feb. 16, 2023, 2:52 p.m. UTC | #2

On Thu, Feb 16, 2023 at 10:04:36AM -0300, Daniel Henrique Barboza wrote:
> It's unused after write_misa() became a regular no-op.
> 
> Signed-off-by: Daniel Henrique Barboza <[e-mail]>
> ---
>  target/riscv/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 7128438d8e..01803a020d 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -89,7 +89,6 @@ enum {
>      RISCV_FEATURE_MMU,
>      RISCV_FEATURE_PMP,
>      RISCV_FEATURE_EPMP,
> -    RISCV_FEATURE_MISA,
>      RISCV_FEATURE_DEBUG
>  };
>  
> -- 
> 2.39.1
>

Probably could squash into the previous patch, but anyway

Reviewed-by: Andrew Jones <[e-mail]>

Thanks,
drew

Daniel Henrique Barboza Feb. 16, 2023, 3:26 p.m. UTC | #3

On 2/16/23 11:52, Andrew Jones wrote:
> On Thu, Feb 16, 2023 at 10:04:36AM -0300, Daniel Henrique Barboza wrote:
>> It's unused after write_misa() became a regular no-op.
>>
>> Signed-off-by: Daniel Henrique Barboza <[e-mail]>
>> ---
>>   target/riscv/cpu.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
>> index 7128438d8e..01803a020d 100644
>> --- a/target/riscv/cpu.h
>> +++ b/target/riscv/cpu.h
>> @@ -89,7 +89,6 @@ enum {
>>       RISCV_FEATURE_MMU,
>>       RISCV_FEATURE_PMP,
>>       RISCV_FEATURE_EPMP,
>> -    RISCV_FEATURE_MISA,
>>       RISCV_FEATURE_DEBUG
>>   };
>>   
>> -- 
>> 2.39.1
>>
> 
> Probably could squash into the previous patch, but anyway

True. Since we have a typo to fix in there I'll squash this in.


Thanks,

Daniel

> 
> Reviewed-by: Andrew Jones <[e-mail]>
> 
> Thanks,
> drew

Patch

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 7128438d8e..01803a020d 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -89,7 +89,6 @@  enum {
     RISCV_FEATURE_MMU,
     RISCV_FEATURE_PMP,
     RISCV_FEATURE_EPMP,
-    RISCV_FEATURE_MISA,
     RISCV_FEATURE_DEBUG
 };