| Message ID | 20230214121333.1837-2-shradha.t@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Refactor Exynos PCIe driver to make it generic | expand |
On 14/02/2023 13:13, Shradha Todi wrote: > The current DT bindings is being used for Exynos5433 SoC only. > In order to extend this binding for all SoCs manufactured by > Samsung using DWC PCIe controller, renaming this file to a more > generic name. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > --- > .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} (93%) > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > similarity index 93% > rename from Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml > index f20ed7e709f7..6cd36d9ccba0 100644 > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml We keep the name rather tied to compatible, not generic. There are no other compatibles here, so I don't think we should rename it. Best regards, Krzysztof
On Thu, Feb 16, 2023 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 14/02/2023 13:13, Shradha Todi wrote: > > The current DT bindings is being used for Exynos5433 SoC only. > > In order to extend this binding for all SoCs manufactured by > > Samsung using DWC PCIe controller, renaming this file to a more > > generic name. > > Thank you for your patch. There is something to discuss/improve. > > > > > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > > --- > > .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > rename Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} (93%) > > > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > similarity index 93% > > rename from Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > index f20ed7e709f7..6cd36d9ccba0 100644 > > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > We keep the name rather tied to compatible, not generic. There are no > other compatibles here, so I don't think we should rename it. I also agree with Krzysztof Kozlowski's opinion. For renaming, we should have strong valid reasons. Best regards, Jingoo Han > > Best regards, > Krzysztof >
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 16 February 2023 16:24 > To: Shradha Todi <shradha.t@samsung.com>; lpieralisi@kernel.org; > kw@linux.com; robh@kernel.org; bhelgaas@google.com; > krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; > jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; > lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; > m.szyprowski@samsung.com; jh80.chung@samsung.co; > pankaj.dubey@samsung.com > Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to > Samsung PCIe > > On 14/02/2023 13:13, Shradha Todi wrote: > > The current DT bindings is being used for Exynos5433 SoC only. > > In order to extend this binding for all SoCs manufactured by Samsung > > using DWC PCIe controller, renaming this file to a more generic name. > > Thank you for your patch. There is something to discuss/improve. > > > > > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > > --- > > .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) rename > > Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => > > samsung,pcie.yaml} (93%) > > > > diff --git > > a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > similarity index 93% > > rename from > > Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > index f20ed7e709f7..6cd36d9ccba0 100644 > > --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > We keep the name rather tied to compatible, not generic. There are no other > compatibles here, so I don't think we should rename it. > Our intention to rename was to have a common name for Samsung manufactured SoCs having PCIe controller. Though this change may not be a blocker for us but we feel it will be good to have a common name as this file will not have bindings only for Exynos series of SoC (Samsung Sys. LSI designed) but also custom ASICs such as FSD / ARTPEC SoC (Samsung Foundry designed). We hope we are not breaking any ABI as such in this patch. Shradha > Best regards, > Krzysztof
On 02/03/2023 13:54, Shradha Todi wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 16 February 2023 16:24 >> To: Shradha Todi <shradha.t@samsung.com>; lpieralisi@kernel.org; >> kw@linux.com; robh@kernel.org; bhelgaas@google.com; >> krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; >> jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; >> lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; >> m.szyprowski@samsung.com; jh80.chung@samsung.co; >> pankaj.dubey@samsung.com >> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH 01/16] dt-bindings: PCI: Rename Exynos PCIe binding to >> Samsung PCIe >> >> On 14/02/2023 13:13, Shradha Todi wrote: >>> The current DT bindings is being used for Exynos5433 SoC only. >>> In order to extend this binding for all SoCs manufactured by Samsung >>> using DWC PCIe controller, renaming this file to a more generic name. >> >> Thank you for your patch. There is something to discuss/improve. >> >>> >>> Signed-off-by: Shradha Todi <shradha.t@samsung.com> >>> --- >>> .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) rename >>> Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => >>> samsung,pcie.yaml} (93%) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml >>> similarity index 93% >>> rename from >>> Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml >>> index f20ed7e709f7..6cd36d9ccba0 100644 >>> --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml >>> +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml >> >> We keep the name rather tied to compatible, not generic. There are no other >> compatibles here, so I don't think we should rename it. >> > > Our intention to rename was to have a common name for Samsung manufactured SoCs having PCIe controller. > Though this change may not be a blocker for us but we feel it will be good to have a common name as this file will > not have bindings only for Exynos series of SoC (Samsung Sys. LSI designed) but also custom ASICs such as FSD / ARTPEC SoC (Samsung Foundry designed). > We hope we are not breaking any ABI as such in this patch. There is no FSD/Artpec added here, so renaming just for "rename" is a no. If you add new hardware here, this could have sense, depending on the hardware. But since we pretty often expect the first compatible to be the name of the file, why renaming at all? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml similarity index 93% rename from Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml rename to Documentation/devicetree/bindings/pci/samsung,pcie.yaml index f20ed7e709f7..6cd36d9ccba0 100644 --- a/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml @@ -1,17 +1,17 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/pci/samsung,exynos-pcie.yaml# +$id: http://devicetree.org/schemas/pci/samsung,pcie.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Samsung SoC series PCIe Host Controller +title: Samsung SoC series PCIe Controller maintainers: - Marek Szyprowski <m.szyprowski@samsung.com> - Jaehoon Chung <jh80.chung@samsung.com> description: |+ - Exynos5433 SoC PCIe host controller is based on the Synopsys DesignWare + Samsung SoC PCIe controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in snps,dw-pcie.yaml.
The current DT bindings is being used for Exynos5433 SoC only. In order to extend this binding for all SoCs manufactured by Samsung using DWC PCIe controller, renaming this file to a more generic name. Signed-off-by: Shradha Todi <shradha.t@samsung.com> --- .../pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} (93%)