| Message ID | 20221226123630.6515-5-pali@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Resend LED patches | expand |
On Mon, 26 Dec 2022, Pali Rohár wrote: > Add device-tree bindings documentation for Turris 1.x RGB LEDs. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml Needs a DT Ack (now Cc:ed) > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > new file mode 100644 > index 000000000000..bcaab5b03128 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/cznic,turris1x-leds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: CZ.NIC's Turris 1.x LEDs driver > + > +maintainers: > + - Pali Rohár <pali@kernel.org> > + > +description: > + This module adds support for the RGB LEDs found on the front panel of the > + Turris 1.x routers. There are 8 RGB LEDs that are controlled by CZ.NIC CPLD > + firmware running on Lattice FPGA. Firmware is open source and available at > + https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v > + > +properties: > + compatible: > + const: cznic,turris1x-leds > + > + reg: > + description: CPLD address range where LED registers are mapped > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-7]$": > + type: object > + $ref: leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + minimum: 0 > + maximum: 7 > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/common.h> > + > + cpld@3,0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x3 0x0 0x00020000>; > + > + led-controller@13 { > + compatible = "cznic,turris1x-leds"; > + reg = <0x13 0x1d>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + multi-led@0 { > + reg = <0x0>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_WAN; > + }; > + > + multi-led@1 { > + reg = <0x1>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_LAN; > + function-enumerator = <5>; > + }; > + > + multi-led@2 { > + reg = <0x2>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_LAN; > + function-enumerator = <4>; > + }; > + > + multi-led@3 { > + reg = <0x3>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_LAN; > + function-enumerator = <3>; > + }; > + > + multi-led@4 { > + reg = <0x4>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_LAN; > + function-enumerator = <2>; > + }; > + > + multi-led@5 { > + reg = <0x5>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_LAN; > + function-enumerator = <1>; > + }; > + > + multi-led@6 { > + reg = <0x6>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_WLAN; > + }; > + > + multi-led@7 { > + reg = <0x7>; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_POWER; > + }; > + }; > + }; > + > +... > -- > 2.20.1 >
On 26/12/2022 13:36, Pali Rohár wrote: > Add device-tree bindings documentation for Turris 1.x RGB LEDs. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) NAK, because: 1. You received comments for this to fix which you ignored: https://lore.kernel.org/all/ebf5029e-83fd-e50d-b7cb-eae1b64f7145@linaro.org/ Implement the feedback you got. 2. You sent it now - without changes, ignoring feedback - not cc'ing DT maintainers. Best regards, Krzysztof
On 27/01/2023 12:16, Lee Jones wrote: > On Mon, 26 Dec 2022, Pali Rohár wrote: > >> Add device-tree bindings documentation for Turris 1.x RGB LEDs. >> >> Signed-off-by: Pali Rohár <pali@kernel.org> >> --- >> .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ >> 1 file changed, 118 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > > Needs a DT Ack (now Cc:ed) Within the same day of posting v2 of this - just after 4 hours, Pali received review and I pointed issue to address. The issue was not addressed, just ignored. Therefore this patch shall not be taken, until the issues are resolved or discussion is finished if there is disagreement about my comments.. Best regards, Krzysztof
On Fri, 24 Feb 2023, Krzysztof Kozlowski wrote: > On 27/01/2023 12:16, Lee Jones wrote: > > On Mon, 26 Dec 2022, Pali Rohár wrote: > > > >> Add device-tree bindings documentation for Turris 1.x RGB LEDs. > >> > >> Signed-off-by: Pali Rohár <pali@kernel.org> > >> --- > >> .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > >> 1 file changed, 118 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > > > > Needs a DT Ack (now Cc:ed) > > Within the same day of posting v2 of this - just after 4 hours, Pali > received review and I pointed issue to address. > > The issue was not addressed, just ignored. > > Therefore this patch shall not be taken, until the issues are resolved > or discussion is finished if there is disagreement about my comments.. Understood. Thanks for the clarification.
On Friday 24 February 2023 09:38:37 Lee Jones wrote: > On Fri, 24 Feb 2023, Krzysztof Kozlowski wrote: > > > On 27/01/2023 12:16, Lee Jones wrote: > > > On Mon, 26 Dec 2022, Pali Rohár wrote: > > > > > >> Add device-tree bindings documentation for Turris 1.x RGB LEDs. > > >> > > >> Signed-off-by: Pali Rohár <pali@kernel.org> > > >> --- > > >> .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > > >> 1 file changed, 118 insertions(+) > > >> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > > > > > > Needs a DT Ack (now Cc:ed) > > > > Within the same day of posting v2 of this - just after 4 hours, Pali > > received review and I pointed issue to address. > > > > The issue was not addressed, just ignored. > > > > Therefore this patch shall not be taken, until the issues are resolved > > or discussion is finished if there is disagreement about my comments.. > > Understood. Thanks for the clarification. Sorry, but this discussion was ignored by the reviewer, not by me. I have replied to all points. In other cases I have sent other emails and result was same. I'm not going to write and send emails or pull requests or other code to people who do not want to read them or think that it is me who is ignoring even it is false information.
On 09/03/2023 21:42, Pali Rohár wrote: > On Friday 24 February 2023 09:38:37 Lee Jones wrote: >> On Fri, 24 Feb 2023, Krzysztof Kozlowski wrote: >> >>> On 27/01/2023 12:16, Lee Jones wrote: >>>> On Mon, 26 Dec 2022, Pali Rohár wrote: >>>> >>>>> Add device-tree bindings documentation for Turris 1.x RGB LEDs. >>>>> >>>>> Signed-off-by: Pali Rohár <pali@kernel.org> >>>>> --- >>>>> .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ >>>>> 1 file changed, 118 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml >>>> >>>> Needs a DT Ack (now Cc:ed) >>> >>> Within the same day of posting v2 of this - just after 4 hours, Pali >>> received review and I pointed issue to address. >>> >>> The issue was not addressed, just ignored. >>> >>> Therefore this patch shall not be taken, until the issues are resolved >>> or discussion is finished if there is disagreement about my comments.. >> >> Understood. Thanks for the clarification. > > Sorry, but this discussion was ignored by the reviewer, not by me. > I have replied to all points. In other cases I have sent other emails > and result was same. > > I'm not going to write and send emails or pull requests or other code to > people who do not want to read them or think that it is me who is > ignoring even it is false information. Why did you trim the reply list from few folks and from me, even though discussion is about review between you and me? You had to do it deliberately, so I wonder why? OK, you claim this is false information. This is the last feedback from me: https://lore.kernel.org/all/ebf5029e-83fd-e50d-b7cb-eae1b64f7145@linaro.org/ Where did you respond to this feedback? Point me to the message which responds to my review comment about messed indentation? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml new file mode 100644 index 000000000000..bcaab5b03128 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml @@ -0,0 +1,118 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/cznic,turris1x-leds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: CZ.NIC's Turris 1.x LEDs driver + +maintainers: + - Pali Rohár <pali@kernel.org> + +description: + This module adds support for the RGB LEDs found on the front panel of the + Turris 1.x routers. There are 8 RGB LEDs that are controlled by CZ.NIC CPLD + firmware running on Lattice FPGA. Firmware is open source and available at + https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v + +properties: + compatible: + const: cznic,turris1x-leds + + reg: + description: CPLD address range where LED registers are mapped + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^multi-led@[0-7]$": + type: object + $ref: leds-class-multicolor.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 7 + + required: + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + cpld@3,0 { + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x3 0x0 0x00020000>; + + led-controller@13 { + compatible = "cznic,turris1x-leds"; + reg = <0x13 0x1d>; + #address-cells = <1>; + #size-cells = <0>; + + multi-led@0 { + reg = <0x0>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_WAN; + }; + + multi-led@1 { + reg = <0x1>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_LAN; + function-enumerator = <5>; + }; + + multi-led@2 { + reg = <0x2>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_LAN; + function-enumerator = <4>; + }; + + multi-led@3 { + reg = <0x3>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_LAN; + function-enumerator = <3>; + }; + + multi-led@4 { + reg = <0x4>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_LAN; + function-enumerator = <2>; + }; + + multi-led@5 { + reg = <0x5>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_LAN; + function-enumerator = <1>; + }; + + multi-led@6 { + reg = <0x6>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_WLAN; + }; + + multi-led@7 { + reg = <0x7>; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_POWER; + }; + }; + }; + +...
Add device-tree bindings documentation for Turris 1.x RGB LEDs. Signed-off-by: Pali Rohár <pali@kernel.org> --- .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml