| Message ID | 20230302123051.12440-1-a39.skl@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc | expand |
On 02/03/2023 14:30, Adam Skladowski wrote: > In order for consumers of RPMCC XO clock to probe successfully > their parent needs to be feed with reference clock to obtain proper rate, > add fixed xo-board clock and supply it to rpmcc to make consumers happy. > Frequency setting is left per board basis just like on other recent trees. > > Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- > arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > index 2d360d05aa5e..e55baafd9efd 100644 > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > @@ -20,6 +20,13 @@ / { > > chosen { }; > > + clocks { > + xo_board: xo-board { > + compatible = "fixed-clock"; > + #clock-cells = <0>; With the clock-frequency moved here: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > + }; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -351,6 +358,8 @@ rpm_requests: rpm-requests { > > rpmcc: clock-controller { > compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; > + clocks = <&xo_board>; > + clock-names = "xo"; > #clock-cells = <1>; > }; >
On 2.03.2023 13:30, Adam Skladowski wrote: > In order for consumers of RPMCC XO clock to probe successfully > their parent needs to be feed with reference clock to obtain proper rate, > add fixed xo-board clock and supply it to rpmcc to make consumers happy. > Frequency setting is left per board basis just like on other recent trees. > > Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- So your commit message suggests that this commit does not actually fix the problem, but lays the groundwork for it.. I'd say squashing these two into a single one would make more sense, as if somebody was bisecting something and landed on this one, there would be little hope in getting a boot if what you said holds. Konrad > arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > index 2d360d05aa5e..e55baafd9efd 100644 > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > @@ -20,6 +20,13 @@ / { > > chosen { }; > > + clocks { > + xo_board: xo-board { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + }; > + }; > + > cpus { > #address-cells = <1>; > #size-cells = <0>; > @@ -351,6 +358,8 @@ rpm_requests: rpm-requests { > > rpmcc: clock-controller { > compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; > + clocks = <&xo_board>; > + clock-names = "xo"; > #clock-cells = <1>; > }; >
On Thu, 2 Mar 2023 13:30:49 +0100, Adam Skladowski wrote: > In order for consumers of RPMCC XO clock to probe successfully > their parent needs to be feed with reference clock to obtain proper rate, > add fixed xo-board clock and supply it to rpmcc to make consumers happy. > Frequency setting is left per board basis just like on other recent trees. > > Applied, thanks! [1/2] arm64: dts: qcom: msm8976: Add and provide xo clk to rpmcc commit: 4a2c9b9e1215c557c17a48e3fabe9b1674c1d608 [2/2] arm64: dts: qcom: msm8956-loire: Provide rate for xo_board clock commit: 4a2c9b9e1215c557c17a48e3fabe9b1674c1d608 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi index 2d360d05aa5e..e55baafd9efd 100644 --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi @@ -20,6 +20,13 @@ / { chosen { }; + clocks { + xo_board: xo-board { + compatible = "fixed-clock"; + #clock-cells = <0>; + }; + }; + cpus { #address-cells = <1>; #size-cells = <0>; @@ -351,6 +358,8 @@ rpm_requests: rpm-requests { rpmcc: clock-controller { compatible = "qcom,rpmcc-msm8976", "qcom,rpmcc"; + clocks = <&xo_board>; + clock-names = "xo"; #clock-cells = <1>; };
In order for consumers of RPMCC XO clock to probe successfully their parent needs to be feed with reference clock to obtain proper rate, add fixed xo-board clock and supply it to rpmcc to make consumers happy. Frequency setting is left per board basis just like on other recent trees. Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs") Signed-off-by: Adam Skladowski <a39.skl@gmail.com> --- arch/arm64/boot/dts/qcom/msm8976.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)