| Message ID | 20230301095218.28457-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F | expand |
Hans de Goede <hdegoede@redhat.com> writes: Hello Hans, > Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book > X90F/L has a portrait 1200x1920 screen used in landscape mode, > add a quirk for this. > > When the quirk for the X91F/L was initially added it was written to > also apply to the X90F/L but this does not work because the Android > version of the Yoga Book uses completely different DMI strings. > Also adjust the X91F/L quirk to reflect that it only applies to > the X91F/L models. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hi, On 3/13/23 16:39, Javier Martinez Canillas wrote: > Hans de Goede <hdegoede@redhat.com> writes: > > Hello Hans, > >> Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book >> X90F/L has a portrait 1200x1920 screen used in landscape mode, >> add a quirk for this. >> >> When the quirk for the X91F/L was initially added it was written to >> also apply to the X90F/L but this does not work because the Android >> version of the Yoga Book uses completely different DMI strings. >> Also adjust the X91F/L quirk to reflect that it only applies to >> the X91F/L models. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- > > Patch looks good to me. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks, I have pushed this to drm-misc-fixes now. Regards, Hans
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 5522d610c5cf..b1a38e6ce2f8 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -328,10 +328,17 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"), }, .driver_data = (void *)&lcd1200x1920_rightside_up, - }, { /* Lenovo Yoga Book X90F / X91F / X91L */ + }, { /* Lenovo Yoga Book X90F / X90L */ .matches = { - /* Non exact match to match all versions */ - DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"), + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"), + }, + .driver_data = (void *)&lcd1200x1920_rightside_up, + }, { /* Lenovo Yoga Book X91F / X91L */ + .matches = { + /* Non exact match to match F + L versions */ + DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X91"), }, .driver_data = (void *)&lcd1200x1920_rightside_up, }, { /* Lenovo Yoga Tablet 2 830F / 830L */
Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was written to also apply to the X90F/L but this does not work because the Android version of the Yoga Book uses completely different DMI strings. Also adjust the X91F/L quirk to reflect that it only applies to the X91F/L models. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) base-commit: 38b2d8efd03d2e56431b611e3523f0158306451d