| Message ID | 20230329-acpi-header-cleanup-v1-3-8dc5cd3c610e@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | Remove acpi.h implicit include of of.h | expand |
On Wed, 2023-03-29 at 16:20 -0500, Rob Herring wrote: > With linux/acpi.h no longer implicitly including of.h, add an explicit > include of of.h to fix the following error: > > net/rfkill/rfkill-gpio.c:181:21: error: implicit declaration of function 'of_match_ptr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > > Signed-off-by: Rob Herring <robh@kernel.org> Sounds good! Acked-by: Johannes Berg <johannes@sipsolutions.net> I'm happy with Rafael taking the entire series, there's nothing here that I expect to conflict, and anyway it'd be trivial. Thanks, johannes
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 786dbfdad772..e9d1b2f2ff0a 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -8,6 +8,7 @@ #include <linux/module.h> #include <linux/mod_devicetable.h> #include <linux/rfkill.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/clk.h> #include <linux/slab.h>
With linux/acpi.h no longer implicitly including of.h, add an explicit include of of.h to fix the following error: net/rfkill/rfkill-gpio.c:181:21: error: implicit declaration of function 'of_match_ptr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] Signed-off-by: Rob Herring <robh@kernel.org> --- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+)