| Message ID | 20221116020700.3907453-1-gilad.itzkovitch@morsemicro.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [v3,1/4] wifi: cfg80211: Add short_beacon_tail/head/period | expand |
On Wed, Nov 16, 2022 at 3:08 PM Gilad Itzkovitch <gilad.itzkovitch@morsemicro.com> wrote: > > From: Kieran Frewen <kieran.frewen@morsemicro.com> > > Support variables to handle short beacon period and adding a > separate tail/head for them. > > Signed-off-by: Kieran Frewen <kieran.frewen@morsemicro.com> > Co-developed-by: Gilad Itzkovitch <gilad.itzkovitch@morsemicro.com> > Signed-off-by: Gilad Itzkovitch <gilad.itzkovitch@morsemicro.com> > --- > include/net/cfg80211.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 11a370e64143..99f28ef2323f 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -1179,8 +1179,13 @@ struct cfg80211_mbssid_elems { > * or %NULL if not changed > * @tail: tail portion of beacon (after TIM IE) > * or %NULL if not changed > + * @short_head: head portion of short beacon or %NULL if not changed > + * @short_tail: short tail portion of beacon (after TIM IE) > + or %NULL if not changed > * @head_len: length of @head > * @tail_len: length of @tail > + * @short_head_len: length of @short_head > + * @short_tail_len: length of @short_tail > * @beacon_ies: extra information element(s) to add into Beacon frames or %NULL > * @beacon_ies_len: length of beacon_ies in octets > * @proberesp_ies: extra information element(s) to add into Probe Response > @@ -1208,6 +1213,7 @@ struct cfg80211_beacon_data { > unsigned int link_id; > > const u8 *head, *tail; > + const u8 *short_head, *short_tail; > const u8 *beacon_ies; > const u8 *proberesp_ies; > const u8 *assocresp_ies; > @@ -1218,6 +1224,7 @@ struct cfg80211_beacon_data { > s8 ftm_responder; > > size_t head_len, tail_len; > + size_t short_head_len, short_tail_len; > size_t beacon_ies_len; > size_t proberesp_ies_len; > size_t assocresp_ies_len; > @@ -1328,7 +1335,7 @@ struct cfg80211_ap_settings { > > struct cfg80211_beacon_data beacon; > > - int beacon_interval, dtim_period; > + int beacon_interval, dtim_period, short_beacon_period; > const u8 *ssid; > size_t ssid_len; > enum nl80211_hidden_ssid hidden_ssid; > > base-commit: 5c111ec204d15d1c7d00428b0afdda62ff118565 > -- > 2.34.1 > Hi Johannes, Just following up from our end to see what the status of this patchset is? We were wondering if there was anything we can add in terms of comments or further clarifications to help progress this. Thanks and kind regards, Kieran
Hi, Hmm. This was on my list forever, and somehow I always went past it. Sorry. > Support variables to handle short beacon period and adding a > separate tail/head for them. > I don't think this really needs to be a separate patch? Should be squashed with the nl80211 one. johannes
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 11a370e64143..99f28ef2323f 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1179,8 +1179,13 @@ struct cfg80211_mbssid_elems { * or %NULL if not changed * @tail: tail portion of beacon (after TIM IE) * or %NULL if not changed + * @short_head: head portion of short beacon or %NULL if not changed + * @short_tail: short tail portion of beacon (after TIM IE) + or %NULL if not changed * @head_len: length of @head * @tail_len: length of @tail + * @short_head_len: length of @short_head + * @short_tail_len: length of @short_tail * @beacon_ies: extra information element(s) to add into Beacon frames or %NULL * @beacon_ies_len: length of beacon_ies in octets * @proberesp_ies: extra information element(s) to add into Probe Response @@ -1208,6 +1213,7 @@ struct cfg80211_beacon_data { unsigned int link_id; const u8 *head, *tail; + const u8 *short_head, *short_tail; const u8 *beacon_ies; const u8 *proberesp_ies; const u8 *assocresp_ies; @@ -1218,6 +1224,7 @@ struct cfg80211_beacon_data { s8 ftm_responder; size_t head_len, tail_len; + size_t short_head_len, short_tail_len; size_t beacon_ies_len; size_t proberesp_ies_len; size_t assocresp_ies_len; @@ -1328,7 +1335,7 @@ struct cfg80211_ap_settings { struct cfg80211_beacon_data beacon; - int beacon_interval, dtim_period; + int beacon_interval, dtim_period, short_beacon_period; const u8 *ssid; size_t ssid_len; enum nl80211_hidden_ssid hidden_ssid;