| Message ID | 20230406082018.70367-1-leobras@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Deduplicating RISCV cmpxchg.h macros | expand |
On Thu, Apr 06, 2023 at 05:20:17AM -0300, Leonardo Bras wrote: > While studying riscv's cmpxchg.h file, I got really interested in > understanding how RISCV asm implemented the different versions of > {cmp,}xchg. > > When I understood the pattern, it made sense for me to remove the > duplications and create macros to make it easier to understand what exactly > changes between the versions: Instruction sufixes & barriers. > > Thanks! > Leo > > Changes since RFCv3: > - Squashed the 6 original patches in 2: one for cmpxchg and one for xchg > https://lore.kernel.org/all/20230404163741.2762165-1-leobras@redhat.com/ > > Changes since RFCv2: > - Fixed macros that depend on having a local variable with a magic name > - Previous cast to (long) is now only applied on 4-bytes cmpxchg > https://lore.kernel.org/all/20230321074249.2221674-1-leobras@redhat.com/ > > Changes since RFCv1: > - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error > https://lore.kernel.org/all/20230318080059.1109286-1-leobras@redhat.com/ > > Leonardo Bras (2): > riscv/cmpxchg: Deduplicate cmpxchg() asm and macros > riscv/cmpxchg: Deduplicate xchg() asm functions > > arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------ > 1 file changed, 67 insertions(+), 252 deletions(-) LGTM. AFAICT, this would need to be rebased, cf. e.g. a8596dda1fbf7e ("arch: rename all internal names __xchg to __arch_xchg") from the tip tree. Andrea
On Thu, 2023-04-06 at 19:19 +0200, Andrea Parri wrote: > On Thu, Apr 06, 2023 at 05:20:17AM -0300, Leonardo Bras wrote: > > While studying riscv's cmpxchg.h file, I got really interested in > > understanding how RISCV asm implemented the different versions of > > {cmp,}xchg. > > > > When I understood the pattern, it made sense for me to remove the > > duplications and create macros to make it easier to understand what exactly > > changes between the versions: Instruction sufixes & barriers. > > > > Thanks! > > Leo > > > > Changes since RFCv3: > > - Squashed the 6 original patches in 2: one for cmpxchg and one for xchg > > https://lore.kernel.org/all/20230404163741.2762165-1-leobras@redhat.com/ > > > > Changes since RFCv2: > > - Fixed macros that depend on having a local variable with a magic name > > - Previous cast to (long) is now only applied on 4-bytes cmpxchg > > https://lore.kernel.org/all/20230321074249.2221674-1-leobras@redhat.com/ > > > > Changes since RFCv1: > > - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error > > https://lore.kernel.org/all/20230318080059.1109286-1-leobras@redhat.com/ > > > > Leonardo Bras (2): > > riscv/cmpxchg: Deduplicate cmpxchg() asm and macros > > riscv/cmpxchg: Deduplicate xchg() asm functions > > > > arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------ > > 1 file changed, 67 insertions(+), 252 deletions(-) > > LGTM. AFAICT, this would need to be rebased, cf. e.g. > > a8596dda1fbf7e ("arch: rename all internal names __xchg to __arch_xchg") > > from the tip tree. > > Andrea Thanks for the heads up! I will update this and re-send! And sorry about the delay :( For some weird reason neither the cover letter, nor your message reached my gmail, and just now looking at lore I could find your message.
> > LGTM. AFAICT, this would need to be rebased, cf. e.g. > > > > a8596dda1fbf7e ("arch: rename all internal names __xchg to __arch_xchg") > > > > from the tip tree. > > > > Andrea > > Thanks for the heads up! > I will update this and re-send! > > > And sorry about the delay :( > For some weird reason neither the cover letter, nor your message reached my > gmail, and just now looking at lore I could find your message. All's well that ends well. ;-) Thanks, Andrea
On Thu, 2023-08-03 at 05:14 +0200, Andrea Parri wrote: > > > LGTM. AFAICT, this would need to be rebased, cf. e.g. > > > > > > a8596dda1fbf7e ("arch: rename all internal names __xchg to __arch_xchg") > > > > > > from the tip tree. > > > > > > Andrea > > > > Thanks for the heads up! > > I will update this and re-send! > > > > > > And sorry about the delay :( > > For some weird reason neither the cover letter, nor your message reached my > > gmail, and just now looking at lore I could find your message. > > All's well that ends well. ;-) Thanks, > > Andrea > Superseded by v2: https://patchwork.kernel.org/project/linux-riscv/list/?series=772422&state=%2A&archive=both Leo
While studying riscv's cmpxchg.h file, I got really interested in understanding how RISCV asm implemented the different versions of {cmp,}xchg. When I understood the pattern, it made sense for me to remove the duplications and create macros to make it easier to understand what exactly changes between the versions: Instruction sufixes & barriers. Thanks! Leo Changes since RFCv3: - Squashed the 6 original patches in 2: one for cmpxchg and one for xchg https://lore.kernel.org/all/20230404163741.2762165-1-leobras@redhat.com/ Changes since RFCv2: - Fixed macros that depend on having a local variable with a magic name - Previous cast to (long) is now only applied on 4-bytes cmpxchg https://lore.kernel.org/all/20230321074249.2221674-1-leobras@redhat.com/ Changes since RFCv1: - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error https://lore.kernel.org/all/20230318080059.1109286-1-leobras@redhat.com/ Leonardo Bras (2): riscv/cmpxchg: Deduplicate cmpxchg() asm and macros riscv/cmpxchg: Deduplicate xchg() asm functions arch/riscv/include/asm/cmpxchg.h | 319 +++++++------------------------ 1 file changed, 67 insertions(+), 252 deletions(-)