| Message ID | 20230320064644.5217-1-manivannan.sadhasivam@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] PCI: qcom: Add async probe support | expand |
On Mon, Mar 20, 2023 at 12:16:44PM +0530, Manivannan Sadhasivam wrote: > Qcom PCIe RC driver waits for the PHY link to be up during the probe. This > consumes several milliseconds during boot. So add async probe support so > that other drivers can load in parallel while this driver waits for the > link to be up. You're not really "adding support" for async probe as much as you are enabling it by default. Perhaps you can clarify that in the commit summary and commit message (e.g. by rephrasing as "prefer async probe"). > Suggested-by: Rob Herring <robh@kernel.org> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > > Changes in v2: > > * Rebased on top of v6.3-rc1 With an updated commit message: Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index a232b04af048..4ca357be88e0 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1862,6 +1862,7 @@ static struct platform_driver qcom_pcie_driver = { > .name = "qcom-pcie", > .suppress_bind_attrs = true, > .of_match_table = qcom_pcie_match, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; > builtin_platform_driver(qcom_pcie_driver); Johan
On Mon, 20 Mar 2023 12:16:44 +0530, Manivannan Sadhasivam wrote: > Qcom PCIe RC driver waits for the PHY link to be up during the probe. This > consumes several milliseconds during boot. So add async probe support so > that other drivers can load in parallel while this driver waits for the > link to be up. > > Applied to controller/qcom, thanks! [1/1] PCI: qcom: Add async probe support https://git.kernel.org/pci/pci/c/2dee743c8b4d Thanks, Lorenzo
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index a232b04af048..4ca357be88e0 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1862,6 +1862,7 @@ static struct platform_driver qcom_pcie_driver = { .name = "qcom-pcie", .suppress_bind_attrs = true, .of_match_table = qcom_pcie_match, + .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, }; builtin_platform_driver(qcom_pcie_driver);
Qcom PCIe RC driver waits for the PHY link to be up during the probe. This consumes several milliseconds during boot. So add async probe support so that other drivers can load in parallel while this driver waits for the link to be up. Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- Changes in v2: * Rebased on top of v6.3-rc1 drivers/pci/controller/dwc/pcie-qcom.c | 1 + 1 file changed, 1 insertion(+)