mbox series

[bpf,V10,0/6] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash

Message ID 168132888942.340624.2449617439220153267.stgit@firesoul (mailing list archive)
Headers show
Series XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash | expand

Message

Jesper Dangaard Brouer April 12, 2023, 7:48 p.m. UTC
Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
but doesn't provide information on the RSS hash type (part of 6.3-rc).

This patchset proposal is to change the function call signature via adding
a pointer value argument for providing the RSS hash type.

Patchset also removes all bpf_printk's from xdp_hw_metadata program
that we expect driver developers to use. Instead counters are introduced
for relaying e.g. skip and fail info.

---

Jesper Dangaard Brouer (6):
      selftests/bpf: xdp_hw_metadata remove bpf_printk and add counters
      xdp: rss hash types representation
      mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
      veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
      mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
      selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg


 drivers/net/ethernet/mellanox/mlx4/en_rx.c    | 22 ++++++-
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |  3 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  | 63 ++++++++++++++++++-
 drivers/net/veth.c                            | 10 ++-
 include/linux/mlx5/device.h                   | 14 ++++-
 include/linux/netdevice.h                     |  3 +-
 include/net/xdp.h                             | 47 ++++++++++++++
 net/core/xdp.c                                | 10 ++-
 .../selftests/bpf/prog_tests/xdp_metadata.c   |  2 +
 .../selftests/bpf/progs/xdp_hw_metadata.c     | 42 +++++++------
 .../selftests/bpf/progs/xdp_metadata.c        |  6 +-
 .../selftests/bpf/progs/xdp_metadata2.c       |  7 ++-
 tools/testing/selftests/bpf/xdp_hw_metadata.c | 10 ++-
 tools/testing/selftests/bpf/xdp_metadata.h    |  4 ++
 14 files changed, 205 insertions(+), 38 deletions(-)

--

Comments

patchwork-bot+netdevbpf@kernel.org April 13, 2023, 8:30 p.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 12 Apr 2023 21:48:30 +0200 you wrote:
> Current API for bpf_xdp_metadata_rx_hash() returns the raw RSS hash value,
> but doesn't provide information on the RSS hash type (part of 6.3-rc).
> 
> This patchset proposal is to change the function call signature via adding
> a pointer value argument for providing the RSS hash type.
> 
> Patchset also removes all bpf_printk's from xdp_hw_metadata program
> that we expect driver developers to use. Instead counters are introduced
> for relaying e.g. skip and fail info.
> 
> [...]

Here is the summary with links:
  - [bpf,V10,1/6] selftests/bpf: xdp_hw_metadata remove bpf_printk and add counters
    https://git.kernel.org/netdev/net/c/e8163b98d96c
  - [bpf,V10,2/6] xdp: rss hash types representation
    https://git.kernel.org/netdev/net/c/0cd917a4a8ac
  - [bpf,V10,3/6] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type
    https://git.kernel.org/netdev/net/c/67f245c2ec0a
  - [bpf,V10,4/6] veth: bpf_xdp_metadata_rx_hash add xdp rss hash type
    https://git.kernel.org/netdev/net/c/96b1a098f3db
  - [bpf,V10,5/6] mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
    https://git.kernel.org/netdev/net/c/9123397aeeb4
  - [bpf,V10,6/6] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg
    https://git.kernel.org/netdev/net/c/0f26b74e7d07

You are awesome, thank you!