| Message ID | 20230420-wound-gizzard-2b2b589d9bea@spud (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] RISC-V: include cpufeature.h in cpufeature.c | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Single patches do not need cover letters |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 310c33dc7a12 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 1 and now 1 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 18 this patch: 18 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 19 this patch: 18 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | CHECK: Consider using #include <linux/cpufeature.h> instead of <asm/cpufeature.h> |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | Fixes tag looks correct |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Thu, Apr 20, 2023 at 11:30 AM Conor Dooley <conor@kernel.org> wrote: > > From: Conor Dooley <conor.dooley@microchip.com> > > Automation complains: > warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static? > > cpufeature.c doesn't actually include the header of the same name, as it > had not previously used anything from it. > The per-cpu variable is declared there, so include it to silence the > complaints. > > Fixes: 62a31d6e38bd ("RISC-V: hwprobe: Support probing of misaligned access performance") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > CC: Evan Green <evan@rivosinc.com> > CC: Palmer Dabbelt <palmer@dabbelt.com> > CC: Paul Walmsley <paul.walmsley@sifive.com> > CC: linux-riscv@lists.infradead.org > --- Thanks Conor! Reviewed-by: Evan Green <evan@rivosinc.com> ps - I'm working on that modprobe fix now, will send something shortly.
On Thu, 20 Apr 2023 19:30:16 +0100, Conor Dooley wrote: > Automation complains: > warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static? > > cpufeature.c doesn't actually include the header of the same name, as it > had not previously used anything from it. > The per-cpu variable is declared there, so include it to silence the > complaints. > > [...] Applied, thanks! [1/1] RISC-V: include cpufeature.h in cpufeature.c https://git.kernel.org/palmer/c/c2d3c8441e3d Best regards,
diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index 52585e088873..00f9f57a8566 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -14,6 +14,7 @@ #include <linux/of.h> #include <asm/alternative.h> #include <asm/cacheflush.h> +#include <asm/cpufeature.h> #include <asm/hwcap.h> #include <asm/patch.h> #include <asm/processor.h>