| Message ID | 20230511071214.18611-2-pranavi.somisetty@amd.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add support for partial store and forward | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD ac9a78681b92 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 14 this patch: 14 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 28 this patch: 28 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | fail | Errors and warnings before: 3 this patch: 6 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 20 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote: > watermark value is the minimum amount of packet data > required to activate the forwarding process. The watermark > implementation and maximum size is dependent on the device > where Cadence MACB/GEM is used. > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> Please send dt-binding patches to the dt-binding maintainers and list. get_maintainer.pl should have told you to do so & without having done so, the bindings will not get tested :/ Thanks, Conor. > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index bef5e0f895be..779bc25cf005 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -109,6 +109,13 @@ properties: > power-domains: > maxItems: 1 > > + rx-watermark: > + maxItems: 1 > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Set watermark value for pbuf_rxcutthru reg and enable > + rx partial store and forward. > + > '#address-cells': > const: 1 > > @@ -166,6 +173,7 @@ examples: > compatible = "cdns,macb"; > reg = <0xfffc4000 0x4000>; > interrupts = <21>; > + rx-watermark = /bits/ 16 <0x44>; > phy-mode = "rmii"; > local-mac-address = [3a 0e 03 04 05 06]; > clock-names = "pclk", "hclk", "tx_clk"; > -- > 2.36.1 >
On 11/05/2023 09:12, Pranavi Somisetty wrote: > watermark value is the minimum amount of packet data > required to activate the forwarding process. The watermark > implementation and maximum size is dependent on the device > where Cadence MACB/GEM is used. > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested. Please resend and include all necessary entries. Best regards, Krzysztof
On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote: > watermark value is the minimum amount of packet data > required to activate the forwarding process. The watermark > implementation and maximum size is dependent on the device > where Cadence MACB/GEM is used. > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index bef5e0f895be..779bc25cf005 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -109,6 +109,13 @@ properties: > power-domains: > maxItems: 1 > > + rx-watermark: > + maxItems: 1 > + $ref: /schemas/types.yaml#/definitions/uint16 > + description: > + Set watermark value for pbuf_rxcutthru reg and enable > + rx partial store and forward. What are the units? Frames, octets, DMA scatter-gather segments, % of maximum? Andrew --- pw-bot: cr
On Thu, May 11, 2023 at 08:25:15AM +0100, Conor Dooley wrote: > On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote: > > watermark value is the minimum amount of packet data > > required to activate the forwarding process. The watermark > > implementation and maximum size is dependent on the device > > where Cadence MACB/GEM is used. > > > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> > > Please send dt-binding patches to the dt-binding maintainers and list. > get_maintainer.pl should have told you to do so & without having done > so, the bindings will not get tested :/ The automation we run for the linux-riscv did actually run against this though, and even dtbs_check complains about this binding: Documentation/devicetree/bindings/net/cdns,macb.yaml: properties:rx-watermark:maxItems: False schema does not allow 1 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# Please test your bindings :/ Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index bef5e0f895be..779bc25cf005 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml @@ -109,6 +109,13 @@ properties: power-domains: maxItems: 1 + rx-watermark: + maxItems: 1 + $ref: /schemas/types.yaml#/definitions/uint16 + description: + Set watermark value for pbuf_rxcutthru reg and enable + rx partial store and forward. + '#address-cells': const: 1 @@ -166,6 +173,7 @@ examples: compatible = "cdns,macb"; reg = <0xfffc4000 0x4000>; interrupts = <21>; + rx-watermark = /bits/ 16 <0x44>; phy-mode = "rmii"; local-mac-address = [3a 0e 03 04 05 06]; clock-names = "pclk", "hclk", "tx_clk";
watermark value is the minimum amount of packet data required to activate the forwarding process. The watermark implementation and maximum size is dependent on the device where Cadence MACB/GEM is used. Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> --- Documentation/devicetree/bindings/net/cdns,macb.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)