mbox series

[net,v2,0/4] Documentation fixes for Mellanox mlx5 devlink info

Message ID 20230510035415.16956-1-bagasdotme@gmail.com (mailing list archive)
Headers show
Series Documentation fixes for Mellanox mlx5 devlink info | expand

Message

Bagas Sanjaya May 10, 2023, 3:54 a.m. UTC
Here are fixes for mlx5 devlink info documentation. The first fixes
htmldocs warnings on the mainline, while the rest is formatting fixes.

Changes since v1 [1]:

  * Pick up Reviewed-by tags from Leon Romanovsky
  * Rebase on current net tree

[1]: https://lore.kernel.org/linux-doc/20230503094248.28931-1-bagasdotme@gmail.com/

Bagas Sanjaya (4):
  Documentation: net/mlx5: Wrap vnic reporter devlink commands in code
    blocks
  Documentation: net/mlx5: Use bullet and definition lists for vnic
    counters description
  Documentation: net/mlx5: Add blank line separator before numbered
    lists
  Documentation: net/mlx5: Wrap notes in admonition blocks

 .../ethernet/mellanox/mlx5/devlink.rst        | 60 ++++++++++++-------
 1 file changed, 37 insertions(+), 23 deletions(-)


base-commit: 582dbb2cc1a0a7427840f5b1e3c65608e511b061

Comments

Bagas Sanjaya May 16, 2023, 1:29 p.m. UTC | #1
On 5/10/23 10:54, Bagas Sanjaya wrote:
> Here are fixes for mlx5 devlink info documentation. The first fixes
> htmldocs warnings on the mainline, while the rest is formatting fixes.
> 
> Changes since v1 [1]:
> 
>   * Pick up Reviewed-by tags from Leon Romanovsky
>   * Rebase on current net tree
> 
> [1]: https://lore.kernel.org/linux-doc/20230503094248.28931-1-bagasdotme@gmail.com/
> 
> Bagas Sanjaya (4):
>   Documentation: net/mlx5: Wrap vnic reporter devlink commands in code
>     blocks
>   Documentation: net/mlx5: Use bullet and definition lists for vnic
>     counters description
>   Documentation: net/mlx5: Add blank line separator before numbered
>     lists
>   Documentation: net/mlx5: Wrap notes in admonition blocks
> 
>  .../ethernet/mellanox/mlx5/devlink.rst        | 60 ++++++++++++-------
>  1 file changed, 37 insertions(+), 23 deletions(-)
> 

Hi jon,

If there is no response from mellanox and/or netdev maintainers,
would you like to review and pick this series up?

Thanks.
Jonathan Corbet May 16, 2023, 6:29 p.m. UTC | #2
Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 5/10/23 10:54, Bagas Sanjaya wrote:
>> Here are fixes for mlx5 devlink info documentation. The first fixes
>> htmldocs warnings on the mainline, while the rest is formatting fixes.
>> 
>> Changes since v1 [1]:
>> 
>>   * Pick up Reviewed-by tags from Leon Romanovsky
>>   * Rebase on current net tree
>> 
>> [1]: https://lore.kernel.org/linux-doc/20230503094248.28931-1-bagasdotme@gmail.com/
>> 
>> Bagas Sanjaya (4):
>>   Documentation: net/mlx5: Wrap vnic reporter devlink commands in code
>>     blocks
>>   Documentation: net/mlx5: Use bullet and definition lists for vnic
>>     counters description
>>   Documentation: net/mlx5: Add blank line separator before numbered
>>     lists
>>   Documentation: net/mlx5: Wrap notes in admonition blocks
>> 
>>  .../ethernet/mellanox/mlx5/devlink.rst        | 60 ++++++++++++-------
>>  1 file changed, 37 insertions(+), 23 deletions(-)
>> 
>
> Hi jon,
>
> If there is no response from mellanox and/or netdev maintainers,
> would you like to review and pick this series up?
>
They seem OK other than the gratuitous use of Fixes tags.  The netdev
maintainers are generally responsive and on top of things, though, and I
don't think there would be any justification for bypassing them here.

Thanks,

jon
Jakub Kicinski May 16, 2023, 10:37 p.m. UTC | #3
On Tue, 16 May 2023 12:29:18 -0600 Jonathan Corbet wrote:
> > If there is no response from mellanox and/or netdev maintainers,
> > would you like to review and pick this series up?
> 
> They seem OK other than the gratuitous use of Fixes tags.  The netdev
> maintainers are generally responsive and on top of things, though, and I
> don't think there would be any justification for bypassing them here.

I'm expecting Saeed to pick them up to the mlx5 tree. Either that 
or tell us to take them in. I think he was out and traveling recently.
Let's give him some time :|