diff mbox series

[2/2] spi: spi-cadence: Add missing kernel doc for clk_rate in cdns_spi

Message ID 20230518093927.711358-2-ckeepax@opensource.cirrus.com (mailing list archive)
State Accepted
Commit b6e4686ca8c3932ed0eee66c016c05c870e44f5d
Headers show
Series [v2,1/2] spi: spi-cadence: Interleave write of TX and read of RX FIFO | expand

Commit Message

Charles Keepax May 18, 2023, 9:39 a.m. UTC
Add the missing kernel documentation to silence the build warning.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---

New since v1 of the series, but might as well fix this build warning
too.

Thanks,
Charles

 drivers/spi/spi-cadence.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown May 22, 2023, 9:52 a.m. UTC | #1
On Thu, May 18, 2023 at 10:39:27AM +0100, Charles Keepax wrote:
> Add the missing kernel documentation to silence the build warning.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> 
> New since v1 of the series, but might as well fix this build warning
> too.

Sending this without the "v2" breaks threading and makes it hard to
handle with tooling, versioning applies to the patch series, not to
individual patches.
Charles Keepax May 22, 2023, 2:21 p.m. UTC | #2
On Mon, May 22, 2023 at 10:52:17AM +0100, Mark Brown wrote:
> On Thu, May 18, 2023 at 10:39:27AM +0100, Charles Keepax wrote:
> > Add the missing kernel documentation to silence the build warning.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > 
> > New since v1 of the series, but might as well fix this build warning
> > too.
> 
> Sending this without the "v2" breaks threading and makes it hard to
> handle with tooling, versioning applies to the patch series, not to
> individual patches.

Apologies do you want me to resend?

Thanks,
Charles
Mark Brown May 22, 2023, 2:26 p.m. UTC | #3
On Mon, May 22, 2023 at 02:21:06PM +0000, Charles Keepax wrote:
> On Mon, May 22, 2023 at 10:52:17AM +0100, Mark Brown wrote:

> > Sending this without the "v2" breaks threading and makes it hard to
> > handle with tooling, versioning applies to the patch series, not to
> > individual patches.

> Apologies do you want me to resend?

Just this patch please, the first patch is still going through CI but I
didn't figure out how to push this into the tooling.
diff mbox series

Patch

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 26e6633693196..de8fe3c5becbb 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -102,6 +102,7 @@ 
  * @regs:		Virtual address of the SPI controller registers
  * @ref_clk:		Pointer to the peripheral clock
  * @pclk:		Pointer to the APB clock
+ * @clk_rate:		Reference clock frequency, taken from @ref_clk
  * @speed_hz:		Current SPI bus clock speed in Hz
  * @txbuf:		Pointer	to the TX buffer
  * @rxbuf:		Pointer to the RX buffer