| Message ID | 20230406190030.968972-4-allenwebb@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Generate modules.builtin.alias from match ids | expand |
On Thu, Apr 06, 2023 at 02:00:22PM -0500, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks compilation for STMPE_SPI after built-in modules can generate > match-id based module aliases. Since this wasn't being used before and > builtin aliases aren't needed in this case, remove it. > > This was not caught earlier because STMPE_SPI can not be built as a > module and MODULE_DEVICE_TABLE is a no-op for built-in modules. > > Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/ > Signed-off-by: Allen Webb <allenwebb@google.com> > --- I'm happy to take patches 1-3 thorugh modules-next, but please try to Cc the driver maintainers on the next iteration of this patch series and let them know these are related to this work and see if you can get their ACKs to go through another tree for this purpose. Luis
On Thu, Apr 06, 2023 at 02:00:22PM -0500, Allen Webb wrote: > A one character difference in the name supplied to MODULE_DEVICE_TABLE > breaks compilation for STMPE_SPI after built-in modules can generate > match-id based module aliases. Since this wasn't being used before and > builtin aliases aren't needed in this case, remove it. > > This was not caught earlier because STMPE_SPI can not be built as a > module and MODULE_DEVICE_TABLE is a no-op for built-in modules. > > Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface") > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/ > Signed-off-by: Allen Webb <allenwebb@google.com> > --- Oh feel free to add Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> on patches 1-3. Luis
diff --git a/drivers/mfd/stmpe-spi.c b/drivers/mfd/stmpe-spi.c index e9cbf33502b3..e9cb6a635472 100644 --- a/drivers/mfd/stmpe-spi.c +++ b/drivers/mfd/stmpe-spi.c @@ -129,7 +129,6 @@ static const struct spi_device_id stmpe_spi_id[] = { { "stmpe2403", STMPE2403 }, { } }; -MODULE_DEVICE_TABLE(spi, stmpe_id); static struct spi_driver stmpe_spi_driver = { .driver = {
A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks compilation for STMPE_SPI after built-in modules can generate match-id based module aliases. Since this wasn't being used before and builtin aliases aren't needed in this case, remove it. This was not caught earlier because STMPE_SPI can not be built as a module and MODULE_DEVICE_TABLE is a no-op for built-in modules. Fixes: e789995d5c61 ("mfd: Add support for STMPE SPI interface") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/lkml/202212171140.NB93eVvI-lkp@intel.com/ Signed-off-by: Allen Webb <allenwebb@google.com> --- drivers/mfd/stmpe-spi.c | 1 - 1 file changed, 1 deletion(-)