| Message ID | 20230528001010.47868-3-guptarud@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express | expand |
On Sat, May 27, 2023 at 08:10:07PM -0400, Rudraksha Gupta wrote: > Adds qcom,usb-hs-phy-msm8960 compatible > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On 28/05/2023 02:10, Rudraksha Gupta wrote: > Adds qcom,usb-hs-phy-msm8960 compatible > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
On Tue May 30, 2023 at 9:22 AM EDT, Krzysztof Kozlowski wrote: > On 28/05/2023 02:10, Rudraksha Gupta wrote: > > Adds qcom,usb-hs-phy-msm8960 compatible > > > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > Best regards, > Krzysztof It seems like "dt-bindings:" is the subject prefix for this file. Would you like me to use another prefix instead?
On Wed, 31 May 2023 at 05:49, Rudraksha Gupta <guptarud@gmail.com> wrote: > > On Tue May 30, 2023 at 9:22 AM EDT, Krzysztof Kozlowski wrote: > > On 28/05/2023 02:10, Rudraksha Gupta wrote: > > > Adds qcom,usb-hs-phy-msm8960 compatible > > > > > > > Please use subject prefixes matching the subsystem. You can get them for > > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > > your patch is touching. > > > > Best regards, > > Krzysztof > > It seems like "dt-bindings:" is the subject prefix for this file. Would > you like me to use another prefix instead? At least it should be "dt-bindings: phy: ". However as this change covers existing file, it probably should be "dt-bindings: phy: qcom,usb-hs-phy: "
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml index aa97478dd016..6309c8e9d0b0 100644 --- a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml @@ -40,6 +40,7 @@ properties: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 - const: qcom,usb-hs-phy
Adds qcom,usb-hs-phy-msm8960 compatible Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 1 + 1 file changed, 1 insertion(+)