| Message ID | 20230611192005.25636-1-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: dwc: Relatively simple fixes and cleanups | expand |
On Sun, Jun 11, 2023 at 10:19:54PM +0300, Serge Semin wrote: > It turns out the recent DW PCIe-related patchset was merged in with > several relatively trivial issues left unsettled (noted by Bjorn and > Manivannan). All of these lefovers have been fixed in this patchset. > Namely the series starts with two bug-fixes. The first one concerns the > improper link-mode initialization in case if the CDM-check is enabled. The > second unfortunate mistake I made in the IP-core version type helper. In > particular instead of testing the IP-core version type the macro function > referred to the just IP-core version which obviously wasn't what I > intended. > > Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning > message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". > Secondly the Baikal-T1 PCIe Host driver is converted to perform the > asynchronous probe type which saved us of about 15% of bootup time if no any > PCIe peripheral device attached to the port. > > Then the patchset contains the Baikal-T1 PCIe driver fix. The > corresponding patch removes the false error message printed during the > controller probe procedure. I accidentally added the unconditional > dev_err_probe() method invocation. It was obviously wrong. > > Then two trivial cleanups are introduced. The first one concerns the > duplicated fast-link-mode flag unsetting. The second one implies > dropping a redundant empty line from the dw_pcie_link_set_max_speed() > function. > > The series continues with a patch inspired by the last @Bjorn note > regarding the generic resources request interface. As @Bjorn correctly > said it would be nice to have the new interface used wider in the DW PCIe > subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti > PCIe driver can be easily converted to using the generic clock names. > That's what is done in the noted patch. > > The patchset is closed with a series of MAINTAINERS-list related patches. > Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to > update the MAINTAINER-list with the new files added in the framework of > that procedure. All the snps,dw-pcie* schemas shall be maintained by the > DW PCIe core driver maintainers. Secondly seeing how long it took for my > patchsets to review and not having any comments from the original driver > maintainers I'd suggest to add myself as the reviewer of the DW PCIe > driver. Thus hopefully the new updates review process will be performed > with much less latencies. For the same reason @Manivannan is added to the > maintainers list of the DW PCIe/eDMA drivers as he already agreed to be > in. > > Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v2: > - Rebase onto the kernel 6.3-rc2. > > Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v3: > - Drop the patch: > [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled > and rebase onto the already submitted by @Yoshihiro fix: > commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") > - Just resend. > > Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v4: > - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: > [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer > [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer > - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: > [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list > [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list > > Link: https://lore.kernel.org/linux-pci/20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v5: > - Rebase onto the kernel 6.4-rc1. > - Just resend. > > Link: https://lore.kernel.org/linux-pci/20230511190902.28896-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v6: > - Remove Vinod and DMA-engine mailing-list from Cc-list since the > DMA-related patches have already been merged in. > - Drop the next patches: > [PATCH RESEND v5 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer > [PATCH RESEND v5 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list > [PATCH RESEND v5 14/14] MAINTAINERS: Add myself as the DW eDMA driver reviewer > since they are in the dmeengine next git-branch already. > - Just resend. > > Link: https://lore.kernel.org/linux-pci/20230531112602.7222-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v7: > - Just resend. I don't know how come v6 was marked as "Not Applicable" in patchwork. I tested it on both "next" and "controller/dwc" branches. Not a glimpse of any merge conflict. If there is some another branch I should have based the series on please tell me which one. Anyway here is v7 just in case if the previous patchset was lost. -Serge(y) > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru> > Cc: linux-pci@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Serge Semin (11): > PCI: dwc: Fix erroneous version type test helper > PCI: dwc: Fix inbound iATU entries out-of-bounds warning message > PCI: bt1: Enable async probe type > PCI: bt1: Fix printing false error message > PCI: dwc: Drop duplicated fast-link-mode flag unsetting > PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() > PCI: visconti: Convert to using generic resources getter > MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas > MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer > MAINTAINERS: Add Manivannan to DW PCIe core maintainers list > MAINTAINERS: Add myself as the DW PCIe core reviewer > > MAINTAINERS | 7 ++-- > drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- > .../pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.c | 2 - > drivers/pci/controller/dwc/pcie-designware.h | 7 +++- > drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- > 6 files changed, 31 insertions(+), 29 deletions(-) > > -- > 2.40.0 > >
On Sun, Jun 11, 2023 at 10:19:54PM +0300, Serge Semin wrote: > It turns out the recent DW PCIe-related patchset was merged in with > several relatively trivial issues left unsettled (noted by Bjorn and > Manivannan). All of these lefovers have been fixed in this patchset. > Namely the series starts with two bug-fixes. The first one concerns the > improper link-mode initialization in case if the CDM-check is enabled. The > second unfortunate mistake I made in the IP-core version type helper. In > particular instead of testing the IP-core version type the macro function > referred to the just IP-core version which obviously wasn't what I > intended. > ... I am unable to do anything with this series. Google's legal team is reviewing this matter under applicable laws and regulations. Bjorn
On Mon, Jun 12, 2023 at 10:41:27AM -0500, Bjorn Helgaas wrote: > On Sun, Jun 11, 2023 at 10:19:54PM +0300, Serge Semin wrote: > > It turns out the recent DW PCIe-related patchset was merged in with > > several relatively trivial issues left unsettled (noted by Bjorn and > > Manivannan). All of these lefovers have been fixed in this patchset. > > Namely the series starts with two bug-fixes. The first one concerns the > > improper link-mode initialization in case if the CDM-check is enabled. The > > second unfortunate mistake I made in the IP-core version type helper. In > > particular instead of testing the IP-core version type the macro function > > referred to the just IP-core version which obviously wasn't what I > > intended. > > ... > > I am unable to do anything with this series. > > Google's legal team is reviewing this matter under applicable laws and > regulations. I don't get it, how come Google gets to decide anything about what to do with this patchset? Even the driver copyright doesn't belong to Google Inc, not to mentioned the GPL v2 license under which the driver is released. Could you clarify since when Google (but not the driver and subsystem maintainers) has been reviewing the patches submitted to the kernel? And how come it is able to block even the subsystem maintainers work? -Serge(y) > > Bjorn
On Mon, Jun 12, 2023 at 07:41:24PM +0300, Serge Semin wrote: > On Mon, Jun 12, 2023 at 10:41:27AM -0500, Bjorn Helgaas wrote: > > On Sun, Jun 11, 2023 at 10:19:54PM +0300, Serge Semin wrote: > > > It turns out the recent DW PCIe-related patchset was merged in with > > > several relatively trivial issues left unsettled (noted by Bjorn and > > > Manivannan). All of these lefovers have been fixed in this patchset. > > > Namely the series starts with two bug-fixes. The first one concerns the > > > improper link-mode initialization in case if the CDM-check is enabled. The > > > second unfortunate mistake I made in the IP-core version type helper. In > > > particular instead of testing the IP-core version type the macro function > > > referred to the just IP-core version which obviously wasn't what I > > > intended. > > > ... > > > I am unable to do anything with this series. > > > > Google's legal team is reviewing this matter under applicable laws and > > regulations. > > I don't get it, how come Google gets to decide anything about what to > do with this patchset? I am employed by Google, and my Linux work is part of my job responsibility, so Google sets some boundaries on my activities. Bjorn
On Mon, Jun 12, 2023 at 12:16:08PM -0500, Bjorn Helgaas wrote: > On Mon, Jun 12, 2023 at 07:41:24PM +0300, Serge Semin wrote: > > On Mon, Jun 12, 2023 at 10:41:27AM -0500, Bjorn Helgaas wrote: > > > On Sun, Jun 11, 2023 at 10:19:54PM +0300, Serge Semin wrote: > > > > It turns out the recent DW PCIe-related patchset was merged in with > > > > several relatively trivial issues left unsettled (noted by Bjorn and > > > > Manivannan). All of these lefovers have been fixed in this patchset. > > > > Namely the series starts with two bug-fixes. The first one concerns the > > > > improper link-mode initialization in case if the CDM-check is enabled. The > > > > second unfortunate mistake I made in the IP-core version type helper. In > > > > particular instead of testing the IP-core version type the macro function > > > > referred to the just IP-core version which obviously wasn't what I > > > > intended. > > > > ... > > > > > I am unable to do anything with this series. > > > > > > Google's legal team is reviewing this matter under applicable laws and > > > regulations. > > > > I don't get it, how come Google gets to decide anything about what to > > do with this patchset? > > I am employed by Google, and my Linux work is part of my job > responsibility, so Google sets some boundaries on my activities. Are you saying that Google can just like that affect the kernel maintaining procedure by forcing their employees to ignore some other developers work? Nice, well done Google in "evolving" the open-source community. What do you suggest for us to do then? There are PCIe host and endpoints drivers maintainers who aren't obligated by the Google regulations: Lorenzo, Krzysztof, Rob. They are still able to merge the series in to the PCI (or their own) repo since you are blocked by your Google employer, right? -Serge(y) > > Bjorn
It turns out the recent DW PCIe-related patchset was merged in with several relatively trivial issues left unsettled (noted by Bjorn and Manivannan). All of these lefovers have been fixed in this patchset. Namely the series starts with two bug-fixes. The first one concerns the improper link-mode initialization in case if the CDM-check is enabled. The second unfortunate mistake I made in the IP-core version type helper. In particular instead of testing the IP-core version type the macro function referred to the just IP-core version which obviously wasn't what I intended. Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". Secondly the Baikal-T1 PCIe Host driver is converted to perform the asynchronous probe type which saved us of about 15% of bootup time if no any PCIe peripheral device attached to the port. Then the patchset contains the Baikal-T1 PCIe driver fix. The corresponding patch removes the false error message printed during the controller probe procedure. I accidentally added the unconditional dev_err_probe() method invocation. It was obviously wrong. Then two trivial cleanups are introduced. The first one concerns the duplicated fast-link-mode flag unsetting. The second one implies dropping a redundant empty line from the dw_pcie_link_set_max_speed() function. The series continues with a patch inspired by the last @Bjorn note regarding the generic resources request interface. As @Bjorn correctly said it would be nice to have the new interface used wider in the DW PCIe subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti PCIe driver can be easily converted to using the generic clock names. That's what is done in the noted patch. The patchset is closed with a series of MAINTAINERS-list related patches. Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to update the MAINTAINER-list with the new files added in the framework of that procedure. All the snps,dw-pcie* schemas shall be maintained by the DW PCIe core driver maintainers. Secondly seeing how long it took for my patchsets to review and not having any comments from the original driver maintainers I'd suggest to add myself as the reviewer of the DW PCIe driver. Thus hopefully the new updates review process will be performed with much less latencies. For the same reason @Manivannan is added to the maintainers list of the DW PCIe/eDMA drivers as he already agreed to be in. Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Rebase onto the kernel 6.3-rc2. Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - Drop the patch: [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled and rebase onto the already submitted by @Yoshihiro fix: commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") - Just resend. Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list Link: https://lore.kernel.org/linux-pci/20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru/ Changelog v5: - Rebase onto the kernel 6.4-rc1. - Just resend. Link: https://lore.kernel.org/linux-pci/20230511190902.28896-1-Sergey.Semin@baikalelectronics.ru/ Changelog v6: - Remove Vinod and DMA-engine mailing-list from Cc-list since the DMA-related patches have already been merged in. - Drop the next patches: [PATCH RESEND v5 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer [PATCH RESEND v5 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list [PATCH RESEND v5 14/14] MAINTAINERS: Add myself as the DW eDMA driver reviewer since they are in the dmeengine next git-branch already. - Just resend. Link: https://lore.kernel.org/linux-pci/20230531112602.7222-1-Sergey.Semin@baikalelectronics.ru/ Changelog v7: - Just resend. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru> Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (11): PCI: dwc: Fix erroneous version type test helper PCI: dwc: Fix inbound iATU entries out-of-bounds warning message PCI: bt1: Enable async probe type PCI: bt1: Fix printing false error message PCI: dwc: Drop duplicated fast-link-mode flag unsetting PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() PCI: visconti: Convert to using generic resources getter MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer MAINTAINERS: Add Manivannan to DW PCIe core maintainers list MAINTAINERS: Add myself as the DW PCIe core reviewer MAINTAINERS | 7 ++-- drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 2 - drivers/pci/controller/dwc/pcie-designware.h | 7 +++- drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- 6 files changed, 31 insertions(+), 29 deletions(-)