| Message ID | 20230612092355.87937-25-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: qcom: sa8775p-ride: enable the first ethernet port | expand |
On 12.06.2023 11:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Enable the internal PHY on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Bjorn, Krzysztof.. I was thinking whether we should even be disabling such hardware by default.. Things that reside on the SoC and have no external dependencies could be left enabled: pros: - less fluff - we'd probably very quickly fix the missing PM calls - possibly less fw_devlink woes if we fail to get rid of references to the disabled component? cons: - boot times - slightly more memory usage Konrad > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index ab767cfa51ff..7754788ea775 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -355,6 +355,10 @@ &qupv3_id_2 { > status = "okay"; > }; > > +&serdes_phy { > + status = "okay"; > +}; > + > &sleep_clk { > clock-frequency = <32764>; > };
On Tue, Jun 13, 2023 at 09:02:23PM +0200, Konrad Dybcio wrote: > > > On 12.06.2023 11:23, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Enable the internal PHY on sa8775p-ride. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > --- > > Bjorn, Krzysztof.. I was thinking whether we should even be disabling > such hardware by default.. > I'm in favor of keeping the configuration as generic/common/simple as possible. So I like your suggestion. Regards, Bjorn > Things that reside on the SoC and have no external dependencies could > be left enabled: > > pros: > - less fluff > - we'd probably very quickly fix the missing PM calls > - possibly less fw_devlink woes if we fail to get rid of references to > the disabled component? > > cons: > - boot times > - slightly more memory usage > > Konrad > > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > > index ab767cfa51ff..7754788ea775 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > > @@ -355,6 +355,10 @@ &qupv3_id_2 { > > status = "okay"; > > }; > > > > +&serdes_phy { > > + status = "okay"; > > +}; > > + > > &sleep_clk { > > clock-frequency = <32764>; > > };
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts index ab767cfa51ff..7754788ea775 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts @@ -355,6 +355,10 @@ &qupv3_id_2 { status = "okay"; }; +&serdes_phy { + status = "okay"; +}; + &sleep_clk { clock-frequency = <32764>; };