| Message ID | 20230622141343.13595-1-ychuang570808@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: nuvoton: Use clk_parent_data instead and add a header file | expand |
On Thu, Jun 22, 2023, at 16:13, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > This set of patches addresses some of the issues that were identified in > the ma35d1 clock driver. > I've gone ahead and applied all three now, on top of the soc/newsoc branch. If any other issues come up, please send patches relative to that. Thanks, Arnd
Hello: This series was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Thu, 22 Jun 2023 14:13:40 +0000 you wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > This set of patches addresses some of the issues that were identified in > the ma35d1 clock driver. > > 1. The external functions referenced between the .c files in this driver > should not be declared within the .c files themselves. Instead, a shared > .h file should be created to reference them. > > [...] Here is the summary with links: - [v3,1/3] clk: nuvoton: Add clk-ma35d1.h for driver extern functions https://git.kernel.org/soc/soc/c/a5e3f37217b7 - [v3,2/3] clk: nuvoton: Update all constant hex values to lowercase https://git.kernel.org/soc/soc/c/ebd617b67543 - [v3,3/3] clk: nuvoton: Use clk_parent_data instead of string for parent clock https://git.kernel.org/soc/soc/c/f50a000b4219 You are awesome, thank you!
From: Jacky Huang <ychuang3@nuvoton.com> This set of patches addresses some of the issues that were identified in the ma35d1 clock driver. 1. The external functions referenced between the .c files in this driver should not be declared within the .c files themselves. Instead, a shared .h file should be created to reference them. 2. Update all constant hex values written in uppercase to be lowercase. 3. For the declaration of parent clocks, use struct clk_parent_data instead of a string. Due to the change in the passed arguments, replace the usage of devm_clk_hw_register_mux() with clk_hw_register_mux_parent_data() for all cases. v3: - Extract the unrelated parts from patch 1/3 and create another patch, patch 2/3. - In patch 3/3, remove the modifications about line reformatting, as they irrelevant and have no practical effect. v2: - In v1, all these modifications were included in a single patch, which is not ideal. In v2, there were no changes made to the patch content itself, but the different modification topics were separated into two individual patches Jacky Huang (3): clk: nuvoton: Add clk-ma35d1.h for driver extern functions clk: nuvoton: Update all constant hex values to lowercase clk: nuvoton: Use clk_parent_data instead of string for parent clock drivers/clk/nuvoton/clk-ma35d1-divider.c | 7 +- drivers/clk/nuvoton/clk-ma35d1-pll.c | 5 +- drivers/clk/nuvoton/clk-ma35d1.c | 348 +++++++++++++++-------- drivers/clk/nuvoton/clk-ma35d1.h | 18 ++ 4 files changed, 259 insertions(+), 119 deletions(-) create mode 100644 drivers/clk/nuvoton/clk-ma35d1.h