diff mbox series

[v1,3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk

Message ID 20230607201641.20982-4-ddrokosov@sberdevices.ru (mailing list archive)
State New, archived
Headers show
Series arm64: dts: meson: a1: introduce several peripheral IPs | expand

Commit Message

Dmitry Rokosov June 7, 2023, 8:16 p.m. UTC 
From: Alexey Romanov <avromanov@sberdevices.ru>

EFUSE A1 controller uses CLKID_OTP clock and PWRC_OTP_ID power domain.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Martin Blumenstingl June 25, 2023, 8:50 p.m. UTC | #1 
On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
[...]
> +       efuse: efuse {
> +               compatible = "amlogic,meson-gxbb-efuse";
> +               clocks = <&clkc_periphs CLKID_OTP>;
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               secure-monitor = <&sm>;
> +               power-domains = <&pwrc PWRC_OTP_ID>;
> +               status = "okay";
If eFuse is always enabled then we can just drop status = "okay" as
that's the default.
Dmitry Rokosov June 28, 2023, 2:20 p.m. UTC | #2 
On Sun, Jun 25, 2023 at 10:50:37PM +0200, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
> [...]
> > +       efuse: efuse {
> > +               compatible = "amlogic,meson-gxbb-efuse";
> > +               clocks = <&clkc_periphs CLKID_OTP>;
> > +               #address-cells = <1>;
> > +               #size-cells = <1>;
> > +               secure-monitor = <&sm>;
> > +               power-domains = <&pwrc PWRC_OTP_ID>;
> > +               status = "okay";
> If eFuse is always enabled then we can just drop status = "okay" as
> that's the default.

Ahh, okay. I wasn't aware of that behavior. Thank you for pointing it
out!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index b2563c7d3842..63faccfc1134 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -44,6 +44,16 @@  l2: l2-cache0 {
 		};
 	};
 
+	efuse: efuse {
+		compatible = "amlogic,meson-gxbb-efuse";
+		clocks = <&clkc_periphs CLKID_OTP>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		secure-monitor = <&sm>;
+		power-domains = <&pwrc PWRC_OTP_ID>;
+		status = "okay";
+	};
+
 	psci {
 		compatible = "arm,psci-1.0";
 		method = "smc";