Message ID | mhng-ebcc1b82-5dd0-4f2d-824e-8d9250374abf@palmer-ri-x1c9 (mailing list archive) |
---|---|
State | Accepted |
Commit | 533925cb760431cb496a8c965cfd765a1a21d37e |
Headers | show |
Series | [GIT,PULL] RISC-V Patches for the 6.5 Merge Window, Part 1 | expand |
Context | Check | Description |
---|---|---|
conchuod/tree_selection | success | Pull request for for-next |
conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
conchuod/build_rv32_defconfig | success | Build OK |
conchuod/dtb_warn_rv64 | success | Errors and warnings before: 20 this patch: 20 |
conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
conchuod/verify_fixes | success | No Fixes tag |
conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Fri, 30 Jun 2023 at 08:40, Palmer Dabbelt <palmer@rivosinc.com> wrote: > > There's one merge conflict in MAINTAINERS Yes, but your suggested resolution is wrong. That "ACPI SERIAL ..." entry was moved downwards to be in the right place alphabetically, so the entry next to your new RISC-V entry actually needs to be removed. You seem to just have kept it, so your resolution caused a dup. The hint from git is the '++' at the beginning of the line: > ++ACPI SERIAL MULTI INSTANTIATE DRIVER > ++M: Hans de Goede <hdegoede@redhat.com> > ++L: platform-driver-x86@vger.kernel.org > ++S: Maintained > ++F: drivers/platform/x86/serial-multi-instantiate.c > ++ which means that git thinks that your merge added those lines from thin air (ie they didn't exist in either parent). NOTE! A '++' line is not a sign of a mis-merge in general. It is *purely* a hint. It happens for perfectly fine merges when you either end up moving lines around enough that git doesn't see where they came from. Or, perhaps more commonly, when the merge conflict was due to both sides changing the same exact same code, and the merge resolution comes from neither one directly, but is new code that has combinations of both changes. Anyway, don't worry about it, I appreciate the heads-up regardless and I always do my own merge resolutions. I just decided to try to use this as a "this is how git works" moment. Basically, trivial merges where things were just added or removed next to each other will normally not result in "++" or "--" lines, so it can be a hint that something went wrong if you *thought* your merge was trivial, but git gives that kind of output for the end result. But don't think that "++" means "wrong". It really is just a sign that maybe the merge resolution needed a lot of care. And sometimes it's entirely a false positive - if git *really* understood merges 100% correctly all the time, we'd never need any manual conflict resolution at all ;) Linus
The pull request you sent on Fri, 30 Jun 2023 08:40:50 -0700 (PDT):
> git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git tags/riscv-for-linus-6.5-mw1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/533925cb760431cb496a8c965cfd765a1a21d37e
Thank you!
On Fri, 30 Jun 2023 09:46:39 PDT (-0700), Linus Torvalds wrote: > On Fri, 30 Jun 2023 at 08:40, Palmer Dabbelt <palmer@rivosinc.com> wrote: >> >> There's one merge conflict in MAINTAINERS > > Yes, but your suggested resolution is wrong. That "ACPI SERIAL ..." > entry was moved downwards to be in the right place alphabetically, so > the entry next to your new RISC-V entry actually needs to be removed. > > You seem to just have kept it, so your resolution caused a dup. Ah, sorry -- I didn't look all that closely because it was just a MAINTAINERS update and I knew you just take these all as hints... > > The hint from git is the '++' at the beginning of the line: > >> ++ACPI SERIAL MULTI INSTANTIATE DRIVER >> ++M: Hans de Goede <hdegoede@redhat.com> >> ++L: platform-driver-x86@vger.kernel.org >> ++S: Maintained >> ++F: drivers/platform/x86/serial-multi-instantiate.c >> ++ > > which means that git thinks that your merge added those lines from > thin air (ie they didn't exist in either parent). > > NOTE! A '++' line is not a sign of a mis-merge in general. It is > *purely* a hint. It happens for perfectly fine merges when you either > end up moving lines around enough that git doesn't see where they came > from. > > Or, perhaps more commonly, when the merge conflict was due to both > sides changing the same exact same code, and the merge resolution > comes from neither one directly, but is new code that has combinations > of both changes. > > Anyway, don't worry about it, I appreciate the heads-up regardless and > I always do my own merge resolutions. I just decided to try to use ... and ya, I figured it was better to just send it anyway. > this as a "this is how git works" moment. Awesome, thanks. I poke around the git merge resolution stuff, but I'm never 100% sure so I usually just look at the resulting output files and then just paste in whatever git says as a heads up ;) > Basically, trivial merges where things were just added or removed next > to each other will normally not result in "++" or "--" lines, so it > can be a hint that something went wrong if you *thought* your merge > was trivial, but git gives that kind of output for the end result. > > But don't think that "++" means "wrong". It really is just a sign that > maybe the merge resolution needed a lot of care. And sometimes it's > entirely a false positive - if git *really* understood merges 100% > correctly all the time, we'd never need any manual conflict resolution > at all ;) OK, I think that makes sense. Hopefully I can remember next time one comes up. > > Linus
On Fri, 30 Jun 2023 at 11:47, Palmer Dabbelt <palmer@rivosinc.com> wrote: > > Awesome, thanks. I poke around the git merge resolution stuff, but I'm > never 100% sure so I usually just look at the resulting output files and > then just paste in whatever git says as a heads up ;) Yup. It's one reason I really prefer to do merges myself - I just have done *so* many of them over the years (and did them long before git made them much easier) that I can usually do them in my sleep. Which obviously doesn't mean I then necessarily always get them right, but I tend to have a higher success rate just because I'm so used to them. Regardless, I like seeing the heads-up for merge conflicts in the pull requests, if for no other reason than the fact that it sets my expectations for what I'm going to see. For example, sometimes it means that I decide I'll just go make a cup of coffee before tackling the merge at all... Not for something this trivial, but you get the idea. Linus
On Fri, 30 Jun 2023 11:54:35 PDT (-0700), Linus Torvalds wrote: > On Fri, 30 Jun 2023 at 11:47, Palmer Dabbelt <palmer@rivosinc.com> wrote: >> >> Awesome, thanks. I poke around the git merge resolution stuff, but I'm >> never 100% sure so I usually just look at the resulting output files and >> then just paste in whatever git says as a heads up ;) > > Yup. It's one reason I really prefer to do merges myself - I just have > done *so* many of them over the years (and did them long before git > made them much easier) that I can usually do them in my sleep. > > Which obviously doesn't mean I then necessarily always get them right, > but I tend to have a higher success rate just because I'm so used to > them. That's great with me, I don't do a lot of merge resolving so it's always a bit of a special thing. > Regardless, I like seeing the heads-up for merge conflicts in the pull > requests, if for no other reason than the fact that it sets my > expectations for what I'm going to see. > > For example, sometimes it means that I decide I'll just go make a cup > of coffee before tackling the merge at all... Not for something this > trivial, but you get the idea. OK, I'll just keep doing things this way and hopefully it stays fine ;) > > Linus
Hello: This pull request was applied to riscv/linux.git (fixes) by Linus Torvalds <torvalds@linux-foundation.org>: On Fri, 30 Jun 2023 08:40:50 -0700 (PDT) you wrote: > The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: > > Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git tags/riscv-for-linus-6.5-mw1 > > [...] Here is the summary with links: - [GIT,PULL] RISC-V Patches for the 6.5 Merge Window, Part 1 https://git.kernel.org/riscv/c/533925cb7604 You are awesome, thank you!
diff --cc MAINTAINERS index 0d6ecb5a4107,e0976ae2a523..cfc2b67e9b4e --- a/MAINTAINERS