diff mbox series

[blktests] zbd/009: skip have_good_mkfs_btrfs when mkfs.btrfs not avaiable

Message ID 20230630120028.2980792-1-yi.zhang@redhat.com (mailing list archive)
State New, archived
Headers show
Series [blktests] zbd/009: skip have_good_mkfs_btrfs when mkfs.btrfs not avaiable | expand

Commit Message

Yi Zhang June 30, 2023, noon UTC
tests/zbd/009: line 24: mkfs.btrfs: command not found
zbd/009 (test gap zone support with BTRFS)                   [not run]
    driver btrfs is not available
    mkfs.btrfs is not available

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
 tests/zbd/009 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Shinichiro Kawasaki July 3, 2023, 8:49 a.m. UTC | #1
On Jun 30, 2023 / 20:00, Yi Zhang wrote:
> tests/zbd/009: line 24: mkfs.btrfs: command not found
> zbd/009 (test gap zone support with BTRFS)                   [not run]
>     driver btrfs is not available
>     mkfs.btrfs is not available
> 
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>

Thanks for the fix! I've applied it with some commit message improvements.
diff mbox series

Patch

diff --git a/tests/zbd/009 b/tests/zbd/009
index c0ce1f2..6226d83 100755
--- a/tests/zbd/009
+++ b/tests/zbd/009
@@ -35,9 +35,8 @@  requires() {
 	_have_fio
 	_have_driver btrfs
 	_have_module_param scsi_debug zone_cap_mb
-	_have_program mkfs.btrfs
+	_have_program mkfs.btrfs && have_good_mkfs_btrfs
 	_have_module scsi_debug
-	have_good_mkfs_btrfs
 }
 
 test() {