diff mbox series

[v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()

Message ID 20230705103950.15225-1-duminjie@vivo.com (mailing list archive)
State Accepted
Headers show
Series [v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp() | expand

Commit Message

Minjie Du July 5, 2023, 10:39 a.m. UTC
Delete a duplicate statement from this function implementation.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Alok Prasad July 11, 2023, 6:18 a.m. UTC | #1
> -----Original Message-----
> From: Minjie Du <duminjie@vivo.com>
> Sent: 05 July 2023 16:10
> To: Markus.Elfring@web.de; Michal Kalderon <mkalderon@marvell.com>; Ariel Elior <aelior@marvell.com>; Jason Gunthorpe
> <jgg@ziepe.ca>; Leon Romanovsky <leon@kernel.org>; open list:QLOGIC QL4xxx RDMA DRIVER <linux-rdma@vger.kernel.org>; open
> list <linux-kernel@vger.kernel.org>
> Cc: opensource.kernel@vivo.com; Minjie Du <duminjie@vivo.com>
> Subject: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
> 
> Delete a duplicate statement from this function implementation.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> index 05307c148..859f66a51 100644
> --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> @@ -354,7 +354,6 @@ int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
>  	/* the GSI CQ is handled by the driver so remove it from the FW */
>  	qedr_destroy_gsi_cq(dev, attrs);
>  	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> -	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> 
>  	DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);
> 
> --
> 2.39.0


Thanks for making the change.

Acked-by: Alok Prasad <palok@marvell.com>
Leon Romanovsky July 19, 2023, 9:48 a.m. UTC | #2
On Wed, 05 Jul 2023 18:39:50 +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
> 
> 

Applied, thanks!

[1/1] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
      https://git.kernel.org/rdma/rdma/c/296609e6b64cd1

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
index 05307c148..859f66a51 100644
--- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
+++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
@@ -354,7 +354,6 @@  int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
 	/* the GSI CQ is handled by the driver so remove it from the FW */
 	qedr_destroy_gsi_cq(dev, attrs);
 	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
-	dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
 
 	DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);