| Message ID | 20230731110012.2913742-6-jagan@edgeble.ai (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: rockchip: Add RV1126 Display (MIPI DSI) support | expand |
On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote: > Document the VOP for Rockchip RV1126. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> There's no commentary here about compatibility with other, existing, devices nor did you CC me on the rest of the series. How am I supposed to know if appending to enum is the right thing to do? Ditto the other binding. Thanks, Conor. > --- > Cc: dri-devel@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Sandy Huang <hjc@rock-chips.com> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > > .../devicetree/bindings/display/rockchip/rockchip-vop.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml > index df61cb5f5c54..b339b7e708c6 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml > @@ -31,6 +31,7 @@ properties: > - rockchip,rk3368-vop > - rockchip,rk3399-vop-big > - rockchip,rk3399-vop-lit > + - rockchip,rv1126-vop > > reg: > minItems: 1 > -- > 2.25.1 >
On Wed, 2 Aug 2023 at 02:37, Conor Dooley <conor@kernel.org> wrote: > > On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote: > > Document the VOP for Rockchip RV1126. > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > There's no commentary here about compatibility with other, existing, > devices nor did you CC me on the rest of the series. How am I supposed > to know if appending to enum is the right thing to do? I had past comments not to add all people in the entire series and add one relevant developer on respective patches. On that note, I tried to CC the developers only involved in the respective areas. But, you are CCed to the DT patch that affected this binding. "[PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support" Please let me know if I missed anything. Thanks, Jagan.
On Wed, Aug 02, 2023 at 08:07:55PM +0530, Jagan Teki wrote: > On Wed, 2 Aug 2023 at 02:37, Conor Dooley <conor@kernel.org> wrote: > > > > On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote: > > > Document the VOP for Rockchip RV1126. > > > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > > There's no commentary here about compatibility with other, existing, > > devices nor did you CC me on the rest of the series. How am I supposed > > to know if appending to enum is the right thing to do? > > I had past comments not to add all people in the entire series and add > one relevant developer on respective patches. On that note, I tried to > CC the developers only involved in the respective areas. But, you are > CCed to the DT patch that affected this binding. > "[PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support" > Please let me know if I missed anything. I suppose you missed saying in the commit message that this is incompatible with existing vop implementations? Don't need to CC me on all patches (although it is useful), but please let the patches explain themselves if you don't. Anyway, I went on lore and had a look, so with an improved commit message, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml index df61cb5f5c54..b339b7e708c6 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml @@ -31,6 +31,7 @@ properties: - rockchip,rk3368-vop - rockchip,rk3399-vop-big - rockchip,rk3399-vop-lit + - rockchip,rv1126-vop reg: minItems: 1
Document the VOP for Rockchip RV1126. Signed-off-by: Jagan Teki <jagan@edgeble.ai> --- Cc: dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Sandy Huang <hjc@rock-chips.com> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> .../devicetree/bindings/display/rockchip/rockchip-vop.yaml | 1 + 1 file changed, 1 insertion(+)