| Message ID | 20230809144148.13052-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [net-next] rds: tcp: Remove unused declaration rds_tcp_map_seq() | expand |
On Wed, Aug 09, 2023 at 10:41:48PM +0800, Yue Haibing wrote: > rds_tcp_map_seq() is never implemented and used since > commit 70041088e3b9 ("RDS: Add TCP transport to RDS"). > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org> BTW, I think these rds patches could have been rolled-up into a patch-set, or perhaps better still squashed into a single patch.
On 2023/8/11 3:49, Simon Horman wrote: > On Wed, Aug 09, 2023 at 10:41:48PM +0800, Yue Haibing wrote: >> rds_tcp_map_seq() is never implemented and used since >> commit 70041088e3b9 ("RDS: Add TCP transport to RDS"). >> >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > > Reviewed-by: Simon Horman <horms@kernel.org> > > BTW, I think these rds patches could have been rolled-up > into a patch-set, or perhaps better still squashed into a single patch. Thanks, will fold them in v2. > . >
diff --git a/net/rds/tcp.h b/net/rds/tcp.h index f8b5930d7b34..053aa7da87ef 100644 --- a/net/rds/tcp.h +++ b/net/rds/tcp.h @@ -56,7 +56,6 @@ void rds_tcp_restore_callbacks(struct socket *sock, struct rds_tcp_connection *tc); u32 rds_tcp_write_seq(struct rds_tcp_connection *tc); u32 rds_tcp_snd_una(struct rds_tcp_connection *tc); -u64 rds_tcp_map_seq(struct rds_tcp_connection *tc, u32 seq); extern struct rds_transport rds_tcp_transport; void rds_tcp_accept_work(struct sock *sk); int rds_tcp_laddr_check(struct net *net, const struct in6_addr *addr,
rds_tcp_map_seq() is never implemented and used since commit 70041088e3b9 ("RDS: Add TCP transport to RDS"). Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- net/rds/tcp.h | 1 - 1 file changed, 1 deletion(-)