diff mbox series

RDMA/rxe: Fix redundant break statement in switch-case.

Message ID 20230822091304.7312-1-roheetchavan@gmail.com (mailing list archive)
State Accepted
Headers show
Series RDMA/rxe: Fix redundant break statement in switch-case. | expand

Commit Message

Rohit Chavan Aug. 22, 2023, 9:13 a.m. UTC 
Removed unreachable break statement after return.

Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
 drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
 1 file changed, 1 deletion(-)

--
2.30.2

Comments

Zhu Yanjun Aug. 22, 2023, 9:24 a.m. UTC | #1 
On Tue, Aug 22, 2023 at 5:13 PM Rohit Chavan <roheetchavan@gmail.com> wrote:
>
> Removed unreachable break statement after return.
>
> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>

Thanks a lot.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 903f0b71447e..48f86839d36a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -798,7 +798,6 @@ static int init_send_wr(struct rxe_qp *qp, struct rxe_send_wr *wr,
>                         rxe_err_qp(qp, "unsupported wr opcode %d",
>                                         wr->opcode);
>                         return -EINVAL;
> -                       break;
>                 }
>         }
>
> --
> 2.30.2
>
Leon Romanovsky Aug. 22, 2023, 2:23 p.m. UTC | #2 
On Tue, 22 Aug 2023 14:43:04 +0530, Rohit Chavan wrote:
> Removed unreachable break statement after return.
> 
> 

Applied, thanks!

[1/1] RDMA/rxe: Fix redundant break statement in switch-case.
      https://git.kernel.org/rdma/rdma/c/6812e069990547

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index 903f0b71447e..48f86839d36a 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -798,7 +798,6 @@  static int init_send_wr(struct rxe_qp *qp, struct rxe_send_wr *wr,
 			rxe_err_qp(qp, "unsupported wr opcode %d",
 					wr->opcode);
 			return -EINVAL;
-			break;
 		}
 	}