| Message ID | 20230825062404.50813-1-pkshih@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 497840a1fc5c40a6a30d22f9a375552323156146 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: rtw88: fix typo rtw8822cu_probe | expand |
Ping-Ke Shih <pkshih@realtek.com> writes: > From: Po-Hao Huang <phhuang@realtek.com> > > The probe function of 8822cu is misplaced to 8822bu, so we fix it. > > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support") > Signed-off-by: Po-Hao Huang <phhuang@realtek.com> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> I guess this is just a cosmetic change and does not cause any changes in functionality? I can add that to the commit log.
> -----Original Message----- > From: Kalle Valo <kvalo@kernel.org> > Sent: Friday, August 25, 2023 2:47 PM > To: Ping-Ke Shih <pkshih@realtek.com> > Cc: Bernie Huang <phhuang@realtek.com>; linux-wireless@vger.kernel.org > Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe > > Ping-Ke Shih <pkshih@realtek.com> writes: > > > From: Po-Hao Huang <phhuang@realtek.com> > > > > The probe function of 8822cu is misplaced to 8822bu, so we fix it. > > > > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support") > > Signed-off-by: Po-Hao Huang <phhuang@realtek.com> > > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> > > I guess this is just a cosmetic change and does not cause any changes in > functionality? I can add that to the commit log. > Yes, it doesn't change anything. If Fixes tag is not suitable, please also remove it. Thank you. Ping-ke
Ping-Ke Shih <pkshih@realtek.com> writes: >> -----Original Message----- >> From: Kalle Valo <kvalo@kernel.org> >> Sent: Friday, August 25, 2023 2:47 PM >> To: Ping-Ke Shih <pkshih@realtek.com> >> Cc: Bernie Huang <phhuang@realtek.com>; linux-wireless@vger.kernel.org >> Subject: Re: [PATCH] wifi: rtw88: fix typo rtw8822cu_probe >> >> Ping-Ke Shih <pkshih@realtek.com> writes: >> >> > From: Po-Hao Huang <phhuang@realtek.com> >> > >> > The probe function of 8822cu is misplaced to 8822bu, so we fix it. >> > >> > Fixes: 07cef03b8d44 ("wifi: rtw88: Add rtw8822cu chipset support") >> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com> >> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> >> >> I guess this is just a cosmetic change and does not cause any changes in >> functionality? I can add that to the commit log. > > Yes, it doesn't change anything. If Fixes tag is not suitable, please also > remove it. Good point, as this is not fixing any functionality in opinion there should not be a Fixes tag. I'll also remove that.
Ping-Ke Shih <pkshih@realtek.com> wrote: > From: Po-Hao Huang <phhuang@realtek.com> > > The probe function of 8822cu is misplaced to 8822bu, so we fix it. Just > cosmetics, no changes in functionality. > > Signed-off-by: Po-Hao Huang <phhuang@realtek.com> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. 497840a1fc5c wifi: rtw88: fix typo rtw8822cu_probe
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822cu.c b/drivers/net/wireless/realtek/rtw88/rtw8822cu.c index af28ca09d41f..157d5102a4b1 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822cu.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822cu.c @@ -25,7 +25,7 @@ static const struct usb_device_id rtw_8822cu_id_table[] = { }; MODULE_DEVICE_TABLE(usb, rtw_8822cu_id_table); -static int rtw8822bu_probe(struct usb_interface *intf, +static int rtw8822cu_probe(struct usb_interface *intf, const struct usb_device_id *id) { return rtw_usb_probe(intf, id); @@ -34,7 +34,7 @@ static int rtw8822bu_probe(struct usb_interface *intf, static struct usb_driver rtw_8822cu_driver = { .name = "rtw_8822cu", .id_table = rtw_8822cu_id_table, - .probe = rtw8822bu_probe, + .probe = rtw8822cu_probe, .disconnect = rtw_usb_disconnect, }; module_usb_driver(rtw_8822cu_driver);