[v5,1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

Commit Message

Jim Quinlan May 8, 2023, 10:01 p.m. UTC

This commit adds the boolean "brcm,enable-l1ss" property:

  The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
  requires the driver probe() to deliberately place the HW one of three
  CLKREQ# modes:

  (a) CLKREQ# driven by the RC unconditionally
  (b) CLKREQ# driven by the EP for ASPM L0s, L1
  (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).

  The HW+driver can tell the difference between downstream devices that
  need (a) and (b), but does not know when to configure (c).  All devices
  should work fine when the driver chooses (a) or (b), but (c) may be
  desired to realize the extra power savings that L1SS offers.  So we
  introduce the boolean "brcm,enable-l1ss" property to inform the driver
  that (c) is desired.  Setting this property only makes sense when the
  downstream device is L1SS-capable and the OS is configured to activate
  this mode (e.g. policy==powersupersave).

  This property is already present in the Raspian version of Linux, but the
  upstream driver implementation that follows adds more details and
  discerns between (a) and (b).

Signed-off-by: Jim Quinlan <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>
---
 Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Manivannan Sadhasivam Aug. 23, 2023, 7:43 a.m. UTC | #1

On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> This commit adds the boolean "brcm,enable-l1ss" property:
> 
>   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
>   requires the driver probe() to deliberately place the HW one of three
>   CLKREQ# modes:
> 
>   (a) CLKREQ# driven by the RC unconditionally
>   (b) CLKREQ# driven by the EP for ASPM L0s, L1
>   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> 
>   The HW+driver can tell the difference between downstream devices that
>   need (a) and (b), but does not know when to configure (c).  All devices
>   should work fine when the driver chooses (a) or (b), but (c) may be
>   desired to realize the extra power savings that L1SS offers.  So we
>   introduce the boolean "brcm,enable-l1ss" property to inform the driver
>   that (c) is desired.  Setting this property only makes sense when the
>   downstream device is L1SS-capable and the OS is configured to activate
>   this mode (e.g. policy==powersupersave).
> 
>   This property is already present in the Raspian version of Linux, but the
>   upstream driver implementation that follows adds more details and
>   discerns between (a) and (b).
> 
> Signed-off-by: Jim Quinlan <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> ---
>  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 7e15aae7d69e..8b61c2179608 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -64,6 +64,15 @@ properties:
>  
>    aspm-no-l0s: true
>  
> +  brcm,enable-l1ss:
> +    description: Indicates that PCIe L1SS power savings
> +      are desired, the downstream device is L1SS-capable, and the
> +      OS has been configured to enable this mode.  For boards
> +      using a mini-card connector, this mode may not meet the
> +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> +      of the PCI Express Mini CEM 2.0 specification.

As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
the hardware capability and not system/OS behavior. If this flag specifies
whether the PCIe controller supports L1SS or not, then it is fine but apparantly
this specifies that all downstream devices are L1SS capable which you cannot
guarantee unless you poke into their LNKCAP during runtime.

You should handle this in the driver itself.

- Mani

> +    type: boolean
> +
>    brcm,scb-sizes:
>      description: u64 giving the 64bit PCIe memory
>        viewport size of a memory controller.  There may be up to
> -- 
> 2.17.1
>

Manivannan Sadhasivam Aug. 23, 2023, 6:16 p.m. UTC | #2

On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> >
> > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > This commit adds the boolean "brcm,enable-l1ss" property:
> > >
> > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > >   requires the driver probe() to deliberately place the HW one of three
> > >   CLKREQ# modes:
> > >
> > >   (a) CLKREQ# driven by the RC unconditionally
> > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > >
> > >   The HW+driver can tell the difference between downstream devices that
> > >   need (a) and (b), but does not know when to configure (c).  All devices
> > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > >   desired to realize the extra power savings that L1SS offers.  So we
> > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > >   that (c) is desired.  Setting this property only makes sense when the
> > >   downstream device is L1SS-capable and the OS is configured to activate
> > >   this mode (e.g. policy==powersupersave).
> > >
> > >   This property is already present in the Raspian version of Linux, but the
> > >   upstream driver implementation that follows adds more details and
> > >   discerns between (a) and (b).
> > >
> > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > Reviewed-by: Rob Herring <[e-mail]>
> > > ---
> > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > index 7e15aae7d69e..8b61c2179608 100644
> > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > @@ -64,6 +64,15 @@ properties:
> > >
> > >    aspm-no-l0s: true
> > >
> > > +  brcm,enable-l1ss:
> > > +    description: Indicates that PCIe L1SS power savings
> > > +      are desired, the downstream device is L1SS-capable, and the
> > > +      OS has been configured to enable this mode.  For boards
> > > +      using a mini-card connector, this mode may not meet the
> > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > +      of the PCI Express Mini CEM 2.0 specification.
> >
> > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > the hardware capability and not system/OS behavior.
> 
> The "brcm,enable-l1ss" does NOT configure the OS behavior.
> It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> configured for L1SS.
> It compensates for a problem in the PCIe core: the HW is not capable
> of dynamically
> switching between ASPM modes powersave and superpowersave.  I am actively
> advocating for our HW to change but that will take years.
> 

Okay, then I would say that the property name and commit message were a bit
misleading. 

I had briefly gone through the driver patch now. As per my understanding, you
have 2 modes in hw:

1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
the device (driving high) when the link is in L1.

2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.

Till now the driver only supported Clock PM through mode (1) but for supporting
L1SS you need to enable mode (2). And you are using this property to select mode
(2) when the L1SS supported devices are connected to the slot. Also, by
selecting this mode, you are loosing the benefit of mode (1) as both are not
compatible.

My suggestion would be to just drop mode (1) and use mode (2) in the driver as
most of the recent devices should support L1SS (ofc there are exemptions).

But moving that decision to DT still doesn't seem right to me as the hardware
supports both modes and you are (ab)using DT to choose one or the other.

- Mani

> If this flag specifies
> > whether the PCIe controller supports L1SS or not, then it is fine but apparantly
> > this specifies that all downstream devices are L1SS capable which you cannot
> > guarantee unless you poke into their LNKCAP during runtime.
> Not true at all.  This setting affects only RC and whatever device is
> connected to its single downstream
> port.
> 
> >
> > You should handle this in the driver itself.
> 
> The driver has no way of knowing if the PCI subsystem is going from power_save
> to power_supersave or vice-versa -- there is no notification chain for this.  So
> what you say is not currently possible from the driver's perspective.
> 
> Perhaps you would be happy if we changed it to "l1ss-support" in the
> spirit of the
> existing "clkreq-support" PCI parameter?
> 
> Regards,
> Jim Quinlan
> Broadcom STB/CMi
> 
> >
> > - Mani
> >
> > > +    type: boolean
> > > +
> > >    brcm,scb-sizes:
> > >      description: u64 giving the 64bit PCIe memory
> > >        viewport size of a memory controller.  There may be up to
> > > --
> > > 2.17.1
> > >
> >
> > --
> > மணிவண்ணன் சதாசிவம்

> Date: Tue, 22 Aug 2023 21:01:47 +0000 (UTC)
> From: Florian Fainelli <[e-mail]>
> To: [e-mail]
> Subject: Join me now in my Personal Room
> 
> Hello,
> 
> Join me now in my Personal Room. 
> 
> JOIN WEBEX MEETING
> https://broadcom.webex.com/join/florian.fainelli  |  490 282 179
> 
> 
> JOIN FROM A VIDEO CONFERENCING SYSTEM OR APPLICATION
> Dial sip:[e-mail]
> You can also dial 173.243.2.68 and enter your meeting number.
> 
> 
> 
> Can't join the meeting?
> https://help.webex.com/docs/DOC-5412
> 
> PHONE DIALING GUIDELINES:
>         - Use Call Me when you are using office phone or Jabber.
>         - Use Call Using Computer when you are at home or traveling.
> 
> In Office Calls:
> 	- From Broadcom Office: 1-MEETING (1-6338464)
> 
> Offsite Numbers Toll (Local) Calls:
> 	- Canada, Richmond: [phone]
> 	- China: [phone]
> 	- Germany, Munich: [phone]
>         - Germany, Regensburg: [phone]
>         - India: 00-080-0050-1631
> 	- Israel: [phone]
>         - Japan, Tokyo: [phone]
>         - Malaysia: [phone]
> 	- Singapore: [phone]
> 	- South Korea, Seoul: [phone]
> 	- Taiwan, Taipei: [phone]
> 	- US, Denver: [phone]
>         - US, Los Angeles: [phone]
>         - US, Philadelphia: [phone]
> 	- UK, London: [phone]
>         - UK, Manchester: [phone]
> 
> IMPORTANT NOTICE: Please note that this Webex service allows audio and other information sent during the session to be recorded, which may be discoverable in a legal matter. By joining this session, you automatically consent to such recordings. If you do not consent to being recorded, discuss your concerns with the host or do not join the session.

Lorenzo Pieralisi Aug. 24, 2023, 10:12 a.m. UTC | #3

On Wed, Aug 23, 2023 at 11:46:50PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > >
> > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > >
> > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > >   requires the driver probe() to deliberately place the HW one of three
> > > >   CLKREQ# modes:
> > > >
> > > >   (a) CLKREQ# driven by the RC unconditionally
> > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > >
> > > >   The HW+driver can tell the difference between downstream devices that
> > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > >   that (c) is desired.  Setting this property only makes sense when the
> > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > >   this mode (e.g. policy==powersupersave).
> > > >
> > > >   This property is already present in the Raspian version of Linux, but the
> > > >   upstream driver implementation that follows adds more details and
> > > >   discerns between (a) and (b).
> > > >
> > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > ---
> > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > >  1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > @@ -64,6 +64,15 @@ properties:
> > > >
> > > >    aspm-no-l0s: true
> > > >
> > > > +  brcm,enable-l1ss:
> > > > +    description: Indicates that PCIe L1SS power savings
> > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > +      OS has been configured to enable this mode.  For boards
> > > > +      using a mini-card connector, this mode may not meet the
> > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > +      of the PCI Express Mini CEM 2.0 specification.
> > >
> > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > the hardware capability and not system/OS behavior.
> > 
> > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > configured for L1SS.
> > It compensates for a problem in the PCIe core: the HW is not capable
> > of dynamically
> > switching between ASPM modes powersave and superpowersave.  I am actively
> > advocating for our HW to change but that will take years.
> > 
> 
> Okay, then I would say that the property name and commit message were a bit
> misleading. 
> 
> I had briefly gone through the driver patch now. As per my understanding, you
> have 2 modes in hw:
> 
> 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> the device (driving high) when the link is in L1.
> 
> 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.
> 
> Till now the driver only supported Clock PM through mode (1) but for supporting
> L1SS you need to enable mode (2). And you are using this property to select mode
> (2) when the L1SS supported devices are connected to the slot. Also, by
> selecting this mode, you are loosing the benefit of mode (1) as both are not
> compatible.
> 
> My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> most of the recent devices should support L1SS (ofc there are exemptions).
> 
> But moving that decision to DT still doesn't seem right to me as the hardware
> supports both modes and you are (ab)using DT to choose one or the other.

Jim ? We need to queue this series as soon as possible, if we don't
reach consensus by this evening I will queue the last three patches
only.

Lorenzo

> - Mani
> 
> > If this flag specifies
> > > whether the PCIe controller supports L1SS or not, then it is fine but apparantly
> > > this specifies that all downstream devices are L1SS capable which you cannot
> > > guarantee unless you poke into their LNKCAP during runtime.
> > Not true at all.  This setting affects only RC and whatever device is
> > connected to its single downstream
> > port.
> > 
> > >
> > > You should handle this in the driver itself.
> > 
> > The driver has no way of knowing if the PCI subsystem is going from power_save
> > to power_supersave or vice-versa -- there is no notification chain for this.  So
> > what you say is not currently possible from the driver's perspective.
> > 
> > Perhaps you would be happy if we changed it to "l1ss-support" in the
> > spirit of the
> > existing "clkreq-support" PCI parameter?
> > 
> > Regards,
> > Jim Quinlan
> > Broadcom STB/CMi
> > 
> > >
> > > - Mani
> > >
> > > > +    type: boolean
> > > > +
> > > >    brcm,scb-sizes:
> > > >      description: u64 giving the 64bit PCIe memory
> > > >        viewport size of a memory controller.  There may be up to
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > --
> > > மணிவண்ணன் சதாசிவம்
> 
> > Date: Tue, 22 Aug 2023 21:01:47 +0000 (UTC)
> > From: Florian Fainelli <[e-mail]>
> > To: [e-mail]
> > Subject: Join me now in my Personal Room
> > 
> > Hello,
> > 
> > Join me now in my Personal Room. 
> > 
> > JOIN WEBEX MEETING
> > https://broadcom.webex.com/join/florian.fainelli  |  490 282 179
> > 
> > 
> > JOIN FROM A VIDEO CONFERENCING SYSTEM OR APPLICATION
> > Dial sip:[e-mail]
> > You can also dial 173.243.2.68 and enter your meeting number.
> > 
> > 
> > 
> > Can't join the meeting?
> > https://help.webex.com/docs/DOC-5412
> > 
> > PHONE DIALING GUIDELINES:
> >         - Use Call Me when you are using office phone or Jabber.
> >         - Use Call Using Computer when you are at home or traveling.
> > 
> > In Office Calls:
> > 	- From Broadcom Office: 1-MEETING (1-6338464)
> > 
> > Offsite Numbers Toll (Local) Calls:
> > 	- Canada, Richmond: [phone]
> > 	- China: [phone]
> > 	- Germany, Munich: [phone]
> >         - Germany, Regensburg: [phone]
> >         - India: 00-080-0050-1631
> > 	- Israel: [phone]
> >         - Japan, Tokyo: [phone]
> >         - Malaysia: [phone]
> > 	- Singapore: [phone]
> > 	- South Korea, Seoul: [phone]
> > 	- Taiwan, Taipei: [phone]
> > 	- US, Denver: [phone]
> >         - US, Los Angeles: [phone]
> >         - US, Philadelphia: [phone]
> > 	- UK, London: [phone]
> >         - UK, Manchester: [phone]
> > 
> > IMPORTANT NOTICE: Please note that this Webex service allows audio and other information sent during the session to be recorded, which may be discoverable in a legal matter. By joining this session, you automatically consent to such recordings. If you do not consent to being recorded, discuss your concerns with the host or do not join the session.
> 
> 
> 
> 
> 
> -- 
> மணிவண்ணன் சதாசிவம்

Jim Quinlan Aug. 24, 2023, 2:55 p.m. UTC | #4

On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam <[e-mail]> wrote:
>
> On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > >
> > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > >
> > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > >   requires the driver probe() to deliberately place the HW one of three
> > > >   CLKREQ# modes:
> > > >
> > > >   (a) CLKREQ# driven by the RC unconditionally
> > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > >
> > > >   The HW+driver can tell the difference between downstream devices that
> > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > >   that (c) is desired.  Setting this property only makes sense when the
> > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > >   this mode (e.g. policy==powersupersave).
> > > >
> > > >   This property is already present in the Raspian version of Linux, but the
> > > >   upstream driver implementation that follows adds more details and
> > > >   discerns between (a) and (b).
> > > >
> > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > ---
> > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > >  1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > @@ -64,6 +64,15 @@ properties:
> > > >
> > > >    aspm-no-l0s: true
> > > >
> > > > +  brcm,enable-l1ss:
> > > > +    description: Indicates that PCIe L1SS power savings
> > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > +      OS has been configured to enable this mode.  For boards
> > > > +      using a mini-card connector, this mode may not meet the
> > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > +      of the PCI Express Mini CEM 2.0 specification.
> > >
> > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > the hardware capability and not system/OS behavior.
> >
> > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > configured for L1SS.
> > It compensates for a problem in the PCIe core: the HW is not capable
> > of dynamically
> > switching between ASPM modes powersave and superpowersave.  I am actively
> > advocating for our HW to change but that will take years.
> >
>
> Okay, then I would say that the property name and commit message were a bit
> misleading.
>
> I had briefly gone through the driver patch now. As per my understanding, you
> have 2 modes in hw:
>
> 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> the device (driving high) when the link is in L1.
>
> 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.

No, there are three, as enumerated in the commit message of
"PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device"

>
> Till now the driver only supported Clock PM through mode (1) but for supporting
> L1SS you need to enable mode (2). And you are using this property to select mode
> (2) when the L1SS supported devices are connected to the slot. Also, by
> selecting this mode, you are loosing the benefit of mode (1) as both are not
> compatible.
>
> My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> most of the recent devices should support L1SS (ofc there are exemptions).
The disadvantage of this, as stated by the PCIe core HW designer, was
that "doing so means
we cannot enable the Cock Power Management capability since it may run afoul of
the Tclron requirement."

I will attempt to press him on exactly what configurations and form
factors would be
vulnerable to this -- he was so convinced that it was a danger that he
is against
making L1SS mode the default.

>
> But moving that decision to DT still doesn't seem right to me as the hardware
> supports both modes and you are (ab)using DT to choose one or the other.

May be true, but there does not appear to be a Linux upstream-acceptable
way of doing this on the command line either; please see my recent post
on why this is so.

There will be cases where we want to override the default setting, either by
command line or DT, but you folks have to give me a viable path on
how to do this with it actually being accepted.

Regards,
Jim Quinlan
Broadcom STB/CM

>
> - Mani
>
> > If this flag specifies
> > > whether the PCIe controller supports L1SS or not, then it is fine but apparantly
> > > this specifies that all downstream devices are L1SS capable which you cannot
> > > guarantee unless you poke into their LNKCAP during runtime.
> > Not true at all.  This setting affects only RC and whatever device is
> > connected to its single downstream
> > port.
> >
> > >
> > > You should handle this in the driver itself.
> >
> > The driver has no way of knowing if the PCI subsystem is going from power_save
> > to power_supersave or vice-versa -- there is no notification chain for this.  So
> > what you say is not currently possible from the driver's perspective.
> >
> > Perhaps you would be happy if we changed it to "l1ss-support" in the
> > spirit of the
> > existing "clkreq-support" PCI parameter?
> >
> > Regards,
> > Jim Quinlan
> > Broadcom STB/CMi
> >
> > >
> > > - Mani
> > >
> > > > +    type: boolean
> > > > +
> > > >    brcm,scb-sizes:
> > > >      description: u64 giving the 64bit PCIe memory
> > > >        viewport size of a memory controller.  There may be up to
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > --
> > > மணிவண்ணன் சதாசிவம்
>
> > Date: Tue, 22 Aug 2023 21:01:47 +0000 (UTC)
> > From: Florian Fainelli <[e-mail]>
> > To: [e-mail]
> > Subject: Join me now in my Personal Room
> >
> > Hello,
> >
> > Join me now in my Personal Room.
> >
> > JOIN WEBEX MEETING
> > https://broadcom.webex.com/join/florian.fainelli  |  490 282 179
> >
> >
> > JOIN FROM A VIDEO CONFERENCING SYSTEM OR APPLICATION
> > Dial sip:[e-mail]
> > You can also dial 173.243.2.68 and enter your meeting number.
> >
> >
> >
> > Can't join the meeting?
> > https://help.webex.com/docs/DOC-5412
> >
> > PHONE DIALING GUIDELINES:
> >         - Use Call Me when you are using office phone or Jabber.
> >         - Use Call Using Computer when you are at home or traveling.
> >
> > In Office Calls:
> >       - From Broadcom Office: 1-MEETING (1-6338464)
> >
> > Offsite Numbers Toll (Local) Calls:
> >       - Canada, Richmond: [phone]
> >       - China: [phone]
> >       - Germany, Munich: [phone]
> >         - Germany, Regensburg: [phone]
> >         - India: 00-080-0050-1631
> >       - Israel: [phone]
> >         - Japan, Tokyo: [phone]
> >         - Malaysia: [phone]
> >       - Singapore: [phone]
> >       - South Korea, Seoul: [phone]
> >       - Taiwan, Taipei: [phone]
> >       - US, Denver: [phone]
> >         - US, Los Angeles: [phone]
> >         - US, Philadelphia: [phone]
> >       - UK, London: [phone]
> >         - UK, Manchester: [phone]
> >
> > IMPORTANT NOTICE: Please note that this Webex service allows audio and other information sent during the session to be recorded, which may be discoverable in a legal matter. By joining this session, you automatically consent to such recordings. If you do not consent to being recorded, discuss your concerns with the host or do not join the session.
>
>
>
>
>
> --
> மணிவண்ணன் சதாசிவம்

Manivannan Sadhasivam Aug. 25, 2023, 6:45 a.m. UTC | #5

On Thu, Aug 24, 2023 at 10:55:02AM -0400, Jim Quinlan wrote:
> On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam <[e-mail]> wrote:
> >
> > On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > > >
> > > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > >
> > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > >   CLKREQ# modes:
> > > > >
> > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > >
> > > > >   The HW+driver can tell the difference between downstream devices that
> > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > >   this mode (e.g. policy==powersupersave).
> > > > >
> > > > >   This property is already present in the Raspian version of Linux, but the
> > > > >   upstream driver implementation that follows adds more details and
> > > > >   discerns between (a) and (b).
> > > > >
> > > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > >  1 file changed, 9 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > @@ -64,6 +64,15 @@ properties:
> > > > >
> > > > >    aspm-no-l0s: true
> > > > >
> > > > > +  brcm,enable-l1ss:
> > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > +      OS has been configured to enable this mode.  For boards
> > > > > +      using a mini-card connector, this mode may not meet the
> > > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > >
> > > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > > the hardware capability and not system/OS behavior.
> > >
> > > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > > configured for L1SS.
> > > It compensates for a problem in the PCIe core: the HW is not capable
> > > of dynamically
> > > switching between ASPM modes powersave and superpowersave.  I am actively
> > > advocating for our HW to change but that will take years.
> > >
> >
> > Okay, then I would say that the property name and commit message were a bit
> > misleading.
> >
> > I had briefly gone through the driver patch now. As per my understanding, you
> > have 2 modes in hw:
> >
> > 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> > the device (driving high) when the link is in L1.
> >
> > 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.
> 
> No, there are three, as enumerated in the commit message of
> "PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device"
> 

Yeah, another one is refclk always on.

> >
> > Till now the driver only supported Clock PM through mode (1) but for supporting
> > L1SS you need to enable mode (2). And you are using this property to select mode
> > (2) when the L1SS supported devices are connected to the slot. Also, by
> > selecting this mode, you are loosing the benefit of mode (1) as both are not
> > compatible.
> >
> > My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> > most of the recent devices should support L1SS (ofc there are exemptions).
> The disadvantage of this, as stated by the PCIe core HW designer, was
> that "doing so means
> we cannot enable the Cock Power Management capability since it may run afoul of
> the Tclron requirement."
> 

Ok.

> I will attempt to press him on exactly what configurations and form
> factors would be
> vulnerable to this -- he was so convinced that it was a danger that he
> is against
> making L1SS mode the default.
> 

Hmm. After looking at this problem in detail, it looks to me that you can still
use DT but not with the property you proposed. Since these are hardware modes,
you can have a single DT property that specifies the mode that the driver can
use to configure the hw. It is similar to "phy-mode" property we have for the
network controllers.

So you should have the property defined as below in binding:

brcm,clkreq-mode:
  $ref: /schemas/types.yaml#/definitions/uint32
  enum: [ 0, 1, 2 ]

Then create definition for each mode in "include/dt-bindings/pci/brcm,stb.h".

#define BRCM_STB_CLKREQ_CLOCK_PM	0
#define BRCM_STB_CLKREQ_L1SS		1
#define BRCM_STB_CLKREQ_ON		2

If the property is not specified, the driver should use "Clock PM" as the
default mode as it was doing earlier.

Also, I think you can get rid of other checks in the driver (like PCIEASPM
Kconfig, clkreq_seen etc...) and solely rely on this property to set the mode.

What do you think?

- Mani

> >
> > But moving that decision to DT still doesn't seem right to me as the hardware
> > supports both modes and you are (ab)using DT to choose one or the other.
> 
> May be true, but there does not appear to be a Linux upstream-acceptable
> way of doing this on the command line either; please see my recent post
> on why this is so.
> 
> There will be cases where we want to override the default setting, either by
> command line or DT, but you folks have to give me a viable path on
> how to do this with it actually being accepted.
> 
> Regards,
> Jim Quinlan
> Broadcom STB/CM
> 
> >
> > - Mani
> >
> > > If this flag specifies
> > > > whether the PCIe controller supports L1SS or not, then it is fine but apparantly
> > > > this specifies that all downstream devices are L1SS capable which you cannot
> > > > guarantee unless you poke into their LNKCAP during runtime.
> > > Not true at all.  This setting affects only RC and whatever device is
> > > connected to its single downstream
> > > port.
> > >
> > > >
> > > > You should handle this in the driver itself.
> > >
> > > The driver has no way of knowing if the PCI subsystem is going from power_save
> > > to power_supersave or vice-versa -- there is no notification chain for this.  So
> > > what you say is not currently possible from the driver's perspective.
> > >
> > > Perhaps you would be happy if we changed it to "l1ss-support" in the
> > > spirit of the
> > > existing "clkreq-support" PCI parameter?
> > >
> > > Regards,
> > > Jim Quinlan
> > > Broadcom STB/CMi
> > >
> > > >
> > > > - Mani
> > > >
> > > > > +    type: boolean
> > > > > +
> > > > >    brcm,scb-sizes:
> > > > >      description: u64 giving the 64bit PCIe memory
> > > > >        viewport size of a memory controller.  There may be up to
> > > > > --
> > > > > 2.17.1
> > > > >
> > > >
> > > > --
> > > > மணிவண்ணன் சதாசிவம்
> >
> > > Date: Tue, 22 Aug 2023 21:01:47 +0000 (UTC)
> > > From: Florian Fainelli <[e-mail]>
> > > To: [e-mail]
> > > Subject: Join me now in my Personal Room
> > >
> > > Hello,
> > >
> > > Join me now in my Personal Room.
> > >
> > > JOIN WEBEX MEETING
> > > https://broadcom.webex.com/join/florian.fainelli  |  490 282 179
> > >
> > >
> > > JOIN FROM A VIDEO CONFERENCING SYSTEM OR APPLICATION
> > > Dial sip:[e-mail]
> > > You can also dial 173.243.2.68 and enter your meeting number.
> > >
> > >
> > >
> > > Can't join the meeting?
> > > https://help.webex.com/docs/DOC-5412
> > >
> > > PHONE DIALING GUIDELINES:
> > >         - Use Call Me when you are using office phone or Jabber.
> > >         - Use Call Using Computer when you are at home or traveling.
> > >
> > > In Office Calls:
> > >       - From Broadcom Office: 1-MEETING (1-6338464)
> > >
> > > Offsite Numbers Toll (Local) Calls:
> > >       - Canada, Richmond: [phone]
> > >       - China: [phone]
> > >       - Germany, Munich: [phone]
> > >         - Germany, Regensburg: [phone]
> > >         - India: 00-080-0050-1631
> > >       - Israel: [phone]
> > >         - Japan, Tokyo: [phone]
> > >         - Malaysia: [phone]
> > >       - Singapore: [phone]
> > >       - South Korea, Seoul: [phone]
> > >       - Taiwan, Taipei: [phone]
> > >       - US, Denver: [phone]
> > >         - US, Los Angeles: [phone]
> > >         - US, Philadelphia: [phone]
> > >       - UK, London: [phone]
> > >         - UK, Manchester: [phone]
> > >
> > > IMPORTANT NOTICE: Please note that this Webex service allows audio and other information sent during the session to be recorded, which may be discoverable in a legal matter. By joining this session, you automatically consent to such recordings. If you do not consent to being recorded, discuss your concerns with the host or do not join the session.
> >
> >
> >
> >
> >
> > --
> > மணிவண்ணன் சதாசிவம்

Jim Quinlan Aug. 25, 2023, 6:16 p.m. UTC | #6

On Fri, Aug 25, 2023 at 2:45 AM Manivannan Sadhasivam <[e-mail]> wrote:
>
> On Thu, Aug 24, 2023 at 10:55:02AM -0400, Jim Quinlan wrote:
> > On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam <[e-mail]> wrote:
> > >
> > > On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > > > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > > > >
> > > > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > >
> > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > >   CLKREQ# modes:
> > > > > >
> > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > >
> > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > >   this mode (e.g. policy==powersupersave).
> > > > > >
> > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > >   upstream driver implementation that follows adds more details and
> > > > > >   discerns between (a) and (b).
> > > > > >
> > > > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > > > ---
> > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > >  1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > >
> > > > > >    aspm-no-l0s: true
> > > > > >
> > > > > > +  brcm,enable-l1ss:
> > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > > +      using a mini-card connector, this mode may not meet the
> > > > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > > >
> > > > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > > > the hardware capability and not system/OS behavior.
> > > >
> > > > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > > > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > > > configured for L1SS.
> > > > It compensates for a problem in the PCIe core: the HW is not capable
> > > > of dynamically
> > > > switching between ASPM modes powersave and superpowersave.  I am actively
> > > > advocating for our HW to change but that will take years.
> > > >
> > >
> > > Okay, then I would say that the property name and commit message were a bit
> > > misleading.
> > >
> > > I had briefly gone through the driver patch now. As per my understanding, you
> > > have 2 modes in hw:
> > >
> > > 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> > > the device (driving high) when the link is in L1.
> > >
> > > 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.
> >
> > No, there are three, as enumerated in the commit message of
> > "PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device"
> >
>
> Yeah, another one is refclk always on.
>
> > >
> > > Till now the driver only supported Clock PM through mode (1) but for supporting
> > > L1SS you need to enable mode (2). And you are using this property to select mode
> > > (2) when the L1SS supported devices are connected to the slot. Also, by
> > > selecting this mode, you are loosing the benefit of mode (1) as both are not
> > > compatible.
> > >
> > > My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> > > most of the recent devices should support L1SS (ofc there are exemptions).
> > The disadvantage of this, as stated by the PCIe core HW designer, was
> > that "doing so means
> > we cannot enable the Cock Power Management capability since it may run afoul of
> > the Tclron requirement."
> >
>
> Ok.
>
> > I will attempt to press him on exactly what configurations and form
> > factors would be
> > vulnerable to this -- he was so convinced that it was a danger that he
> > is against
> > making L1SS mode the default.
> >
>
> Hmm. After looking at this problem in detail, it looks to me that you can still
> use DT but not with the property you proposed. Since these are hardware modes,
> you can have a single DT property that specifies the mode that the driver can
> use to configure the hw. It is similar to "phy-mode" property we have for the
> network controllers.
>
> So you should have the property defined as below in binding:
>
> brcm,clkreq-mode:
>   $ref: /schemas/types.yaml#/definitions/uint32
>   enum: [ 0, 1, 2 ]
>
> Then create definition for each mode in "include/dt-bindings/pci/brcm,stb.h".
>
> #define BRCM_STB_CLKREQ_CLOCK_PM        0
> #define BRCM_STB_CLKREQ_L1SS            1
> #define BRCM_STB_CLKREQ_ON              2
>
> If the property is not specified, the driver should use "Clock PM" as the
> default mode as it was doing earlier.
>
> Also, I think you can get rid of other checks in the driver (like PCIEASPM
> Kconfig, clkreq_seen etc...) and solely rely on this property to set the mode.
>
> What do you think?

Hi Mani,

I'm all for it; in fact this is quite similar to  my original design.
But then I decided to be backwards
compatible with RaspianOS's "brcm,enable-l1ss".

I will go in this direction for V7 and the only remaining issue is
what the default mode should
be and I will try my best to get time with the HW designer to weigh
the pros and cons.

Regards,
Jim Quinlan
Broadcom STB/CM

>
>
> - Mani
>
> > >
> > > But moving that decision to DT still doesn't seem right to me as the hardware
> > > supports both modes and you are (ab)using DT to choose one or the other.
> >
> > May be true, but there does not appear to be a Linux upstream-acceptable
> > way of doing this on the command line either; please see my recent post
> > on why this is so.
> >
> > There will be cases where we want to override the default setting, either by
> > command line or DT, but you folks have to give me a viable path on
> > how to do this with it actually being accepted.
> >
> > Regards,
> > Jim Quinlan
> > Broadcom STB/CM
> >
> > >
> > > - Mani
> > >
> > > > If this flag specifies
> > > > > whether the PCIe controller supports L1SS or not, then it is fine but apparantly
> > > > > this specifies that all downstream devices are L1SS capable which you cannot
> > > > > guarantee unless you poke into their LNKCAP during runtime.
> > > > Not true at all.  This setting affects only RC and whatever device is
> > > > connected to its single downstream
> > > > port.
> > > >
> > > > >
> > > > > You should handle this in the driver itself.
> > > >
> > > > The driver has no way of knowing if the PCI subsystem is going from power_save
> > > > to power_supersave or vice-versa -- there is no notification chain for this.  So
> > > > what you say is not currently possible from the driver's perspective.
> > > >
> > > > Perhaps you would be happy if we changed it to "l1ss-support" in the
> > > > spirit of the
> > > > existing "clkreq-support" PCI parameter?
> > > >
> > > > Regards,
> > > > Jim Quinlan
> > > > Broadcom STB/CMi
> > > >
> > > > >
> > > > > - Mani
> > > > >
> > > > > > +    type: boolean
> > > > > > +
> > > > > >    brcm,scb-sizes:
> > > > > >      description: u64 giving the 64bit PCIe memory
> > > > > >        viewport size of a memory controller.  There may be up to
> > > > > > --
> > > > > > 2.17.1
> > > > > >
> > > > >
> > > > > --
> > > > > மணிவண்ணன் சதாசிவம்
> > >
>

Rob Herring (Arm) Aug. 29, 2023, 12:22 p.m. UTC | #7

On Fri, Aug 25, 2023 at 1:45 AM Manivannan Sadhasivam <[e-mail]> wrote:
>
> On Thu, Aug 24, 2023 at 10:55:02AM -0400, Jim Quinlan wrote:
> > On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam <[e-mail]> wrote:
> > >
> > > On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > > > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > > > >
> > > > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > >
> > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > >   CLKREQ# modes:
> > > > > >
> > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > >
> > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > >   this mode (e.g. policy==powersupersave).
> > > > > >
> > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > >   upstream driver implementation that follows adds more details and
> > > > > >   discerns between (a) and (b).
> > > > > >
> > > > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > > > ---
> > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > >  1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > >
> > > > > >    aspm-no-l0s: true
> > > > > >
> > > > > > +  brcm,enable-l1ss:
> > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > > +      using a mini-card connector, this mode may not meet the
> > > > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > > >
> > > > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > > > the hardware capability and not system/OS behavior.
> > > >
> > > > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > > > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > > > configured for L1SS.
> > > > It compensates for a problem in the PCIe core: the HW is not capable
> > > > of dynamically
> > > > switching between ASPM modes powersave and superpowersave.  I am actively
> > > > advocating for our HW to change but that will take years.
> > > >
> > >
> > > Okay, then I would say that the property name and commit message were a bit
> > > misleading.
> > >
> > > I had briefly gone through the driver patch now. As per my understanding, you
> > > have 2 modes in hw:
> > >
> > > 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> > > the device (driving high) when the link is in L1.
> > >
> > > 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.
> >
> > No, there are three, as enumerated in the commit message of
> > "PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device"
> >
>
> Yeah, another one is refclk always on.
>
> > >
> > > Till now the driver only supported Clock PM through mode (1) but for supporting
> > > L1SS you need to enable mode (2). And you are using this property to select mode
> > > (2) when the L1SS supported devices are connected to the slot. Also, by
> > > selecting this mode, you are loosing the benefit of mode (1) as both are not
> > > compatible.
> > >
> > > My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> > > most of the recent devices should support L1SS (ofc there are exemptions).
> > The disadvantage of this, as stated by the PCIe core HW designer, was
> > that "doing so means
> > we cannot enable the Cock Power Management capability since it may run afoul of
> > the Tclron requirement."
> >
>
> Ok.
>
> > I will attempt to press him on exactly what configurations and form
> > factors would be
> > vulnerable to this -- he was so convinced that it was a danger that he
> > is against
> > making L1SS mode the default.
> >
>
> Hmm. After looking at this problem in detail, it looks to me that you can still
> use DT but not with the property you proposed. Since these are hardware modes,
> you can have a single DT property that specifies the mode that the driver can
> use to configure the hw. It is similar to "phy-mode" property we have for the
> network controllers.
>
> So you should have the property defined as below in binding:
>
> brcm,clkreq-mode:
>   $ref: /schemas/types.yaml#/definitions/uint32
>   enum: [ 0, 1, 2 ]

Is this really Broadcom specific?

Rob

Manivannan Sadhasivam Aug. 29, 2023, 2:46 p.m. UTC | #8

On Tue, Aug 29, 2023 at 07:22:18AM -0500, Rob Herring wrote:
> On Fri, Aug 25, 2023 at 1:45 AM Manivannan Sadhasivam <[e-mail]> wrote:
> >
> > On Thu, Aug 24, 2023 at 10:55:02AM -0400, Jim Quinlan wrote:
> > > On Wed, Aug 23, 2023 at 2:17 PM Manivannan Sadhasivam <[e-mail]> wrote:
> > > >
> > > > On Wed, Aug 23, 2023 at 09:09:25AM -0400, Jim Quinlan wrote:
> > > > > On Wed, Aug 23, 2023 at 3:43 AM Manivannan Sadhasivam <[e-mail]> wrote:
> > > > > >
> > > > > > On Mon, May 08, 2023 at 06:01:21PM -0400, Jim Quinlan wrote:
> > > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > > >
> > > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > > >   CLKREQ# modes:
> > > > > > >
> > > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > > >
> > > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > > >   this mode (e.g. policy==powersupersave).
> > > > > > >
> > > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > > >   upstream driver implementation that follows adds more details and
> > > > > > >   discerns between (a) and (b).
> > > > > > >
> > > > > > > Signed-off-by: Jim Quinlan <[e-mail]>
> > > > > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > > > > ---
> > > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > > >  1 file changed, 9 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > > >
> > > > > > >    aspm-no-l0s: true
> > > > > > >
> > > > > > > +  brcm,enable-l1ss:
> > > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > > > +      using a mini-card connector, this mode may not meet the
> > > > > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > > > >
> > > > > > As Lorenzo said, this property doesn't belong in DT. DT is supposed to specify
> > > > > > the hardware capability and not system/OS behavior.
> > > > >
> > > > > The "brcm,enable-l1ss" does NOT configure the OS behavior.
> > > > > It sets or not a mode bit to enable l1SS HW, whether or not the OS is
> > > > > configured for L1SS.
> > > > > It compensates for a problem in the PCIe core: the HW is not capable
> > > > > of dynamically
> > > > > switching between ASPM modes powersave and superpowersave.  I am actively
> > > > > advocating for our HW to change but that will take years.
> > > > >
> > > >
> > > > Okay, then I would say that the property name and commit message were a bit
> > > > misleading.
> > > >
> > > > I had briefly gone through the driver patch now. As per my understanding, you
> > > > have 2 modes in hw:
> > > >
> > > > 1. Clock PM - Refclk will be turned off by the host if CLKREQ# is deasserted by
> > > > the device (driving high) when the link is in L1.
> > > >
> > > > 2. L1SS - CLKREQ# will be used to decide L1SS entry and exit by the host.
> > >
> > > No, there are three, as enumerated in the commit message of
> > > "PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device"
> > >
> >
> > Yeah, another one is refclk always on.
> >
> > > >
> > > > Till now the driver only supported Clock PM through mode (1) but for supporting
> > > > L1SS you need to enable mode (2). And you are using this property to select mode
> > > > (2) when the L1SS supported devices are connected to the slot. Also, by
> > > > selecting this mode, you are loosing the benefit of mode (1) as both are not
> > > > compatible.
> > > >
> > > > My suggestion would be to just drop mode (1) and use mode (2) in the driver as
> > > > most of the recent devices should support L1SS (ofc there are exemptions).
> > > The disadvantage of this, as stated by the PCIe core HW designer, was
> > > that "doing so means
> > > we cannot enable the Cock Power Management capability since it may run afoul of
> > > the Tclron requirement."
> > >
> >
> > Ok.
> >
> > > I will attempt to press him on exactly what configurations and form
> > > factors would be
> > > vulnerable to this -- he was so convinced that it was a danger that he
> > > is against
> > > making L1SS mode the default.
> > >
> >
> > Hmm. After looking at this problem in detail, it looks to me that you can still
> > use DT but not with the property you proposed. Since these are hardware modes,
> > you can have a single DT property that specifies the mode that the driver can
> > use to configure the hw. It is similar to "phy-mode" property we have for the
> > network controllers.
> >
> > So you should have the property defined as below in binding:
> >
> > brcm,clkreq-mode:
> >   $ref: /schemas/types.yaml#/definitions/uint32
> >   enum: [ 0, 1, 2 ]
> 
> Is this really Broadcom specific?
> 

AFAIU, rest of the controllers do not have issues supporting Clock PM and L1SS
in hw. Neither does the spec define any incompatibility. So to me, this looks
like Broadcom specific.

- Mani

> Rob

Patch

diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 7e15aae7d69e..8b61c2179608 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -64,6 +64,15 @@  properties:
 
   aspm-no-l0s: true
 
+  brcm,enable-l1ss:
+    description: Indicates that PCIe L1SS power savings
+      are desired, the downstream device is L1SS-capable, and the
+      OS has been configured to enable this mode.  For boards
+      using a mini-card connector, this mode may not meet the
+      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
+      of the PCI Express Mini CEM 2.0 specification.
+    type: boolean
+
   brcm,scb-sizes:
     description: u64 giving the 64bit PCIe memory
       viewport size of a memory controller.  There may be up to