[v2,1/1] PCI: layerscape-ep: set 64-bit DMA mask

Commit Message

Frank Li Sept. 22, 2023, 4:28 a.m. UTC

From: Guanhua Gao <[e-mail]>

Set DMA mask and coherent DMA mask to enable 64-bit addressing.

Signed-off-by: Guanhua Gao <[e-mail]>
Signed-off-by: Hou Zhiqiang <[e-mail]>
Signed-off-by: Frank Li <[e-mail]>
---

Notes:
    change from v1 to v2
    - Remove 32bit DMA mask set.

 drivers/pci/controller/dwc/pci-layerscape-ep.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Christoph Hellwig Sept. 26, 2023, 7:27 a.m. UTC | #1

> +	/* set 64-bit DMA mask and coherent DMA mask */
> +	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));

The comment is a bit silly :)

> +	if (ret)
> +		return ret;

Also no need to check the return value when setting a 64-bit mask,
but I guess it desn't hurt here.

Frank Li Sept. 26, 2023, 2 p.m. UTC | #2

On Tue, Sep 26, 2023 at 12:27:32AM -0700, Christoph Hellwig wrote:
> > +	/* set 64-bit DMA mask and coherent DMA mask */
> > +	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> 
> The comment is a bit silly :)
> 
> > +	if (ret)
> > +		return ret;
> 
> Also no need to check the return value when setting a 64-bit mask,
> but I guess it desn't hurt here.
> 

You are right, let me remove check.

Patch

diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
index de4c1758a6c33..026bf08611e13 100644
--- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
+++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
@@ -249,6 +249,11 @@  static int __init ls_pcie_ep_probe(struct platform_device *pdev)
 
 	pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
 
+	/* set 64-bit DMA mask and coherent DMA mask */
+	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
+	if (ret)
+		return ret;
+
 	platform_set_drvdata(pdev, pcie);
 
 	ret = dw_pcie_ep_init(&pci->ep);