| Message ID | 20230922172449.work.906-kees@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Batch 1: Annotate structs with __counted_by | expand |
On Fri, Sep 22, 2023 at 10:28:42AM -0700, Kees Cook wrote: > This is the batch 1 of patches touching netdev for preparing for > the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by to structs that would > benefit from the annotation. > > Since the element count member must be set before accessing the annotated > flexible array member, some patches also move the member's initialization > earlier. (These are noted in the individual patches.) Hi, just checking on this batch of changes. Is it possible to take the 1-13 subset: > Kees Cook (14): > ipv4: Annotate struct fib_info with __counted_by > ipv4/igmp: Annotate struct ip_sf_socklist with __counted_by > ipv6: Annotate struct ip6_sf_socklist with __counted_by > net: hns: Annotate struct ppe_common_cb with __counted_by > net: enetc: Annotate struct enetc_int_vector with __counted_by > net: hisilicon: Annotate struct rcb_common_cb with __counted_by > net: mana: Annotate struct mana_rxq with __counted_by > net: ipa: Annotate struct ipa_power with __counted_by > net: mana: Annotate struct hwc_dma_buf with __counted_by > net: openvswitch: Annotate struct dp_meter_instance with __counted_by > net: enetc: Annotate struct enetc_psfp_gate with __counted_by > net: openvswitch: Annotate struct dp_meter with __counted_by > net: tulip: Annotate struct mediatable with __counted_by I'll respin 14 and add it to the next batch: > net: sched: Annotate struct tc_pedit with __counted_by After these 13, there are 32 more patches to various drivers and protocols... Thanks! -Kees
On Wed, 27 Sep 2023 08:57:36 -0700 Kees Cook wrote: > > Since the element count member must be set before accessing the annotated > > flexible array member, some patches also move the member's initialization > > earlier. (These are noted in the individual patches.) > > Hi, just checking on this batch of changes. Is it possible to take the > 1-13 subset: On it, sorry for the delay.
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 22 Sep 2023 10:28:42 -0700 you wrote: > Hi, > > This is the batch 1 of patches touching netdev for preparing for > the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > [...] Here is the summary with links: - [01/14] ipv4: Annotate struct fib_info with __counted_by https://git.kernel.org/netdev/net-next/c/5b98fd5dc1e3 - [02/14] ipv4/igmp: Annotate struct ip_sf_socklist with __counted_by https://git.kernel.org/netdev/net-next/c/210d4e9c732f - [03/14] ipv6: Annotate struct ip6_sf_socklist with __counted_by https://git.kernel.org/netdev/net-next/c/5d22b6528073 - [04/14] net: hns: Annotate struct ppe_common_cb with __counted_by https://git.kernel.org/netdev/net-next/c/5b829c8460ae - [05/14] net: enetc: Annotate struct enetc_int_vector with __counted_by https://git.kernel.org/netdev/net-next/c/dd8e215ea9a8 - [06/14] net: hisilicon: Annotate struct rcb_common_cb with __counted_by https://git.kernel.org/netdev/net-next/c/2290999d278e - [07/14] net: mana: Annotate struct mana_rxq with __counted_by https://git.kernel.org/netdev/net-next/c/a3d7a1209bbb - [08/14] net: ipa: Annotate struct ipa_power with __counted_by https://git.kernel.org/netdev/net-next/c/20551ee45d7d - [09/14] net: mana: Annotate struct hwc_dma_buf with __counted_by https://git.kernel.org/netdev/net-next/c/59656519763d - [10/14] net: openvswitch: Annotate struct dp_meter_instance with __counted_by https://git.kernel.org/netdev/net-next/c/e7b34822fa4d - [11/14] net: enetc: Annotate struct enetc_psfp_gate with __counted_by https://git.kernel.org/netdev/net-next/c/93bc6ab6b19d - [12/14] net: openvswitch: Annotate struct dp_meter with __counted_by https://git.kernel.org/netdev/net-next/c/16ae53d80c00 - [13/14] net: tulip: Annotate struct mediatable with __counted_by https://git.kernel.org/netdev/net-next/c/0d01cfe5aaaf - [14/14] net: sched: Annotate struct tc_pedit with __counted_by (no matching commit) You are awesome, thank you!
On Mon, Oct 02, 2023 at 11:26:35AM -0700, Jakub Kicinski wrote: > On Wed, 27 Sep 2023 08:57:36 -0700 Kees Cook wrote: > > > Since the element count member must be set before accessing the annotated > > > flexible array member, some patches also move the member's initialization > > > earlier. (These are noted in the individual patches.) > > > > Hi, just checking on this batch of changes. Is it possible to take the > > 1-13 subset: > > On it, sorry for the delay. No worries; thanks for grabbing them!