| Message ID | 20231002-net-wifpts-dpll_mode_get-v1-0-a356a16413cf@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix a couple recent instances of -Wincompatible-function-pointer-types-strict from ->mode_get() implementations | expand |
On Mon, Oct 02, 2023 at 01:55:19PM -0700, Nathan Chancellor wrote: > Hi all, > > This series fixes a couple of instances of > -Wincompatible-function-pointer-types-strict that were introduced by a > recent series that added a new type of ops, struct dpll_device_ops, > along with implementations of the callback ->mode_get() that had a > mismatched mode type. > > This warning is not currently enabled for any build but I am planning on > submitting a patch to add it to W=1 to prevent new instances of the > warning from popping up while we try and fix the existing instances in > other drivers. > > This series is based on current net-next but if they need to go into > individual maintainer trees, please feel free to take the patches > individually. > > Cheers, > Nathan > > --- > Nathan Chancellor (2): > ptp: Fix type of mode parameter in ptp_ocp_dpll_mode_get() > mlx5: Fix type of mode parameter in mlx5_dpll_device_mode_get() For series, Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 02 Oct 2023 13:55:19 -0700 you wrote: > Hi all, > > This series fixes a couple of instances of > -Wincompatible-function-pointer-types-strict that were introduced by a > recent series that added a new type of ops, struct dpll_device_ops, > along with implementations of the callback ->mode_get() that had a > mismatched mode type. > > [...] Here is the summary with links: - [1/2] ptp: Fix type of mode parameter in ptp_ocp_dpll_mode_get() https://git.kernel.org/netdev/net-next/c/26cc115d590c - [2/2] mlx5: Fix type of mode parameter in mlx5_dpll_device_mode_get() https://git.kernel.org/netdev/net-next/c/f4ecb3d44a11 You are awesome, thank you!
Hi all, This series fixes a couple of instances of -Wincompatible-function-pointer-types-strict that were introduced by a recent series that added a new type of ops, struct dpll_device_ops, along with implementations of the callback ->mode_get() that had a mismatched mode type. This warning is not currently enabled for any build but I am planning on submitting a patch to add it to W=1 to prevent new instances of the warning from popping up while we try and fix the existing instances in other drivers. This series is based on current net-next but if they need to go into individual maintainer trees, please feel free to take the patches individually. Cheers, Nathan --- Nathan Chancellor (2): ptp: Fix type of mode parameter in ptp_ocp_dpll_mode_get() mlx5: Fix type of mode parameter in mlx5_dpll_device_mode_get() drivers/net/ethernet/mellanox/mlx5/core/dpll.c | 4 ++-- drivers/ptp/ptp_ocp.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- base-commit: 35766690d675f63c111afa0a2f5286b74a5b5cc2 change-id: 20231002-net-wifpts-dpll_mode_get-268efa3df19b Best regards,