| Message ID | 20231010021006.6061-6-pkshih@realtek.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: rtw89: handle EHT rate | expand |
Ping-Ke Shih <pkshih@realtek.com> writes: > Define EHT U-SIG bandwidth used by radiotap according to Table 36-28 > "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0). > > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> > --- > v2: > - correct commit message about the source of bandwidth definition > of EHT U-SIG suggested by Johannes > --- > include/net/ieee80211_radiotap.h | 6 ++++++ > 1 file changed, 6 insertions(+) This is nitpicking but in general it's good to have the patches touching files outside of drivers/net/wireless in the beginning of the patchset to make them more visible. No need to resend because of this, just a small tip.
> -----Original Message----- > From: Kalle Valo <kvalo@kernel.org> > Sent: Tuesday, October 10, 2023 2:20 PM > To: Ping-Ke Shih <pkshih@realtek.com> > Cc: johannes@sipsolutions.net; linux-wireless@vger.kernel.org > Subject: Re: [PATCH v2 5/6] wifi: radiotap: add bandwidth definition of EHT U-SIG > > Ping-Ke Shih <pkshih@realtek.com> writes: > > > Define EHT U-SIG bandwidth used by radiotap according to Table 36-28 > > "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0). > > > > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> > > --- > > v2: > > - correct commit message about the source of bandwidth definition > > of EHT U-SIG suggested by Johannes > > --- > > include/net/ieee80211_radiotap.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > This is nitpicking but in general it's good to have the patches touching > files outside of drivers/net/wireless in the beginning of the patchset > to make them more visible. No need to resend because of this, just a > small tip. > Got it. I will pay attention to it next time. Ping-Ke
diff --git a/include/net/ieee80211_radiotap.h b/include/net/ieee80211_radiotap.h index 2338f8d2a8b3..925bac726a92 100644 --- a/include/net/ieee80211_radiotap.h +++ b/include/net/ieee80211_radiotap.h @@ -539,6 +539,12 @@ enum ieee80211_radiotap_eht_usig_common { IEEE80211_RADIOTAP_EHT_USIG_COMMON_VALIDATE_BITS_OK = 0x00000080, IEEE80211_RADIOTAP_EHT_USIG_COMMON_PHY_VER = 0x00007000, IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW = 0x00038000, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_20MHZ = 0, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_40MHZ = 1, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_80MHZ = 2, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_160MHZ = 3, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_320MHZ_1 = 4, + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_320MHZ_2 = 5, IEEE80211_RADIOTAP_EHT_USIG_COMMON_UL_DL = 0x00040000, IEEE80211_RADIOTAP_EHT_USIG_COMMON_BSS_COLOR = 0x01f80000, IEEE80211_RADIOTAP_EHT_USIG_COMMON_TXOP = 0xfe000000,
Define EHT U-SIG bandwidth used by radiotap according to Table 36-28 "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0). Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> --- v2: - correct commit message about the source of bandwidth definition of EHT U-SIG suggested by Johannes --- include/net/ieee80211_radiotap.h | 6 ++++++ 1 file changed, 6 insertions(+)