| Message ID | 20231023084050.55230-1-tstruk@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | p2pdma: remove redundant goto | expand |
On 2023-10-23 02:40, Tadeusz Struk wrote: > Remove redundant goto in pci_alloc_p2pmem() > > Signed-off-by: Tadeusz Struk <tstruk@gmail.com> Makes sense to me. Reviewed-by: Logan Gunthorpe <logang@deltatee.com> Logan > --- > drivers/pci/p2pdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index fa7370f9561a..a7776315996c 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size) > if (unlikely(!percpu_ref_tryget_live_rcu(ref))) { > gen_pool_free(p2pdma->pool, (unsigned long) ret, size); > ret = NULL; > - goto out; > } > out: > rcu_read_unlock();
On Mon, Oct 23, 2023 at 10:40:50AM +0200, Tadeusz Struk wrote: > Remove redundant goto in pci_alloc_p2pmem() > > Signed-off-by: Tadeusz Struk <tstruk@gmail.com> Thanks, applied to pci/p2pdma with Logan's reviewed-by for v6.7. Updated the subject line to: PCI/P2PDMA: Remove redundant goto so it matches the history. > --- > drivers/pci/p2pdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index fa7370f9561a..a7776315996c 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size) > if (unlikely(!percpu_ref_tryget_live_rcu(ref))) { > gen_pool_free(p2pdma->pool, (unsigned long) ret, size); > ret = NULL; > - goto out; > } > out: > rcu_read_unlock(); > -- > 2.41.0
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c index fa7370f9561a..a7776315996c 100644 --- a/drivers/pci/p2pdma.c +++ b/drivers/pci/p2pdma.c @@ -837,7 +837,6 @@ void *pci_alloc_p2pmem(struct pci_dev *pdev, size_t size) if (unlikely(!percpu_ref_tryget_live_rcu(ref))) { gen_pool_free(p2pdma->pool, (unsigned long) ret, size); ret = NULL; - goto out; } out: rcu_read_unlock();
Remove redundant goto in pci_alloc_p2pmem() Signed-off-by: Tadeusz Struk <tstruk@gmail.com> --- drivers/pci/p2pdma.c | 1 - 1 file changed, 1 deletion(-)