[v1,0/3] arm64: qcom: sa8775p: add cache coherency support for SA8775P

Message

Mrinmay Sarkar Oct. 31, 2023, 3:46 p.m. UTC

This series is to enable cache snooping logic in both RC and EP
driver and add the "dma-coherent" property in dtsi to support
cache coherency in SA8775P.

To verify this series we required [1]

[1] https://lore.kernel.org/all/[e-mail]/

Mrinmay Sarkar (3):
  PCI: qcom: Enable cache coherency for SA8775P RC
  PCI: qcom-ep: Enable cache coherency for SA8775P EP
  arm64: dts: qcom: sa8775p: Mark PCIe controller as cache coherent

 arch/arm64/boot/dts/qcom/sa8775p.dtsi     |  2 ++
 drivers/pci/controller/dwc/pcie-qcom-ep.c |  8 ++++++++
 drivers/pci/controller/dwc/pcie-qcom.c    | 11 +++++++++++
 3 files changed, 21 insertions(+)

Comments

Manivannan Sadhasivam Oct. 31, 2023, 4:57 p.m. UTC | #1

On Tue, Oct 31, 2023 at 09:16:23PM +0530, Mrinmay Sarkar wrote:
> This series is to enable cache snooping logic in both RC and EP
> driver and add the "dma-coherent" property in dtsi to support
> cache coherency in SA8775P.
> 

You need to explain why cache snooping needs to be enabled _only_ on SA8775P and
not on other platforms, here and also in patch description.

Cover letter is not just meant for describing the changes you are submitting,
you should also put as much info required for the reviewers/maintainers to get
motivation behind the series.

- Mani

> To verify this series we required [1]
> 
> [1] https://lore.kernel.org/all/[e-mail]/
> 
> Mrinmay Sarkar (3):
>   PCI: qcom: Enable cache coherency for SA8775P RC
>   PCI: qcom-ep: Enable cache coherency for SA8775P EP
>   arm64: dts: qcom: sa8775p: Mark PCIe controller as cache coherent
> 
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi     |  2 ++
>  drivers/pci/controller/dwc/pcie-qcom-ep.c |  8 ++++++++
>  drivers/pci/controller/dwc/pcie-qcom.c    | 11 +++++++++++
>  3 files changed, 21 insertions(+)
> 
> -- 
> 2.7.4
>