| Message ID | 7de6e939dc75ee08f05bf1ee73253aa7eeccf28e.1699869649.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 695bfba7ca781dd41b5225148cc8cebd74c553c2 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps | expand |
Lorenzo Bianconi <lorenzo@kernel.org> writes: > Use iftype for interface type switch in mt7925_init_he_caps routine > > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver > for mt7925 chips") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> What issue does this fix? In other words, what are the user visible symptoms?
> Lorenzo Bianconi <lorenzo@kernel.org> writes: > > > Use iftype for interface type switch in mt7925_init_he_caps routine > > > > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver > > for mt7925 chips") > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > What issue does this fix? In other words, what are the user visible > symptoms? Since we are using i (equal to 8 after the for loop above) instead of iftype we are missing some HE capabilities exposed to userspace (we are hitting the switch default branch). I agree this is something not so harmful and we can apply this fix to Felix's tree instead, up to you. Regards, Lorenzo > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Lorenzo Bianconi <lorenzo@kernel.org> writes: >> Lorenzo Bianconi <lorenzo@kernel.org> writes: >> >> > Use iftype for interface type switch in mt7925_init_he_caps routine >> > >> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver >> > for mt7925 chips") >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> >> >> What issue does this fix? In other words, what are the user visible >> symptoms? > > Since we are using i (equal to 8 after the for loop above) instead of iftype > we are missing some HE capabilities exposed to userspace (we are hitting the > switch default branch). I agree this is something not so harmful and we can > apply this fix to Felix's tree instead, up to you. No no, this is fine for the wireless tree :) I just want to document if this is fixing a real issue which users can see or just a theoretical fix you found during code review. It makes handling fixes a lot easier when we have this documented in the commit message. No need to resend because of this, I can update the commit log if you tell me what to add.
> Lorenzo Bianconi <lorenzo@kernel.org> writes: > > >> Lorenzo Bianconi <lorenzo@kernel.org> writes: > >> > >> > Use iftype for interface type switch in mt7925_init_he_caps routine > >> > > >> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver > >> > for mt7925 chips") > >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > >> > >> What issue does this fix? In other words, what are the user visible > >> symptoms? > > > > Since we are using i (equal to 8 after the for loop above) instead of iftype > > we are missing some HE capabilities exposed to userspace (we are hitting the > > switch default branch). I agree this is something not so harmful and we can > > apply this fix to Felix's tree instead, up to you. > > No no, this is fine for the wireless tree :) I just want to document if > this is fixing a real issue which users can see or just a theoretical > fix you found during code review. It makes handling fixes a lot easier > when we have this documented in the commit message. > > No need to resend because of this, I can update the commit log if you > tell me what to add. ack, thx. I will more 'verbose' next time :) Regards, Lorenzo > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Lorenzo Bianconi <lorenzo@kernel.org> writes: >> Lorenzo Bianconi <lorenzo@kernel.org> writes: >> >> >> Lorenzo Bianconi <lorenzo@kernel.org> writes: >> >> >> >> > Use iftype for interface type switch in mt7925_init_he_caps routine >> >> > >> >> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver >> >> > for mt7925 chips") >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> >> >> >> >> What issue does this fix? In other words, what are the user visible >> >> symptoms? >> > >> > Since we are using i (equal to 8 after the for loop above) instead of iftype >> > we are missing some HE capabilities exposed to userspace (we are hitting the >> > switch default branch). I agree this is something not so harmful and we can >> > apply this fix to Felix's tree instead, up to you. >> >> No no, this is fine for the wireless tree :) I just want to document if >> this is fixing a real issue which users can see or just a theoretical >> fix you found during code review. It makes handling fixes a lot easier >> when we have this documented in the commit message. >> >> No need to resend because of this, I can update the commit log if you >> tell me what to add. > > ack, thx. I will more 'verbose' next time :) But what I should add to the commit message? Is this just a theoretical fix you found during code review? Or was there a bug report which prompted you to fix this?
> Lorenzo Bianconi <lorenzo@kernel.org> writes: > > >> Lorenzo Bianconi <lorenzo@kernel.org> writes: > >> > >> >> Lorenzo Bianconi <lorenzo@kernel.org> writes: > >> >> > >> >> > Use iftype for interface type switch in mt7925_init_he_caps routine > >> >> > > >> >> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver > >> >> > for mt7925 chips") > >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > >> >> > >> >> What issue does this fix? In other words, what are the user visible > >> >> symptoms? > >> > > >> > Since we are using i (equal to 8 after the for loop above) instead of iftype > >> > we are missing some HE capabilities exposed to userspace (we are hitting the > >> > switch default branch). I agree this is something not so harmful and we can > >> > apply this fix to Felix's tree instead, up to you. > >> > >> No no, this is fine for the wireless tree :) I just want to document if > >> this is fixing a real issue which users can see or just a theoretical > >> fix you found during code review. It makes handling fixes a lot easier > >> when we have this documented in the commit message. > >> > >> No need to resend because of this, I can update the commit log if you > >> tell me what to add. > > > > ack, thx. I will more 'verbose' next time :) > > But what I should add to the commit message? Is this just a theoretical > fix you found during code review? Or was there a bug report which > prompted you to fix this? I have just spot the bug during code review but it seems it is even reported in coverity with id 1549845. Regards, Lorenzo > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Lorenzo Bianconi <lorenzo@kernel.org> wrote: > Use iftype for interface type switch in mt7925_init_he_caps routine. This found > during code review but later Coverity reported this with id 1549845. > > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Patch applied to wireless.git, thanks. 695bfba7ca78 wifi: mt76: mt7925: fix typo in mt7925_init_he_caps
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net/wireless/mediatek/mt76/mt7925/main.c index 15c2fb0bcb1b..aa918b9b0469 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -14,7 +14,7 @@ static void mt7925_init_he_caps(struct mt792x_phy *phy, enum nl80211_band band, struct ieee80211_sband_iftype_data *data, - enum nl80211_iftype iftype) + enum nl80211_iftype iftype) { struct ieee80211_sta_he_cap *he_cap = &data->he_cap; struct ieee80211_he_cap_elem *he_cap_elem = &he_cap->he_cap_elem; @@ -53,7 +53,7 @@ mt7925_init_he_caps(struct mt792x_phy *phy, enum nl80211_band band, IEEE80211_HE_PHY_CAP2_UL_MU_FULL_MU_MIMO | IEEE80211_HE_PHY_CAP2_UL_MU_PARTIAL_MU_MIMO; - switch (i) { + switch (iftype) { case NL80211_IFTYPE_AP: he_cap_elem->mac_cap_info[2] |= IEEE80211_HE_MAC_CAP2_BSR;
Use iftype for interface type switch in mt7925_init_he_caps routine Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)