| Message ID | 20231115092328.1048103-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a85198c9f068baeef6d4a56c389b11a2035a8ea3 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | mwifiex: remove some useless code | expand |
On Wed, Nov 15, 2023 at 05:23:29PM +0800, Su Hui wrote: > Clang static analyzer complains that value stored to 'priv' is never read. > 'priv' is useless, so remove it to save space. > > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 8 -------- > 1 file changed, 8 deletions(-) Acked-by: Brian Norris <briannorris@chromium.org>
Su Hui <suhui@nfschina.com> wrote: > Clang static analyzer complains that value stored to 'priv' is never read. > 'priv' is useless, so remove it to save space. > > Signed-off-by: Su Hui <suhui@nfschina.com> > Acked-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-next.git, thanks. a85198c9f068 wifi: mwifiex: mwifiex_process_sleep_confirm_resp(): remove unused priv variable
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c index 3756aa247e77..9eff29a25544 100644 --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c @@ -1244,8 +1244,6 @@ mwifiex_process_sleep_confirm_resp(struct mwifiex_adapter *adapter, u8 *pbuf, u32 upld_len) { struct host_cmd_ds_command *cmd = (struct host_cmd_ds_command *) pbuf; - struct mwifiex_private *priv = - mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY); uint16_t result = le16_to_cpu(cmd->result); uint16_t command = le16_to_cpu(cmd->command); uint16_t seq_num = le16_to_cpu(cmd->seq_num); @@ -1260,12 +1258,6 @@ mwifiex_process_sleep_confirm_resp(struct mwifiex_adapter *adapter, "cmd: CMD_RESP: 0x%x, result %d, len %d, seqno 0x%x\n", command, result, le16_to_cpu(cmd->size), seq_num); - /* Get BSS number and corresponding priv */ - priv = mwifiex_get_priv_by_id(adapter, HostCmd_GET_BSS_NO(seq_num), - HostCmd_GET_BSS_TYPE(seq_num)); - if (!priv) - priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY); - /* Update sequence number */ seq_num = HostCmd_GET_SEQ_NO(seq_num); /* Clear RET_BIT from HostCmd */
Clang static analyzer complains that value stored to 'priv' is never read. 'priv' is useless, so remove it to save space. Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 8 -------- 1 file changed, 8 deletions(-)