| Message ID | 20231206034920.1037449-2-quic_periyasa@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eaf9f17b861b665a0bc8dff120ae3c9028642e6d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: Refactor MAC alloc/destroy/un/register helper functions | expand |
On 12/5/2023 7:49 PM, Karthikeyan Periyasamy wrote: > Currently, the data path pdev pre alloc and mac allocate are called > separately from the core start procedure. The data path pdev pre alloc > can be called from the mac allocate procedure itself since initialization > related to pdev happens in the mac allocate procedure. So move the caller > of DP pdev pre alloc from the core start procedure to the mac allocate > procedure. This change helps in the future to easily decouple the mac > allocate procedure from core start handling in order to support MLO in > multi chip. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> wrote: > Currently, the data path pdev pre alloc and mac allocate are called > separately from the core start procedure. The data path pdev pre alloc > can be called from the mac allocate procedure itself since initialization > related to pdev happens in the mac allocate procedure. So move the caller > of DP pdev pre alloc from the core start procedure to the mac allocate > procedure. This change helps in the future to easily decouple the mac > allocate procedure from core start handling in order to support MLO in > multi chip. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 4 patches applied to ath-next branch of ath.git, thanks. eaf9f17b861b wifi: ath12k: relocate ath12k_dp_pdev_pre_alloc() call 8a742a79f90e wifi: ath12k: refactor ath12k_mac_allocate() and ath12k_mac_destroy() d2b7a6e5fa1c wifi: ath12k: refactor ath12k_mac_setup_channels_rates() d786c9f5fe34 wifi: ath12k: refactor ath12k_mac_register() and ath12k_mac_unregister()
diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c index 6c01b282fcd3..6f634b57dde8 100644 --- a/drivers/net/wireless/ath/ath12k/core.c +++ b/drivers/net/wireless/ath/ath12k/core.c @@ -592,8 +592,6 @@ static int ath12k_core_start(struct ath12k_base *ab, ath12k_dp_cc_config(ab); - ath12k_dp_pdev_pre_alloc(ab); - ret = ath12k_dp_rx_pdev_reo_setup(ab); if (ret) { ath12k_err(ab, "failed to initialize reo destination rings: %d\n", ret); diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 88cec54c6c2e..49d56f5d8896 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -7667,6 +7667,8 @@ int ath12k_mac_allocate(struct ath12k_base *ab) clear_bit(ATH12K_FLAG_MONITOR_ENABLED, &ar->monitor_flags); } + ath12k_dp_pdev_pre_alloc(ab); + return 0; err_free_mac:
Currently, the data path pdev pre alloc and mac allocate are called separately from the core start procedure. The data path pdev pre alloc can be called from the mac allocate procedure itself since initialization related to pdev happens in the mac allocate procedure. So move the caller of DP pdev pre alloc from the core start procedure to the mac allocate procedure. This change helps in the future to easily decouple the mac allocate procedure from core start handling in order to support MLO in multi chip. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> --- drivers/net/wireless/ath/ath12k/core.c | 2 -- drivers/net/wireless/ath/ath12k/mac.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)