| Message ID | 20231206141759.5430-1-quic_lingbok@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7133b072dfbfac8763ffb017642c9c894894c50d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: ath12k: fix the issue that the multicast/broadcast indicator is not read correctly for WCN7850 | expand |
On 12/6/2023 6:17 AM, Lingbo Kong wrote: > We observe some packets are discarded in ieee80211_rx_handlers_result > function for WCN7850. This is because the way to get multicast/broadcast > indicator with RX_MSDU_END_INFO5_DA_IS_MCBC & info5 is incorrect. It should > use RX_MSDU_END_INFO13_MCAST_BCAST & info13 to get multicast/broadcast > indicator. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Lingbo Kong <quic_lingbok@quicinc.com> wrote: > We observe some packets are discarded in ieee80211_rx_handlers_result > function for WCN7850. This is because the way to get multicast/broadcast > indicator with RX_MSDU_END_INFO5_DA_IS_MCBC & info5 is incorrect. It should > use RX_MSDU_END_INFO13_MCAST_BCAST & info13 to get multicast/broadcast > indicator. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 7133b072dfbf wifi: ath12k: fix the issue that the multicast/broadcast indicator is not read correctly for WCN7850
diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c index ca6f1d0db31e..a489369d8068 100644 --- a/drivers/net/wireless/ath/ath12k/hal.c +++ b/drivers/net/wireless/ath/ath12k/hal.c @@ -889,8 +889,8 @@ static u8 *ath12k_hw_wcn7850_rx_desc_mpdu_start_addr2(struct hal_rx_desc *desc) static bool ath12k_hw_wcn7850_rx_desc_is_da_mcbc(struct hal_rx_desc *desc) { - return __le16_to_cpu(desc->u.wcn7850.msdu_end.info5) & - RX_MSDU_END_INFO5_DA_IS_MCBC; + return __le32_to_cpu(desc->u.wcn7850.msdu_end.info13) & + RX_MSDU_END_INFO13_MCAST_BCAST; } static void ath12k_hw_wcn7850_rx_desc_get_dot11_hdr(struct hal_rx_desc *desc,
We observe some packets are discarded in ieee80211_rx_handlers_result function for WCN7850. This is because the way to get multicast/broadcast indicator with RX_MSDU_END_INFO5_DA_IS_MCBC & info5 is incorrect. It should use RX_MSDU_END_INFO13_MCAST_BCAST & info13 to get multicast/broadcast indicator. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com> --- v2: 1.change __le16_to_cpu to __le32_to_cpu 2.always run ath12k-check drivers/net/wireless/ath/ath12k/hal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 0dbdc9383054fd3ecbcacfeb364aace3db744314