| Message ID | 47a30441242c4d5f0e00555cbddd7783350ff1b2.1702966523.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | misc: pci_endpoint_test: Remove usage of the deprecated ida_simple_xx() API | expand |
On Tue, Dec 19, 2023 at 07:15:37AM +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/misc/pci_endpoint_test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index af519088732d..34124bdce68c 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -860,7 +860,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, > > pci_set_drvdata(pdev, test); > > - id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL); > + id = ida_alloc(&pci_endpoint_test_ida, GFP_KERNEL); > if (id < 0) { > err = id; > dev_err(dev, "Unable to get id\n"); > @@ -907,7 +907,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, > kfree(test->name); > > err_ida_remove: > - ida_simple_remove(&pci_endpoint_test_ida, id); > + ida_free(&pci_endpoint_test_ida, id); > > err_iounmap: > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > @@ -943,7 +943,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) > misc_deregister(&test->miscdev); > kfree(misc_device->name); > kfree(test->name); > - ida_simple_remove(&pci_endpoint_test_ida, id); > + ida_free(&pci_endpoint_test_ida, id); > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > if (test->bar[bar]) > pci_iounmap(pdev, test->bar[bar]); > -- > 2.34.1 >
Hello, > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. Applied to remove-old-api, thank you! [1/1] misc: pci_endpoint_test: Remove usage of the deprecated ida_simple_*() API https://git.kernel.org/pci/pci/c/130f335630b6 Krzysztof
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index af519088732d..34124bdce68c 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -860,7 +860,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, pci_set_drvdata(pdev, test); - id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL); + id = ida_alloc(&pci_endpoint_test_ida, GFP_KERNEL); if (id < 0) { err = id; dev_err(dev, "Unable to get id\n"); @@ -907,7 +907,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, kfree(test->name); err_ida_remove: - ida_simple_remove(&pci_endpoint_test_ida, id); + ida_free(&pci_endpoint_test_ida, id); err_iounmap: for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { @@ -943,7 +943,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) misc_deregister(&test->miscdev); kfree(misc_device->name); kfree(test->name); - ida_simple_remove(&pci_endpoint_test_ida, id); + ida_free(&pci_endpoint_test_ida, id); for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { if (test->bar[bar]) pci_iounmap(pdev, test->bar[bar]);
ida_alloc() and ida_free() should be preferred to the deprecated ida_simple_get() and ida_simple_remove(). This is less verbose. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/misc/pci_endpoint_test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)