[v3,01/21] wifi: rtl8xxxu: remove assignment of priv->vif in rtl8xxxu_bss_info_changed()

Commit Message

Martin Kaistra Dec. 22, 2023, 10:14 a.m. UTC

priv->vif gets already set in rtl8xxxu_add_interface, there is no need
to set it also in rtl8xxxu_bss_info_changed().

Signed-off-by: Martin Kaistra <[e-mail]>
Reviewed-by: Ping-Ke Shih <[e-mail]>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalle Valo Jan. 10, 2024, 2:54 p.m. UTC | #1

Martin Kaistra <[e-mail]> wrote:

> priv->vif gets already set in rtl8xxxu_add_interface, there is no need
> to set it also in rtl8xxxu_bss_info_changed().
> 
> Signed-off-by: Martin Kaistra <[e-mail]>
> Reviewed-by: Ping-Ke Shih <[e-mail]>

21 patches applied to wireless-next.git, thanks.

d55cb6d8a994 wifi: rtl8xxxu: remove assignment of priv->vif in rtl8xxxu_bss_info_changed()
2bbd7d584046 wifi: rtl8xxxu: prepare supporting two virtual interfaces
7f444692cde8 wifi: rtl8xxxu: support setting linktype for both interfaces
a047e46a7b98 wifi: rtl8xxxu: 8188e: convert usage of priv->vif to priv->vifs[0]
00add60cad3c wifi: rtl8xxxu: support setting mac address register for both interfaces
9aa776209ca3 wifi: rtl8xxxu: extend wifi connected check to both interfaces
80fd8687db41 wifi: rtl8xxxu: extend check for matching bssid to both interfaces
f86dd8eaf8da wifi: rtl8xxxu: don't parse CFO, if both interfaces are connected in STA mode
3ff7a05996f9 wifi: rtl8xxxu: support setting bssid register for multiple interfaces
43532c050f8e wifi: rtl8xxxu: support multiple interfaces in set_aifs()
05b22e9b7d84 wifi: rtl8xxxu: support multiple interfaces in update_beacon_work_callback()
6b7663828705 wifi: rtl8xxxu: support multiple interfaces in configure_filter()
3f9baa99f842 wifi: rtl8xxxu: support multiple interfaces in watchdog_callback()
eef55f1545c9 wifi: rtl8xxxu: support multiple interfaces in {add,remove}_interface()
073401c3b6b9 wifi: rtl8xxxu: support multiple interfaces in bss_info_changed()
61fdbd9e2a9d wifi: rtl8xxxu: support multiple interface in start_ap()
5ce0d7e8aee0 wifi: rtl8xxxu: add macids for STA mode
f232e9d91bb8 wifi: rtl8xxxu: remove obsolete priv->vif
b837f78fbffa wifi: rtl8xxxu: add hw crypto support for AP mode
69abad618efd wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent
1cd165adf314 wifi: rtl8xxxu: declare concurrent mode support for 8188f

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 43ee7592bc6e1..2dbed43ef22a5 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5004,7 +5004,6 @@  rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 
 			rtl8xxxu_update_ra_report(rarpt, highest_rate, sgi, bw);
 
-			priv->vif = vif;
 			priv->rssi_level = RTL8XXXU_RATR_STA_INIT;
 
 			priv->fops->update_rate_mask(priv, ramask, 0, sgi,