| Message ID | 20231218085844.2658-1-quic_bqiang@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | wifi: ath11k: add support for 6 GHz station for various modes : LPI, SP and VLP | expand |
Baochen Qiang <quic_bqiang@quicinc.com> writes: > This introduced some new concept: > power type of AP(STANDARD_POWER_AP, INDOOR_AP, VERY_LOW_POWER_AP) > power type of STATION(DEFAULT_CLIENT, SUBORDINATE_CLIENT) > power spectral density(psd) > > This patchset is to implement the new rules for 6 GHz band in > ath11k. > > ath11k parsed the reg rules from new WMI event > WMI_REG_CHAN_LIST_CC_EXT_EVENTID and parse the > transmit power envelope element in beacon of AP > and then set new WMI command WMI_VDEV_SET_TPC_POWER_CMDID > to firmware when connect to 6G AP, also support backward > compatibility with firmware which not support new wmi > cmd WMI_VDEV_SET_TPC_POWER_CMDID. > > v10: > 1. [PATCH 02/12] wifi: ath11k: store cur_regulatory_info for each radio > a. s/muti/multi/ > 2. [PATCH v9 09/12] wifi: ath11k: fill parameters for vdev set tpc power WMI command > a. add idle_ps check when calculating EIRP. I don't see Jeff's ack in patches 1, 11 and 12. Jeff, are you ok with these? I did some changes in the pending branch, below is a some kind of list of the changes. The changed patches are available in the pending branch (tag ath-pending-202401111604): https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=pending multiple patches o whitespace changes, especially adding empty line before after if and for statements (also in other pathches) patch 1 o remove unneeded parenthesis patch 2 o ath11k_reg_reset_info(): invert if check o ath11k_reg_reset_info(), ath11k_reg_handle_chan_list(), ath11k_reg_get_ar_vdev_type(), ath11k_reg_is_world_alpha: move to reg.c, I did also consider renaming these to use ath11k_wmi_ prefix but thought that reg.c is more approriate place for them patch 11 o remove comments from enum wmi_tlv_cmd_id o other cosmetic changes in wmi.h
On 1/11/2024 8:08 AM, Kalle Valo wrote: > Baochen Qiang <quic_bqiang@quicinc.com> writes: > >> This introduced some new concept: >> power type of AP(STANDARD_POWER_AP, INDOOR_AP, VERY_LOW_POWER_AP) >> power type of STATION(DEFAULT_CLIENT, SUBORDINATE_CLIENT) >> power spectral density(psd) >> >> This patchset is to implement the new rules for 6 GHz band in >> ath11k. >> >> ath11k parsed the reg rules from new WMI event >> WMI_REG_CHAN_LIST_CC_EXT_EVENTID and parse the >> transmit power envelope element in beacon of AP >> and then set new WMI command WMI_VDEV_SET_TPC_POWER_CMDID >> to firmware when connect to 6G AP, also support backward >> compatibility with firmware which not support new wmi >> cmd WMI_VDEV_SET_TPC_POWER_CMDID. >> >> v10: >> 1. [PATCH 02/12] wifi: ath11k: store cur_regulatory_info for each radio >> a. s/muti/multi/ >> 2. [PATCH v9 09/12] wifi: ath11k: fill parameters for vdev set tpc power WMI command >> a. add idle_ps check when calculating EIRP. > > I don't see Jeff's ack in patches 1, 11 and 12. Jeff, are you ok with > these? I failed to go back and add my ack after you said you'd make the copyright change locally. > > I did some changes in the pending branch, below is a some kind of list > of the changes. The changed patches are available in the pending branch > (tag ath-pending-202401111604): > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=pending > > multiple patches > > o whitespace changes, especially adding empty line before after if and > for statements (also in other pathches) > > patch 1 > > o remove unneeded parenthesis > > patch 2 > > o ath11k_reg_reset_info(): invert if check > > o ath11k_reg_reset_info(), ath11k_reg_handle_chan_list(), > ath11k_reg_get_ar_vdev_type(), ath11k_reg_is_world_alpha: > move to reg.c, I did also consider renaming these to use > ath11k_wmi_ prefix but thought that reg.c is more approriate > place for them > > patch 11 > > o remove comments from enum wmi_tlv_cmd_id > > o other cosmetic changes in wmi.h > Reviewed the pending changes Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
This introduced some new concept: power type of AP(STANDARD_POWER_AP, INDOOR_AP, VERY_LOW_POWER_AP) power type of STATION(DEFAULT_CLIENT, SUBORDINATE_CLIENT) power spectral density(psd) This patchset is to implement the new rules for 6 GHz band in ath11k. ath11k parsed the reg rules from new WMI event WMI_REG_CHAN_LIST_CC_EXT_EVENTID and parse the transmit power envelope element in beacon of AP and then set new WMI command WMI_VDEV_SET_TPC_POWER_CMDID to firmware when connect to 6G AP, also support backward compatibility with firmware which not support new wmi cmd WMI_VDEV_SET_TPC_POWER_CMDID. v10: 1. [PATCH 02/12] wifi: ath11k: store cur_regulatory_info for each radio a. s/muti/multi/ 2. [PATCH v9 09/12] wifi: ath11k: fill parameters for vdev set tpc power WMI command a. add idle_ps check when calculating EIRP. v9； 1. [PATCH 02/12] wifi: ath11k: store cur_regulatory_info for each radio: a. add check to soc->reg_info_store in case memory allocation fails. b. remove irrelevant change w.r.t commit message. 2. [PATCH 04/12] wifi: ath11k: update regulatory rules when interface added: a. remove unnecessary parenthesis. b. remove irrelevant change w.r.t commit message. 3. [PATCH 12/12] wifi: ath11k: discard BSS_CHANGED_TXPOWER when EXT_TPC_REG_SUPPORT for 6 GHz drop below patch: a. do not discard txpower setting for BSS_CHANGED_TXPOWER. b. renamed subject as below and update commit log: wifi: ath11k: use WMI_VDEV_SET_TPC_POWER_CMDID when EXT_TPC_REG_SUPPORT for 6 GHz 4. rebased to ToT. v8: add my own s-o-b tag to each patch if not present. Also rebased to ToT. v7: address review comments per Kalle, Jeff and Aditya. Also rebased to ToT. v6: (NOT depends to any patch now) 1. The dependent patch "wifi: cfg80211: save power spectral density(psd) of regulatory rule" has upstream to wireless-next https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/commit/?id=ddd7f45c899f7524bdbe6a32fe4906cde8b07b9b The prerequisite-patch is cherry-pick from wireless-next So add back the other patches in v3 since no dependency to cfg80211 public patch above now. [v3,08/15] wifi: ath11k: save power spectral density(psd) of regulatory rule [v3,09/15] wifi: ath11k: add parse of transmit power envelope element [v3,10/15] wifi: ath11k: save max tx power in vdev start response event from firmware [v3,11/15] wifi: ath11k: fill parameters for vdev_set_tpc_power wmi command [v3,12/15] wifi: ath11k: add WMI_TLV_SERVICE_EXT_TPC_REG_SUPPORT service bit [v3,13/15] wifi: ath11k: discard BSS_CHANGED_TXPOWER when EXT_TPC_REG_SUPPORT for 6 GHz [v3,14/15] wifi: ath11k: add handler for WMI_VDEV_SET_TPC_POWER_CMDID [v3,15/15] wifi: ath11k: send TPC power to firmware for 6 GHz station 2. rename some "6g" to "6ghz" 3. remove "static" for ath11k_reg_ap_pwr_convert() 4. add 20 Mhz check in ath11k_mac_get_eirp_power() 5. remove min_t() in ath11k_mac_fill_reg_tpc_info() for not is_tpe_present 6. rebased to ath-202309051328 link of v5: [PATCH v5 0/5] fix wrong TX power and frequency in regdomain by dynamic switch 6 GHz reg rules of LPI/SP/VLP for station mode https://lore.kernel.org/linux-wireless/20230803071701.15084-1-quic_wgong@quicinc.com/ v5: change per Kalle and rebased to ath.git ath-202306211808 1. ath11k_ieee80211_ap_pwr_type_convert() to ath11k_reg_ap_pwr_convert() 2. used list_first_entry_or_null() and add comments 3. ath11k_dbg() to ath11k_warn() 4. ath11k_hw_supports_6g_cc_ext() to ath11k_mac_supports_6g_cc_ext() 5. add mesh in commit log v4: (NOT depends to any patch now). 1. removed patches which depends on wifi: cfg80211: save Power Spectral Density (PSD) of the regulatory rule https://lore.kernel.org/linux-wireless/20230315132904.31779-3-quic_adisi@quicinc.com/ removed: [v3,08/15] wifi: ath11k: save power spectral density(psd) of regulatory rule [v3,09/15] wifi: ath11k: add parse of transmit power envelope element [v3,10/15] wifi: ath11k: save max tx power in vdev start response event from firmware [v3,11/15] wifi: ath11k: fill parameters for vdev_set_tpc_power wmi command [v3,12/15] wifi: ath11k: add WMI_TLV_SERVICE_EXT_TPC_REG_SUPPORT service bit [v3,13/15] wifi: ath11k: discard BSS_CHANGED_TXPOWER when EXT_TPC_REG_SUPPORT for 6 GHz [v3,14/15] wifi: ath11k: add handler for WMI_VDEV_SET_TPC_POWER_CMDID [v3,15/15] wifi: ath11k: send TPC power to firmware for 6 GHz station 2. rebased to ath.git ath-202304281700 3. deleted "wifi: ath11k: Add support to parse new wmi event for 6 GHz regulatory" which is alreay upstream. link of v3: [v3,00/15] wifi: ath11k: add support for 6 GHz station for various modes : LPI, SP and VLP https://patchwork.kernel.org/project/linux-wireless/cover/20220913051518.23051-1-quic_wgong@quicinc.com/ v3: 1. added "ath11k: fix a possible dead lock caused by ab->base_lock". 3. deleted "ath11k: add support for extended wmi service bit" which is alreay upstream. v2: 1. change some minor comments by Kalle. 2. rebased to ath.git ath-202112220603 Baochen Qiang (1): wifi: ath11k: fix a possible dead lock caused by ab->base_lock Wen Gong (11): wifi: ath11k: add support to select 6 GHz regulatory type wifi: ath11k: store cur_regulatory_info for each radio wifi: ath11k: update regulatory rules when interface added wifi: ath11k: update regulatory rules when connect to AP on 6 GHz band for station wifi: ath11k: save power spectral density(PSD) of regulatory rule wifi: ath11k: add parse of transmit power envelope element wifi: ath11k: save max tx power in vdev start response event from firmware wifi: ath11k: fill parameters for vdev set tpc power WMI command wifi: ath11k: add WMI_TLV_SERVICE_EXT_TPC_REG_SUPPORT service bit wifi: ath11k: add handler for WMI_VDEV_SET_TPC_POWER_CMDID wifi: ath11k: use WMI_VDEV_SET_TPC_POWER_CMDID when EXT_TPC_REG_SUPPORT for 6 GHz drivers/net/wireless/ath/ath11k/core.h | 40 ++ drivers/net/wireless/ath/ath11k/mac.c | 515 ++++++++++++++++++++++++- drivers/net/wireless/ath/ath11k/mac.h | 3 + drivers/net/wireless/ath/ath11k/reg.c | 89 ++++- drivers/net/wireless/ath/ath11k/reg.h | 6 +- drivers/net/wireless/ath/ath11k/wmi.c | 234 ++++++++--- drivers/net/wireless/ath/ath11k/wmi.h | 69 ++++ 7 files changed, 886 insertions(+), 70 deletions(-) base-commit: 6c4f0b0146c7c9c7791dc1a55e13e317897e91ac